Skip to contentSkip to conversation

Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

PATCH New Udit Agarwal 2 participants 3 messages Mar 7, 2019 – Apr 22, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled

---
Changes in V2:
Corrects commit message.
Removes goto label.

 arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +2 -9
index 34167cdd50..5b945f5959 100644
@@ -795,12 +795,8 @@ enum env_location env_get_location(enum env_operation op, int prio)
 	if (prio)
 		return ENVL_UNKNOWN;
 
-#ifdef CONFIG_CHAIN_OF_TRUST
-	/* Check Boot Mode
-	 * If Boot Mode is Secure, return ENVL_NOWHERE
-	 */
-	if (fsl_check_boot_mode_secure() == 1)
-		goto done;
+#ifdef	CONFIG_ENV_IS_NOWHERE
+		return env_loc;
 #endif
 
 	switch (src) {
@@ -830,9 +826,6 @@ enum env_location env_get_location(enum env_operation op, int prio)
 		break;
 	}
 
-#ifdef CONFIG_CHAIN_OF_TRUST
-done:
-#endif
 	return env_loc;
 }
 #endif	/* CONFIG_TFABOOT */
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

Quoted 12 lines

-----Original Message-----
From: Udit Agarwal
Sent: Thursday, March 7, 2019 2:55 PM
To: u-boot at lists.denx.de
Cc: Prabhakar Kushwaha <[email protected]>; Ruchika Gupta <[email protected]>; Jaiprakash Singh <[email protected]>; Arun Pathak <[email protected]>; Udit Agarwal <[email protected]>
Subject: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

Quoted 6 lines

ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled

---

S /ENVL /ENV

--pk

#2 lore raw

PATCH v2 1/1 Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

Hi,

arch/arm/cpu/armv8/fsl-layerscape/cpu.c uses ENVL_NOWHERE to initialize the env_loc enum variable. Shall the ENVL_NOWHERE be replaced with ENV_NOWHERE in commit message.

Regards
Udit Agarwal

Quoted 30 lines

-----Original Message-----
From: Prabhakar Kushwaha
Sent: Friday, March 22, 2019 4:32 PM
To: Udit Agarwal <[email protected]>; u-boot at lists.denx.de
Cc: Ruchika Gupta <[email protected]>; Jaiprakash Singh <[email protected]>; Arun Pathak <[email protected]>
Subject: RE: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

Quoted 10 lines

-----Original Message-----
From: Udit Agarwal
Sent: Thursday, March 7, 2019 2:55 PM
To: u-boot at lists.denx.de
Cc: Prabhakar Kushwaha <[email protected]>; Ruchika Gupta <[email protected]>; Jaiprakash Singh <[email protected]>; Arun Pathak <[email protected]>; Udit Agarwal <[email protected]>
Subject: [PATCH v2 1/1] Set environment location to ENVL_NOWHERE with CONFIG_ENV_IS_NOWHERE.

Quoted 6 lines

ENVL_NOWHERE is dependent on CONFIG_ENV_IS_NOWHERE and not on CONFIG_CHAIN_OF_TRUST so return ENVL_NOWHERE when CONFIG_ENV_IS_NOWHERE is enabled

---

S /ENVL /ENV

--pk