mmc: pxamci: fix enum type confusion
PATCH 1/1 mmc: pxamci: fix enum type confusion
clang points out several instances of mismatched types in this drivers, all coming from a single declaration:
drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to
different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion]
direction = DMA_DEV_TO_MEM;
~ ^~~~~~~~~~~~~~drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to
different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion]
tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction,
The behavior is correct, so this must be a simply typo from dma_data_direction and dma_transfer_direction being similarly named types with a similar purpose.
--- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/pxamci.c +1 -1
@@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);static void pxamci_setup_data (struct pxamci_host *host,struct mmc_data *data) {struct dma_async_tx_descriptor *tx; -enum dma_data_direction direction; +enum dma_transfer_direction direction;struct dma_slave_config config;struct dma_chan *chan;unsigned int nob = data->blocks;
Signature · 1 line
2.20.0
Quoted 11 lines · Arnd Bergmann
clang points out several instances of mismatched types in this drivers, all coming from a single declaration:
drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enumdma_transfer_direction' todifferent enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] direction = DMA_DEV_TO_MEM; ~ ^~~~~~~~~~~~~~
drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enumdma_data_direction' to
different enumeration type 'enumdma_transfer_direction' [-Werror,-Wenum-conversion]
tx = dmaengine_prep_slave_sg(chan,data->sg,host->dma_len, direction,
Quoted 6 lines
The behavior is correct, so this must be a simply typo from
dma_data_directionanddma_transfer_directionbeing similarly named types with a similar purpose.Fixes 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 20 lines
--- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/pxamci.c +1
-1@@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);static void pxamci_setup_data (struct pxamci_host *host,struct mmc_data *data) {struct dma_async_tx_descriptor *tx; -enum dma_data_direction direction; +enum dma_transfer_direction direction;struct dma_slave_config config;struct dma_chan *chan;unsigned int nob = data->blocks;Signature · 1 line
2.20.0
Robert Jarzmik
Acked-byQuoted 12 lines · Nathan Chancellor
Quoted 11 lines · Arnd Bergmann
clang points out several instances of mismatched types in this drivers, all coming from a single declaration:
drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enumdma_transfer_direction' todifferent enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] direction = DMA_DEV_TO_MEM; ~ ^~~~~~~~~~~~~~
drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enumdma_data_direction' to
different enumeration type 'enumdma_transfer_direction' [-Werror,-Wenum-conversion]
tx = dmaengine_prep_slave_sg(chan,data->sg,host->dma_len, direction,
Quoted 8 lines
Quoted 6 lines
The behavior is correct, so this must be a simply typo from
dma_data_directionanddma_transfer_directionbeing similarly named types with a similar purpose.Fixes 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")Signed-off-by Arnd Bergmann <[email protected]>Reviewed-by Nathan Chancellor <[email protected]>
Cheers.
--
Robert
Quoted 12 lines · Arnd Bergmann
clang points out several instances of mismatched types in this drivers, all coming from a single declaration:
drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enumdma_transfer_direction' todifferent enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] direction = DMA_DEV_TO_MEM; ~ ^~~~~~~~~~~~~~
drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enumdma_data_direction' to
different enumeration type 'enumdma_transfer_direction' [-Werror,-Wenum-conversion]
tx = dmaengine_prep_slave_sg(chan,data->sg,host->dma_len, direction,
Quoted 6 lines
The behavior is correct, so this must be a simply typo from
dma_data_directionanddma_transfer_directionbeing similarly named types with a similar purpose.Fixes 6464b7140951 ("mmc: pxamci: switch over to dmaengine use")Signed-off-by Arnd Bergmann <[email protected]>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/pxamci.c +1
-2@@ -162,7 +162,7 @@ static void pxamci_dma_irq(void *param);static void pxamci_setup_data (struct pxamci_host *host,struct mmc_data *data) {struct dma_async_tx_descriptor *tx; -enum dma_data_direction direction; +enum dma_transfer_direction direction;struct dma_slave_config config;struct dma_chan *chan;unsigned int nob = data->blocks; --2.20.0