Skip to contentSkip to conversation

iio: common: ssp_sensors: Initialize calculated_time in ssp_common_process_data

PATCH In review Nathan Chancellor 4 participants 5 messages Mar 7, 2019 – Mar 11, 2019 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: common: ssp_sensors: Initialize calculated_time in ssp_common_process_data

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler).

Fix this by just zero initializing calculated_time.

---
 drivers/iio/common/ssp_sensors/ssp_iio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/ssp_sensors/ssp_iio.c +1 -1
index 645f2e3975db..e38f704d88b7 100644
@@ -81,7 +81,7 @@ int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
 			    unsigned int len, int64_t timestamp)
 {
 	__le32 time;
-	int64_t calculated_time;
+	int64_t calculated_time = 0;
 	struct ssp_sensor_data *spd = iio_priv(indio_dev);
 
 	if (indio_dev->scan_bytes == 0)
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Nathan Chancellor

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler).

Quoted 4 lines

Fix this by just zero initializing calculated_time.

Knowing that the same invariant holds across function boundaries to protect access of unitialized values and thus undefined behavior sounds tricky to diagnose accurately. Thanks for the patch.

Quoted 20 lines
---
 drivers/iio/common/ssp_sensors/ssp_iio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/ssp_sensors/ssp_iio.c +1 -2
index 645f2e3975db..e38f704d88b7 100644
@@ -81,7 +81,7 @@ int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
                            unsigned int len, int64_t timestamp)
 {
        __le32 time;
-       int64_t calculated_time;
+       int64_t calculated_time = 0;
        struct ssp_sensor_data *spd = iio_priv(indio_dev);
 
        if (indio_dev->scan_bytes == 0)
--

2.21.0

Signature · 2 lines
Thanks,
~Nick Desaulniers
maintainer
#2 lore raw
Quoted 19 lines · On Thu, 7 Mar 2019 16:35:26 -0800 Nick Desaulniers <[email protected]>…
Quoted 17 lines · Nathan Chancellor

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler).

Fix this by just zero initializing calculated_time.

Quoted 7 lines
Quoted 2 lines

Knowing that the same invariant holds across function boundaries to protect access of unitialized values and thus undefined behavior sounds tricky to diagnose accurately. Thanks for the patch.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Note this is going to be a while before it hits mainline but as it is a false (if reasonable!) warning I'm not going to rush it in as a fix.

Thanks,

Jonathan

Quoted 23 lines
Quoted 21 lines
---
 drivers/iio/common/ssp_sensors/ssp_iio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/common/ssp_sensors/ssp_iio.c +1 -2
index 645f2e3975db..e38f704d88b7 100644
@@ -81,7 +81,7 @@ int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
                            unsigned int len, int64_t timestamp)
 {
        __le32 time;
-       int64_t calculated_time;
+       int64_t calculated_time = 0;
        struct ssp_sensor_data *spd = iio_priv(indio_dev);
 
        if (indio_dev->scan_bytes == 0)
--

2.21.0

#3 lore raw
Quoted 26 lines · Jonathan Cameron
Quoted 18 lines · On Thu, 7 Mar 2019 16:35:26 -0800 Nick Desaulniers <[email protected]>…
Quoted 17 lines · Nathan Chancellor

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler).

Fix this by just zero initializing calculated_time.

Quoted 7 lines
Quoted 2 lines

Knowing that the same invariant holds across function boundaries to protect access of unitialized values and thus undefined behavior sounds tricky to diagnose accurately. Thanks for the patch.

Quoted 6 lines

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Note this is going to be a while before it hits mainline but as it is a false (if reasonable!) warning I'm not going to rush it in as a fix.

I think it's actually a correct warning, it just doesn't trigger on gcc because of a known gcc bug.

I'm not sure however why I don't see the warning with clang-8 on my local build. Is this something I have to enable separately?

Arnd

#4 lore raw
Quoted 34 lines · Arnd Bergmann
Quoted 26 lines · Jonathan Cameron
Quoted 18 lines · On Thu, 7 Mar 2019 16:35:26 -0800 Nick Desaulniers <[email protected]>…
Quoted 17 lines · Nathan Chancellor

When building with -Wsometimes-uninitialized, Clang warns:

drivers/iio/common/ssp_sensors/ssp_iio.c:95:6: warning: variable 'calculated_time' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

While it isn't wrong, this will never be a problem because iio_push_to_buffers_with_timestamp only uses calculated_time on the same condition that it is assigned (when scan_timestamp is not zero). While iio_push_to_buffers_with_timestamp is marked as inline, Clang does inlining in the optimization stage, which happens after the semantic analysis phase (plus inline is merely a hint to the compiler).

Fix this by just zero initializing calculated_time.

Quoted 7 lines
Quoted 2 lines

Knowing that the same invariant holds across function boundaries to protect access of unitialized values and thus undefined behavior sounds tricky to diagnose accurately. Thanks for the patch.

Quoted 6 lines

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Note this is going to be a while before it hits mainline but as it is a false (if reasonable!) warning I'm not going to rush it in as a fix.

Quoted 8 lines

I think it's actually a correct warning, it just doesn't trigger on gcc because of a known gcc bug.

I'm not sure however why I don't see the warning with clang-8 on my local build. Is this something I have to enable separately?

Arnd

Yes, -Wsometimes-uninitialized is not on by default because -Wuninitialized is disabled. You can either pass it via KCFLAGS or modify scripts/Makefile.extrawarn, which is the eventual goal because Clang can catch things that GCC can't:

https://github.com/ClangBuiltLinux/linux/issues/381

Cheers,
Nathan