Skip to contentSkip to conversation

Fix malformed SPDX-License-Identifier

PATCH Superseded Wentao Cai 3 participants 9 messages Mar 8, 2019 – Mar 9, 2019

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Wentao Cai

author
#0 lore raw

v3 cover Fix malformed SPDX-License-Identifier

Fix SPDX-License-Identifier in drivers/staging/most/dim2/

Wentao Cai (4):
Staging: most: dim2: Fix SPDX-License-Identifier in errors.h
Staging: most: dim2: Fix SPDX-License-Identifier in hal.h
Staging: most: dim2: Fix SPDX-License-Identifier in sysfs.h
Staging: most: dim2: Fix SPDX-License-Identifier in reg.h

 drivers/staging/most/dim2/errors.h | 2 +-
 drivers/staging/most/dim2/hal.h    | 2 +-
 drivers/staging/most/dim2/reg.h    | 2 +-
 drivers/staging/most/dim2/sysfs.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v3 1/4 Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/errors.h +1 -1
index 3487510fbd2f..cbbdaaf5c52d 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * errors.h - Definitions of errors for DIM2 HAL API
  * (MediaLB, Device Interface Macro IP, OS62420)
Signature · 1 line
2.11.0
#2 lore raw

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

Sorry to mess up patch version, I'll revise it.

Wentao

maintainer
#5 lore raw

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

In reply to Wentao Cai
Quoted 13 lines · Wentao Cai

Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/errors.h +0 -0
index 3487510fbd2f..cbbdaaf5c52d 100644

drivers/staging/most/dim2/errors.h line 1

Quoted 2 lines
drivers/staging/most/dim2/errors.h +1 -1
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */

You just changed the license of the file, not good at all :(

Don't do this unless you _really_ like talking to lawyers...

thanks,

greg k-h

maintainer
#8 lore raw
In reply to Wentao Cai
Quoted 7 lines · Wentao Cai

Fix SPDX-License-Identifier in drivers/staging/most/dim2/

Wentao Cai (4):
Staging: most: dim2: Fix SPDX-License-Identifier in errors.h
Staging: most: dim2: Fix SPDX-License-Identifier in hal.h
Staging: most: dim2: Fix SPDX-License-Identifier in sysfs.h
Staging: most: dim2: Fix SPDX-License-Identifier in reg.h

Usually it is easier to put the filename at the beginning of the line, not at the end, so this would look like:

Staging: most: dim2: errors.h:Fix SPDX-License-Identifier
Staging: most: dim2: hal.h: Fix SPDX-License-Identifier
Staging: most: dim2: sysfs.h: Fix SPDX-License-Identifier
Staging: most: dim2: reg.h: Fix SPDX-License-Identifier

But, note, your text here is not correct, I'll say more about that in your first patch...

Quoted 6 lines
 drivers/staging/most/dim2/errors.h | 2 +-
 drivers/staging/most/dim2/hal.h    | 2 +-
 drivers/staging/most/dim2/reg.h    | 2 +-
 drivers/staging/most/dim2/sysfs.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Please use git send-email to properly "thread" your patches the next time you resend this series.

thanks,

greg k-h

maintainer
#7 lore raw

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

In reply to Wentao Cai
Quoted 2 lines · Wentao Cai

Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

You are not "fixing" the identifier so much as using the "correct" comment characters. The identifier text itself is correct and nothing needs to be "fixed" in it.

thanks,

greg k-h

#3 lore raw

Re: [Outreachy kernel] Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

In reply to [email protected]
Quoted 1 line · On Thu, 7 Mar 2019, [email protected] wrote:

Sorry to mess up patch version, I'll revise it.

It's nice to quote what you are responding to, so the reader has some context beyond the subject line. Just to remember for next time.

julia

Quoted 13 lines

Wentao

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/8d797e93-e9be-4122-b9a7- 5baa4d41ccf2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#6 lore raw

Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

In reply to Greg KH
Quoted 10 lines · gregkh
Quoted 9 lines

You just changed the license of the file, not good at all :(

Don't do this unless you _really_ like talking to lawyers...

thanks,

greg k-h

Sorry, I'll revise it in next version.

Wentao

#4 lore raw

Re: [Outreachy kernel] Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h

In reply to Julia Lawall
Quoted 4 lines · Julia Lawall

It's nice to quote what you are responding to, so the reader has some context beyond the subject line. Just to remember for next time.

julia

Thanks Julia! I'll be more careful next time!

Wentao