Skip to contentSkip to conversation

drm/i915: relax debug BUG_ON() for closed context in hw_id pin

PATCH In review Zhenyu Wang 3 participants 5 messages Mar 8, 2019 – Mar 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: relax debug BUG_ON() for closed context in hw_id pin

Current GVT created context is marked closed as not to be used for host user. But its hw_id should still be used. So this is to relax debug BUG_ON() in __i915_gem_context_pin_hw_id() for GVT contexts which can use force single submission flag to identify.

---
 drivers/gpu/drm/i915/i915_gem_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_context.c +2 -1
index b9f321947982..0cbc5293da1c 100644
@@ -1400,7 +1400,8 @@ int __i915_gem_context_pin_hw_id(struct i915_gem_context *ctx)
 
 	mutex_lock(&i915->contexts.mutex);
 
-	GEM_BUG_ON(i915_gem_context_is_closed(ctx));
+	GEM_BUG_ON(i915_gem_context_is_closed(ctx) &&
+		   !i915_gem_context_force_single_submission(ctx));
 
 	if (list_empty(&ctx->hw_id_link)) {
 		GEM_BUG_ON(atomic_read(&ctx->hw_id_pin_count));
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Zhenyu Wang (2019-03-08 07:52:37)

Quoted 4 lines

Current GVT created context is marked closed as not to be used for host user. But its hw_id should still be used. So this is to relax debug BUG_ON() in __i915_gem_context_pin_hw_id() for GVT contexts which can use force single submission flag to identify.

The alternative strategy would be to always pin the id for GVT. How many gvt contexts? One per host or one per client? Or we don't mark them as closed (not so keen on that as it does provide some protection).

I think I'd rather delete the GEM_BUG_ON() if it's not invariant -- we only escape it firing for kernel contexts because they pin their id. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.BAT: failure for drm/i915: relax debug BUG_ON() for closed context in hw_id pin

In reply to Zhenyu Wang
== Series Details ==

== Series Details ==

Series: drm/i915: relax debug BUG_ON() for closed context in hw_id pin
URL : https://patchwork.freedesktop.org/series/57726/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5718 -> Patchwork_12414
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12414 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12414, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/57726/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12414:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live_sanitycheck:
- fi-kbl-7560u: NOTRUN -> INCOMPLETE

Known issues
------------

Here are the changes found in Patchwork_12414 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-sdma:
- fi-kbl-7560u: NOTRUN -> SKIP [fdo#109271] +17

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17

* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +49

* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1

* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37

* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

#### Possible fixes ####

* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7560u: INCOMPLETE -> PASS

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: SKIP [fdo#109271] -> PASS

* igt@i915_pm_rpm@basic-rte:
- fi-byt-j1900: FAIL [fdo#108800] -> PASS

* igt@i915_selftest@live_hangcheck:
- fi-ilk-650: INCOMPLETE [fdo#109723] -> PASS

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: SKIP [fdo#109271] -> PASS +33

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-kbl-7560u: FAIL [fdo#103375] -> PASS

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109723]: https://bugs.freedesktop.org/show_bug.cgi?id=109723

Participating hosts (42 -> 39)
------------------------------

Additional (3): fi-cfl-guc fi-skl-6260u fi-icl-u3
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-pnv-d510

Build changes
-------------

* Linux: CI_DRM_5718 -> Patchwork_12414

CI_DRM_5718: 0d3ac523602514ac4473fca213efd8ffba373844 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12414: cb9951323fe05876d5eaaa95a0686b7c0d353012 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

cb9951323fe0 drm/i915: relax debug BUG_ON() for closed context in hw_id pin

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12414/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Chris Wilson
Quoted 10 lines · Chris Wilson

Quoting Zhenyu Wang (2019-03-08 07:52:37)

Quoted 4 lines

Current GVT created context is marked closed as not to be used for host user. But its hw_id should still be used. So this is to relax debug BUG_ON() in __i915_gem_context_pin_hw_id() for GVT contexts which can use force single submission flag to identify.

The alternative strategy would be to always pin the id for GVT. How many gvt contexts? One per host or one per client? Or we don't mark them as closed (not so keen on that as it does provide some protection).

Currently one per VM guest, always pin the id would also be good.

Quoted 2 lines

I think I'd rather delete the GEM_BUG_ON() if it's not invariant -- we only escape it firing for kernel contexts because they pin their id.

I think anyway we'd better pin id for gvt context, as it's good to keep it for one VM cycle.

thanks

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Quoting Zhenyu Wang (2019-03-09 03:39:36)

Quoted 12 lines · Chris Wilson
Quoted 10 lines

Quoting Zhenyu Wang (2019-03-08 07:52:37)

Quoted 4 lines

Current GVT created context is marked closed as not to be used for host user. But its hw_id should still be used. So this is to relax debug BUG_ON() in __i915_gem_context_pin_hw_id() for GVT contexts which can use force single submission flag to identify.

The alternative strategy would be to always pin the id for GVT. How many gvt contexts? One per host or one per client? Or we don't mark them as closed (not so keen on that as it does provide some protection).

Quoted 7 lines

Currently one per VM guest, always pin the id would also be good.

Quoted 2 lines

I think I'd rather delete the GEM_BUG_ON() if it's not invariant -- we only escape it firing for kernel contexts because they pin their id.

I think anyway we'd better pin id for gvt context, as it's good to keep it for one VM cycle.

Pin away, I have a plan to remove the hw-id limit... -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx