Skip to contentSkip to conversation

migration/rdma: Check qemu_rdma_init_one_block

PATCH In review Dr. David Alan Gilbert (git) 2 participants 2 messages Mar 8, 2019 – Mar 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 migration/rdma: Check qemu_rdma_init_one_block

From: "Dr. David Alan Gilbert" <[email protected]>

Actually it can't fail at the moment, but Coverity moans that it's the only place it's not checked, and it's an easy check.

Reported-by Coverity (CID 1399413)
---
 migration/rdma.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
migration/rdma.c +5 -1
index 63c118af09..c1bcece53b 100644
@@ -641,10 +641,14 @@ static int qemu_rdma_init_one_block(RAMBlock *rb, void *opaque)
 static int qemu_rdma_init_ram_blocks(RDMAContext *rdma)
 {
     RDMALocalBlocks *local = &rdma->local_ram_blocks;
+    int ret;
 
     assert(rdma->blockmap == NULL);
     memset(local, 0, sizeof *local);
-    foreach_not_ignored_block(qemu_rdma_init_one_block, rdma);
+    ret = foreach_not_ignored_block(qemu_rdma_init_one_block, rdma);
+    if (ret) {
+        return ret;
+    }
     trace_qemu_rdma_init_ram_blocks(local->nb_blocks);
     rdma->dest_blocks = g_new0(RDMADestBlock,
                                rdma->local_ram_blocks.nb_blocks);
Signature · 1 line
2.20.1