MIPS: uasm: Add div, mul and sel instructions for mipsr6
Subsystems (5)
PATCH v2 1/3 MIPS: uasm: Add div, mul and sel instructions for mipsr6
Add the following instructions for use by eBPF on mipsr6:insn_ddivu_r6, insn_divu_r6, insn_dmodu, insn_dmulu, insn_modu, insn_mulu, insn_seleqz, insn_selnez
--- arch/mips/include/asm/uasm.h | 8 +++++++ arch/mips/include/uapi/asm/inst.h | 6 ++--- arch/mips/mm/uasm-mips.c | 14 +++++++++++ arch/mips/mm/uasm.c | 39 +++++++++++++++++++------------ 4 files changed, 49 insertions(+), 18 deletions(-)
arch/mips/include/asm/uasm.h +8 -0
@@ -86,14 +86,18 @@ Ip_u2u1(_ctcmsa);Ip_u2u1s3 (_daddiu);Ip_u3u1u2 (_daddu);Ip_u1u2 (_ddivu); +Ip_u3u1u2 (_ddivu_r6);Ip_u1 (_di);Ip_u2u1msbu3 (_dins);Ip_u2u1msbu3 (_dinsm);Ip_u2u1msbu3 (_dinsu);Ip_u1u2 (_divu); +Ip_u3u1u2 (_divu_r6);Ip_u1u2u3 (_dmfc0); +Ip_u3u1u2 (_dmodu);Ip_u1u2u3 (_dmtc0);Ip_u1u2 (_dmultu); +Ip_u3u1u2 (_dmulu);Ip_u2u1u3 (_drotr);Ip_u2u1u3 (_drotr32);Ip_u2u1 (_dsbh);
@@ -131,6 +135,7 @@ Ip_u1u2u3(_mfc0);Ip_u1u2u3 (_mfhc0);Ip_u1 (_mfhi);Ip_u1 (_mflo); +Ip_u3u1u2 (_modu);Ip_u3u1u2 (_movn);Ip_u3u1u2 (_movz);Ip_u1u2u3 (_mtc0);
@@ -139,6 +144,7 @@ Ip_u1(_mthi);Ip_u1 (_mtlo);Ip_u3u1u2 (_mul);Ip_u1u2 (_multu); +Ip_u3u1u2 (_mulu);Ip_u3u1u2 (_nor);Ip_u3u1u2 (_or);Ip_u2u1u3 (_ori);
@@ -149,6 +155,8 @@ Ip_u2s3u1(_sb);Ip_u2s3u1 (_sc);Ip_u2s3u1 (_scd);Ip_u2s3u1 (_sd); +Ip_u3u1u2 (_seleqz); +Ip_u3u1u2 (_selnez);Ip_u2s3u1 (_sh);Ip_u2u1u3 (_sll);Ip_u3u2u1 (_sllv);
arch/mips/include/uapi/asm/inst.h +3 -3
@@ -55,9 +55,9 @@ enum spec_op { spec3_unused_op, spec4_unused_op, slt_op, sltu_op, dadd_op, daddu_op, dsub_op, dsubu_op, tge_op, tgeu_op, tlt_op, tltu_op, - teq_op, spec5_unused_op, tne_op, spec6_unused_op, - dsll_op, spec7_unused_op, dsrl_op, dsra_op, - dsll32_op, spec8_unused_op, dsrl32_op, dsra32_op + teq_op, seleqz_op, tne_op, selnez_op, + dsll_op, spec5_unused_op, dsrl_op, dsra_op, + dsll32_op, spec6_unused_op, dsrl32_op, dsra32_op };/*
arch/mips/mm/uasm-mips.c +14 -0
@@ -76,14 +76,22 @@ static const struct insn insn_table[insn_invalid] = { [insn_daddiu] = {M(daddiu_op, 0, 0, 0, 0, 0), RS | RT | SIMM}, [insn_daddu] = {M(spec_op, 0, 0, 0, 0, daddu_op), RS | RT | RD}, [insn_ddivu] = {M(spec_op, 0, 0, 0, 0, ddivu_op), RS | RT}, + [insn_ddivu_r6] = {M(spec_op, 0, 0, 0, ddivu_ddivu6_op, ddivu_op), + RS | RT | RD}, [insn_di] = {M(cop0_op, mfmc0_op, 0, 12, 0, 0), RT}, [insn_dins] = {M(spec3_op, 0, 0, 0, 0, dins_op), RS | RT | RD | RE}, [insn_dinsm] = {M(spec3_op, 0, 0, 0, 0, dinsm_op), RS | RT | RD | RE}, [insn_dinsu] = {M(spec3_op, 0, 0, 0, 0, dinsu_op), RS | RT | RD | RE}, [insn_divu] = {M(spec_op, 0, 0, 0, 0, divu_op), RS | RT}, + [insn_divu_r6] = {M(spec_op, 0, 0, 0, divu_divu6_op, divu_op), + RS | RT | RD}, [insn_dmfc0] = {M(cop0_op, dmfc_op, 0, 0, 0, 0), RT | RD | SET}, + [insn_dmodu] = {M(spec_op, 0, 0, 0, ddivu_dmodu_op, ddivu_op), + RS | RT | RD}, [insn_dmtc0] = {M(cop0_op, dmtc_op, 0, 0, 0, 0), RT | RD | SET}, [insn_dmultu] = {M(spec_op, 0, 0, 0, 0, dmultu_op), RS | RT}, + [insn_dmulu] = {M(spec_op, 0, 0, 0, dmult_dmul_op, dmultu_op), + RS | RT | RD}, [insn_drotr] = {M(spec_op, 1, 0, 0, 0, dsrl_op), RT | RD | RE}, [insn_drotr32] = {M(spec_op, 1, 0, 0, 0, dsrl32_op), RT | RD | RE}, [insn_dsbh] = {M(spec3_op, 0, 0, 0, dsbh_op, dbshfl_op), RT | RD},
@@ -132,12 +140,16 @@ static const struct insn insn_table[insn_invalid] = { [insn_mfhc0] = {M(cop0_op, mfhc0_op, 0, 0, 0, 0), RT | RD | SET}, [insn_mfhi] = {M(spec_op, 0, 0, 0, 0, mfhi_op), RD}, [insn_mflo] = {M(spec_op, 0, 0, 0, 0, mflo_op), RD}, + [insn_modu] = {M (spec_op,0 ,0 ,0 , divu_modu_op, divu_op), + RS | RT | RD}, [insn_movn] = {M(spec_op, 0, 0, 0, 0, movn_op), RS | RT | RD}, [insn_movz] = {M(spec_op, 0, 0, 0, 0, movz_op), RS | RT | RD}, [insn_mtc0] = {M(cop0_op, mtc_op, 0, 0, 0, 0), RT | RD | SET}, [insn_mthc0] = {M(cop0_op, mthc0_op, 0, 0, 0, 0), RT | RD | SET}, [insn_mthi] = {M(spec_op, 0, 0, 0, 0, mthi_op), RS}, [insn_mtlo] = {M(spec_op, 0, 0, 0, 0, mtlo_op), RS}, + [insn_mulu] = {M (spec_op,0 ,0 ,0 , multu_mulu_op, multu_op), +RS |RT |RD }, #ifndef CONFIG_CPU_MIPSR6 [insn_mul] = {M(spec2_op, 0, 0, 0, 0, mul_op), RS | RT | RD}, #else
@@ -163,6 +175,8 @@ static const struct insn insn_table[insn_invalid] = { [insn_scd] = {M6(spec3_op, 0, 0, 0, scd6_op), RS | RT | SIMM9}, #endif [insn_sd] = {M(sd_op, 0, 0, 0, 0, 0), RS | RT | SIMM}, + [insn_seleqz] = {M(spec_op, 0, 0, 0, 0, seleqz_op), RS | RT | RD}, + [insn_selnez] = {M(spec_op, 0, 0, 0, 0, selnez_op), RS | RT | RD}, [insn_sh] = {M(sh_op, 0, 0, 0, 0, 0), RS | RT | SIMM}, [insn_sll] = {M(spec_op, 0, 0, 0, 0, sll_op), RT | RD | RE}, [insn_sllv] = {M(spec_op, 0, 0, 0, 0, sllv_op), RS | RT | RD},
arch/mips/mm/uasm.c +24 -15
@@ -50,21 +50,22 @@ enum opcode { insn_beq, insn_beql, insn_bgez, insn_bgezl, insn_bgtz, insn_blez, insn_bltz, insn_bltzl, insn_bne, insn_break, insn_cache, insn_cfc1, insn_cfcmsa, insn_ctc1, insn_ctcmsa, insn_daddiu, insn_daddu, insn_ddivu, - insn_di, insn_dins, insn_dinsm, insn_dinsu, insn_divu, insn_dmfc0, - insn_dmtc0, insn_dmultu, insn_drotr, insn_drotr32, insn_dsbh, insn_dshd, - insn_dsll, insn_dsll32, insn_dsllv, insn_dsra, insn_dsra32, insn_dsrav, - insn_dsrl, insn_dsrl32, insn_dsrlv, insn_dsubu, insn_eret, insn_ext, - insn_ins, insn_j, insn_jal, insn_jalr, insn_jr, insn_lb, insn_lbu, - insn_ld, insn_lddir, insn_ldpte, insn_ldx, insn_lh, insn_lhu, - insn_ll, insn_lld, insn_lui, insn_lw, insn_lwu, insn_lwx, insn_mfc0, - insn_mfhc0, insn_mfhi, insn_mflo, insn_movn, insn_movz, insn_mtc0, - insn_mthc0, insn_mthi, insn_mtlo, insn_mul, insn_multu, insn_nor, - insn_or, insn_ori, insn_pref, insn_rfe, insn_rotr, insn_sb, - insn_sc, insn_scd, insn_sd, insn_sh, insn_sll, insn_sllv, - insn_slt, insn_slti, insn_sltiu, insn_sltu, insn_sra, insn_srav, - insn_srl, insn_srlv, insn_subu, insn_sw, insn_sync, insn_syscall, - insn_tlbp, insn_tlbr, insn_tlbwi, insn_tlbwr, insn_wait, insn_wsbh, - insn_xor, insn_xori, insn_yield, + insn_ddivu_r6, insn_di, insn_dins, insn_dinsm, insn_dinsu, insn_divu, + insn_divu_r6, insn_dmfc0, insn_dmodu, insn_dmtc0, insn_dmultu, + insn_dmulu, insn_drotr, insn_drotr32, insn_dsbh, insn_dshd, insn_dsll, + insn_dsll32, insn_dsllv, insn_dsra, insn_dsra32, insn_dsrav, insn_dsrl, + insn_dsrl32, insn_dsrlv, insn_dsubu, insn_eret, insn_ext, insn_ins, + insn_j, insn_jal, insn_jalr, insn_jr, insn_lb, insn_lbu, insn_ld, + insn_lddir, insn_ldpte, insn_ldx, insn_lh, insn_lhu, insn_ll, insn_lld, + insn_lui, insn_lw, insn_lwu, insn_lwx, insn_mfc0, insn_mfhc0, insn_mfhi, + insn_mflo, insn_modu, insn_movn, insn_movz, insn_mtc0, insn_mthc0, + insn_mthi, insn_mtlo, insn_mul, insn_multu, insn_mulu, insn_nor, + insn_or, insn_ori, insn_pref, insn_rfe, insn_rotr, insn_sb, insn_sc, + insn_scd, insn_seleqz, insn_selnez, insn_sd, insn_sh, insn_sll, + insn_sllv, insn_slt, insn_slti, insn_sltiu, insn_sltu, insn_sra, + insn_srav, insn_srl, insn_srlv, insn_subu, insn_sw, insn_sync, + insn_syscall, insn_tlbp, insn_tlbr, insn_tlbwi, insn_tlbwr, insn_wait, + insn_wsbh, insn_xor, insn_xori, insn_yield, insn_invalid/* insn_invalid must be last */ };
@@ -287,13 +288,17 @@ I_u2u1(_cfcmsa) I_u1u2(_ctc1) I_u2u1(_ctcmsa) I_u1u2(_ddivu) +I_u3u1u2(_ddivu_r6) I_u1u2u3(_dmfc0) +I_u3u1u2(_dmodu) I_u1u2u3(_dmtc0) I_u1u2(_dmultu) +I_u3u1u2(_dmulu) I_u2u1s3(_daddiu) I_u3u1u2(_daddu) I_u1(_di); I_u1u2(_divu) +I_u3u1u2(_divu_r6) I_u2u1(_dsbh); I_u2u1(_dshd); I_u2u1u3(_dsll)
@@ -327,6 +332,7 @@ I_u2s3u1(_lw) I_u2s3u1(_lwu) I_u1u2u3(_mfc0) I_u1u2u3(_mfhc0) +I_u3u1u2(_modu) I_u3u1u2(_movn) I_u3u1u2(_movz) I_u1(_mfhi)
@@ -337,6 +343,7 @@ I_u1(_mthi) I_u1(_mtlo) I_u3u1u2(_mul) I_u1u2(_multu) +I_u3u1u2(_mulu) I_u3u1u2(_nor) I_u3u1u2(_or) I_u2u1u3(_ori)
@@ -345,6 +352,8 @@ I_u2s3u1(_sb) I_u2s3u1(_sc) I_u2s3u1(_scd) I_u2s3u1(_sd) +I_u3u1u2(_seleqz) +I_u3u1u2(_selnez) I_u2s3u1(_sh) I_u2u1u3(_sll) I_u3u2u1(_sllv)
Signature · 1 line
2.18.0
PATCH v2 2/3 MIPS: eBPF: Provide eBPF support for MIPS64R6
Currently eBPF support is available on MIPS64R2 only. Use MIPS64R6 variants of instructions like multiply, divide, movn, movz so eBPF can run on the newer ISA. Also, we only need to check ISA revision before JIT'ing code, because we know the CPU is running a 64-bit kernel because eBPF JIT is only included in kernels with CONFIG_64BIT=y due to Kconfig dependencies.
--- arch/mips/net/ebpf_jit.c | 78 +++++++++++++++++++++++++++++++++++----- 1 file changed, 69 insertions(+), 9 deletions(-)
arch/mips/net/ebpf_jit.c +69 -9
@@ -22,6 +22,7 @@#include <asm/byteorder.h> #include <asm/cacheflush.h> #include <asm/cpu-features.h> +#include <asm/isa-rev.h> #include <asm/uasm.h> /* Registers used by JIT */
@@ -677,8 +678,12 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,if (insn->imm ==1 )/* Mult by 1 is a nop */ break ;gen_imm_to_reg (insn,MIPS_R_AT , ctx); -emit_instr (ctx, dmultu,MIPS_R_AT , dst); -emit_instr (ctx, mflo, dst); +if (MIPS_ISA_REV >=6 ) { +emit_instr (ctx, dmulu, dst, dst,MIPS_R_AT ); + }else { +emit_instr (ctx, dmultu,MIPS_R_AT , dst); +emit_instr (ctx, mflo, dst); + }break ;case BPF_ALU64 |BPF_NEG |BPF_K :/* ALU64_IMM */ dst =ebpf_to_mips_reg (ctx, insn, dst_reg);
@@ -700,8 +705,12 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,if (insn->imm ==1 )/* Mult by 1 is a nop */ break ;gen_imm_to_reg (insn,MIPS_R_AT , ctx); -emit_instr (ctx, multu, dst,MIPS_R_AT ); -emit_instr (ctx, mflo, dst); +if (MIPS_ISA_REV >=6 ) { +emit_instr (ctx, mulu, dst, dst,MIPS_R_AT ); + }else { +emit_instr (ctx, multu, dst,MIPS_R_AT ); +emit_instr (ctx, mflo, dst); + }break ;case BPF_ALU |BPF_NEG |BPF_K :/* ALU_IMM */ dst =ebpf_to_mips_reg (ctx, insn, dst_reg);
@@ -732,6 +741,13 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,break ; }gen_imm_to_reg (insn,MIPS_R_AT , ctx); +if (MIPS_ISA_REV >=6 ) { +if (bpf_op ==BPF_DIV ) +emit_instr (ctx, divu_r6, dst, dst,MIPS_R_AT ); +else +emit_instr (ctx, modu, dst, dst,MIPS_R_AT ); +break ; + }emit_instr (ctx, divu, dst,MIPS_R_AT );if (bpf_op ==BPF_DIV )emit_instr (ctx, mflo, dst);
@@ -754,6 +770,13 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,break ; }gen_imm_to_reg (insn,MIPS_R_AT , ctx); +if (MIPS_ISA_REV >=6 ) { +if (bpf_op ==BPF_DIV ) +emit_instr (ctx, ddivu_r6, dst, dst,MIPS_R_AT ); +else +emit_instr (ctx, modu, dst, dst,MIPS_R_AT ); +break ; + }emit_instr (ctx, ddivu, dst,MIPS_R_AT );if (bpf_op ==BPF_DIV )emit_instr (ctx, mflo, dst);
@@ -819,11 +842,23 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,emit_instr (ctx, and, dst, dst, src);break ;case BPF_MUL : -emit_instr (ctx, dmultu, dst, src); -emit_instr (ctx, mflo, dst); +if (MIPS_ISA_REV >=6 ) { +emit_instr (ctx, dmulu, dst, dst, src); + }else { +emit_instr (ctx, dmultu, dst, src); +emit_instr (ctx, mflo, dst); + }break ;case BPF_DIV :case BPF_MOD : +if (MIPS_ISA_REV >=6 ) { +if (bpf_op ==BPF_DIV ) +emit_instr (ctx, ddivu_r6, + dst, dst, src); +else +emit_instr (ctx, modu, dst, dst, src); +break ; + }emit_instr (ctx, ddivu, dst, src);if (bpf_op ==BPF_DIV )emit_instr (ctx, mflo, dst);
@@ -903,6 +938,13 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,break ;case BPF_DIV :case BPF_MOD : +if (MIPS_ISA_REV >=6 ) { +if (bpf_op ==BPF_DIV ) +emit_instr (ctx, divu_r6, dst, dst, src); +else +emit_instr (ctx, modu, dst, dst, src); +break ; + }emit_instr (ctx, divu, dst, src);if (bpf_op ==BPF_DIV )emit_instr (ctx, mflo, dst);
@@ -1006,8 +1048,15 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,emit_instr (ctx, dsubu,MIPS_R_T8 , dst, src);emit_instr (ctx, sltu,MIPS_R_AT , dst, src);/* SP known to be non-zero, movz becomes boolean not */ -emit_instr (ctx, movz,MIPS_R_T9 ,MIPS_R_SP ,MIPS_R_T8 ); -emit_instr (ctx, movn,MIPS_R_T9 ,MIPS_R_ZERO ,MIPS_R_T8 ); +if (MIPS_ISA_REV >=6 ) { +emit_instr (ctx, seleqz,MIPS_R_T9 , +MIPS_R_SP ,MIPS_R_T8 ); + }else { +emit_instr (ctx, movz,MIPS_R_T9 , +MIPS_R_SP ,MIPS_R_T8 ); +emit_instr (ctx, movn,MIPS_R_T9 , +MIPS_R_ZERO ,MIPS_R_T8 ); + }emit_instr (ctx, or,MIPS_R_AT ,MIPS_R_T9 ,MIPS_R_AT ); cmp_eq = bpf_op ==BPF_JGT ; dst =MIPS_R_AT ;
@@ -1366,6 +1415,17 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,if (src <0 )return src;if (BPF_MODE (insn->code) ==BPF_XADD ) { +/* +* If mem_off does not fit within the 9 bit ll/sc +* instruction immediate field, use a temp reg. +*/ +if (MIPS_ISA_REV >=6 && + (mem_off >=BIT (8 ) || mem_off < -BIT (8 ))) { +emit_instr (ctx, daddiu,MIPS_R_T6 , + dst, mem_off); + mem_off =0 ; + dst =MIPS_R_T6 ; + }switch (BPF_SIZE (insn->code)) {case BPF_W :if (get_reg_val_type (ctx, this_idx, insn->src_reg) ==REG_32BIT ) {
@@ -1720,7 +1780,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)unsigned int image_size;u8 *image_ptr; -if (!prog->jit_requested || !cpu_has_mips64r2) +if (!prog->jit_requested ||MIPS_ISA_REV <2 )return prog; tmp =bpf_jit_blind_constants (prog);
Signature · 1 line
2.18.0
PATCH v2 3/3 MIPS: eBPF: Initial eBPF support for MIPS32 architecture.
In reply to Hassan NaveedCurrently MIPS32 supports a JIT for classic BPF only, not extended BPF. This patch adds JIT support for extended BPF on MIPS32, so code is actually JIT'ed instead of being only interpreted. Instructions with 64-bit operands are not supported at this point.
We can delete classic BPF because the kernel will translate classic BPF programs into extended BPF and JIT them, eliminating the need for classic BPF.
--- arch/mips/Kconfig | 3 +- arch/mips/net/Makefile | 1 - arch/mips/net/bpf_jit.c | 1270 ----------------------------------- arch/mips/net/bpf_jit_asm.S | 285 -------- arch/mips/net/ebpf_jit.c | 113 ++-- 5 files changed, 70 insertions(+), 1602 deletions(-) delete mode 100644 arch/mips/net/bpf_jit.c delete mode 100644 arch/mips/net/bpf_jit_asm.S
arch/mips/Kconfig +1 -2
@@ -43,8 +43,7 @@ config MIPS select HAVE_ARCH_SECCOMP_FILTER select HAVE_ARCH_TRACEHOOK select HAVE_ARCH_TRANSPARENT_HUGEPAGE if CPU_SUPPORTS_HUGEPAGES && 64BIT - select HAVE_CBPF_JIT if (!64BIT && !CPU_MICROMIPS) - select HAVE_EBPF_JIT if (64BIT && !CPU_MICROMIPS) + select HAVE_EBPF_JIT if (!CPU_MICROMIPS) select HAVE_CONTEXT_TRACKING select HAVE_COPY_THREAD_TLS select HAVE_C_RECORDMCOUNT
arch/mips/net/Makefile +0 -1
@@ -1,4 +1,3 @@ # MIPS networking code -obj-$(CONFIG_MIPS_CBPF_JIT) += bpf_jit.o bpf_jit_asm.o obj-$(CONFIG_MIPS_EBPF_JIT) += ebpf_jit.o
arch/mips/net/bpf_jit.c deleted +0 -1270
1,270 lines not on this page · raw message
arch/mips/net/bpf_jit_asm.S deleted +0 -285
285 lines not on this page · raw message
arch/mips/net/ebpf_jit.c +69 -44
195 lines not on this page · raw message
Signature · 1 line
2.18.0
Hello,
Quoted 6 lines · Hassan Naveed
Add the following instructions for use by eBPF on mipsr6:
insn_ddivu_r6,insn_divu_r6,insn_dmodu,insn_dmulu,insn_modu,insn_mulu,insn_seleqz,insn_selnezSigned-off-by Hassan Naveed <[email protected]>Reviewed-by Paul Burton <[email protected]>
Series applied to mips-next.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]
Daniel Borkmann
maintainerRe: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture.
In reply to Hassan NaveedQuoted 9 lines · Hassan Naveed
Currently MIPS32 supports a JIT for classic BPF only, not extended BPF. This patch adds JIT support for extended BPF on MIPS32, so code is actually JIT'ed instead of being only interpreted. Instructions with 64-bit operands are not supported at this point.
We can delete classic BPF because the kernel will translate classic BPF programs into extended BPF and JIT them, eliminating the need for classic BPF.Signed-off-by Hassan Naveed <[email protected]>
Nice! Did you check BPF test suite (lib/test_bpf.ko) that both before/after the same number of cBPF programs could be JITed?
Please also follow-up to update Documentation/sysctl/net.txt, bpf_jit_enable section, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't hurt either if Paul would be good with that, too.
Any plans on completing eBPF support for mips32?
Thanks,
Daniel
RE: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture.
Hi Daniel,
Quoted 10 lines
Quoted 10 lines · Hassan Naveed
Quoted 8 lines
Currently MIPS32 supports a JIT for classic BPF only, not extended BPF. This patch adds JIT support for extended BPF on MIPS32, so code is actually JIT'ed instead of being only interpreted. Instructions with 64-bit operands are not supported at this point.
We can delete classic BPF because the kernel will translate classic BPF programs into extended BPF and JIT them, eliminating the need for classic BPF.
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Hassan Naveed <[email protected]>Nice! Did you check BPF test suite (
lib/test_bpf.ko) that both before/after the same number of cBPF programs could be JITed?
Yes, we did check that and the number of tests JITed is same. Hence we thought it's better to get rid of cBPF and simplify things.
Quoted 5 lines
Quoted 5 lines
Please also follow-up to update
Documentation/sysctl/net.txt,bpf_jit_enablesection, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't hurt either if Paul would be good with that, too.
I'll update the bpf_jit_enable section in the next patch. I believe this one is already applied.
Quoted 1 line
Quoted 1 line
Any plans on completing eBPF support for mips32?
It definitely is on my to-do list, though I'm not quite sure when I'd be able to get to it.
Quoted 3 lines
Quoted 3 lines
Thanks,
Daniel