Skip to contentSkip to conversation

iio: pms7003: sleect IIO_TRIGGERED_BUFFER

PATCH Applied Arnd Bergmann 3 participants 3 messages Mar 14, 2019 – Mar 16, 2019 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: pms7003: sleect IIO_TRIGGERED_BUFFER

Without IIO_TRIGGERED_BUFFER, this driver fails to link:

drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'

Fixes a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
---
 drivers/iio/chemical/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/chemical/Kconfig +1 -0
index d5d146e9e372..6f253092a523 100644
@@ -64,6 +64,7 @@ config IAQCORE
 config PMS7003
 	tristate "Plantower PMS7003 particulate matter sensor"
 	depends on SERIAL_DEV_BUS
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here to build support for the Plantower PMS7003 particulate
 	  matter sensor.
Signature · 1 line
2.20.0
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Arnd Bergmann

Without IIO_TRIGGERED_BUFFER, this driver fails to link:

Good catch, thanks (btw, perhaps typo in subject can be fixed before applying patch).

Quoted 26 lines

drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'

Fixes a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
---
 drivers/iio/chemical/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/chemical/Kconfig +1 -1
index d5d146e9e372..6f253092a523 100644
@@ -64,6 +64,7 @@ config IAQCORE
 config PMS7003
 	tristate "Plantower PMS7003 particulate matter sensor"
 	depends on SERIAL_DEV_BUS
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here to build support for the Plantower PMS7003 particulate
 	  matter sensor.
--

2.20.0

maintainer Applied
#2 lore raw
Quoted 7 lines · On Thu, 14 Mar 2019 18:27:35 +0100 Tomasz Duszynski <[email protected]> wrote:
Quoted 1 line · Arnd Bergmann

Without IIO_TRIGGERED_BUFFER, this driver fails to link:

Good catch, thanks (btw, perhaps typo in subject can be fixed before applying patch).

Applied to the fixes-togreg branch of iio.git with the typo fixed.

Thanks!

Jonathan

Quoted 27 lines
Quoted 27 lines

drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'

Fixes a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
---
 drivers/iio/chemical/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/chemical/Kconfig +1 -1
index d5d146e9e372..6f253092a523 100644
@@ -64,6 +64,7 @@ config IAQCORE
 config PMS7003
 	tristate "Plantower PMS7003 particulate matter sensor"
 	depends on SERIAL_DEV_BUS
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here to build support for the Plantower PMS7003 particulate
 	  matter sensor.
--

2.20.0