Skip to contentSkip to conversation

sound: rt5645: fix a NULL pointer dereference

PATCH In review Kangjie Lu 2 participants 3 messages Mar 15, 2019 – May 2, 2019

Subsystems (3)
lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 sound: rt5645: fix a NULL pointer dereference

devm_kcalloc() may fail and return NULL. The fix returns ENOMEM in case it fails to avoid NULL pointer dereference.

---
 sound/soc/codecs/rt5645.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/rt5645.c +3 -0
index 9a0751978090..f842775dbf2c 100644
@@ -3419,6 +3419,9 @@ static int rt5645_probe(struct snd_soc_component *component)
 		RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s),
 		GFP_KERNEL);
 
+	if (!rt5645->eq_param)
+		return -ENOMEM;
+
 	return 0;
 }
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Applied "ASoC: rt5645: fix a NULL pointer dereference" to the asoc tree

The patch

ASoC: rt5645: fix a NULL pointer dereference

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 15c8795ef111c865ba00f5efe5cd5d0c975132cd Mon Sep 17 00:00:00 2001

From: Kangjie Lu <[email protected]>
Date: Thu, 14 Mar 2019 22:48:32 -0500
Subject: [PATCH] ASoC: rt5645: fix a NULL pointer dereference

devm_kcalloc() may fail and return NULL. The fix returns ENOMEM in case it fails to avoid NULL pointer dereference.

---
 sound/soc/codecs/rt5645.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/rt5645.c +3 -0
index 9a0751978090..f842775dbf2c 100644
@@ -3419,6 +3419,9 @@ static int rt5645_probe(struct snd_soc_component *component)
 		RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s),
 		GFP_KERNEL);
 
+	if (!rt5645->eq_param)
+		return -ENOMEM;
+
 	return 0;
 }
 
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Applied "ASoC: rt5645: fix a NULL pointer dereference" to the asoc tree

In reply to Kangjie Lu

The patch

ASoC: rt5645: fix a NULL pointer dereference

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 51dd97d1df5fb9ac58b9b358e63e67b530f6ae21 Mon Sep 17 00:00:00 2001

From: Kangjie Lu <[email protected]>
Date: Thu, 14 Mar 2019 22:48:32 -0500
Subject: [PATCH] ASoC: rt5645: fix a NULL pointer dereference

devm_kcalloc() may fail and return NULL. The fix returns ENOMEM in case it fails to avoid NULL pointer dereference.

---
 sound/soc/codecs/rt5645.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/rt5645.c +3 -0
index 9a0751978090..f842775dbf2c 100644
@@ -3419,6 +3419,9 @@ static int rt5645_probe(struct snd_soc_component *component)
 		RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s),
 		GFP_KERNEL);
 
+	if (!rt5645->eq_param)
+		return -ENOMEM;
+
 	return 0;
 }
 
Signature · 1 line
2.20.1