Skip to contentSkip to conversation

arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT

PATCH New Krzysztof Kozlowski 3 participants 5 messages Mar 15, 2019 – May 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT

The CONFIG_DM_I2C_COMPAT was introduced in include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C.

In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning:

This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.

---

Not tested on Arndale board. Testing is welcomed.

---
 configs/arndale_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/arndale_defconfig +0 -1
index 24422645cbac..2f218e8bb64c 100644
@@ -24,7 +24,6 @@ CONFIG_CMD_SOUND=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale"
 CONFIG_ENV_IS_IN_MMC=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_S5P=y
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C

The CONFIG_POWER and CONFIG_POWER_I2C were introduced in include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix build break by adding CONFIG_POWER") and then it propagated up to include/configs/arndale.h. However before that commit, there was no build break at all on Arndale and SMDK5250 boards. It seems the commit fixed nothing and just added unused defines.

In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus.

---

Not tested on Arndale board. Testing is welcomed.

---
 include/configs/arndale.h | 8 --------
 1 file changed, 8 deletions(-)
include/configs/arndale.h +0 -8
index 06b02ce90a94..3d0ce471a42c 100644
@@ -32,10 +32,6 @@
 
 #define CONFIG_SYS_INIT_SP_ADDR	CONFIG_IRAM_STACK
 
-/* PMIC */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-
 #define CONFIG_PREBOOT
 
 #define CONFIG_S5P_PA_SYSRAM	0x02020000
@@ -44,8 +40,4 @@
 /* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */
 #define CONFIG_ARM_GIC_BASE_ADDRESS	0x10480000
 
-/* Power */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-
 #endif	/* __CONFIG_H */
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C

Quoted 11 lines · Krzysztof Kozlowski

The CONFIG_POWER and CONFIG_POWER_I2C were introduced in include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix build break by adding CONFIG_POWER") and then it propagated up to include/configs/arndale.h. However before that commit, there was no build break at all on Arndale and SMDK5250 boards. It seems the commit fixed nothing and just added unused defines.

In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus.

Quoted 8 lines

---

Not tested on Arndale board. Testing is welcomed.

---
 include/configs/arndale.h | 8 --------
 1 file changed, 8 deletions(-)
#3 lore raw

PATCH 1/2 arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT

In reply to Krzysztof Kozlowski
Quoted 15 lines · Krzysztof Kozlowski

The CONFIG_DM_I2C_COMPAT was introduced in include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C.

In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning:

This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.

Quoted 8 lines

---

Not tested on Arndale board. Testing is welcomed.

---
 configs/arndale_defconfig | 1 -
 1 file changed, 1 deletion(-)
#4 lore raw

PATCH 1/2 arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT

In reply to Krzysztof Kozlowski

Dear Krzysztof Kozlowski,

Quoted 29 lines · Krzysztof Kozlowski

The CONFIG_DM_I2C_COMPAT was introduced in include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C.

In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning:

This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.

---

Not tested on Arndale board. Testing is welcomed.

---
 configs/arndale_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/arndale_defconfig +0 -0
index 24422645cbac..2f218e8bb64c 100644

configs/arndale_defconfig CONFIG_CMD_SOUND=y · line 29

Quoted 7 lines
configs/arndale_defconfig +0 -1
@@ -24,7 +24,6 @@ CONFIG_CMD_SOUND=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale"
 CONFIG_ENV_IS_IN_MMC=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_S5P=y

Sorry to late response.
Could you please rebase this patch series?

Thanks,
Minkyu Kang.