Skip to contentSkip to conversation

x86, putuser: copy pasta into 32 and 64-bit versions

PATCH In review Alexey Dobriyan 2 participants 2 messages Mar 16, 2019 – Mar 24, 2019 x86

lore
Share & tools
lore
#0 lore raw

PATCH 2/4 x86, putuser: copy pasta into 32 and 64-bit versions

I'm going to rewrite 64-bit version to use normal x86_64 calling convention.

---

 arch/x86/lib/Makefile     |    3 -
 arch/x86/lib/putuser_64.S |  103 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 105 insertions(+), 1 deletion(-)
arch/x86/lib/Makefile +2 -1
@@ -21,7 +21,8 @@ clean-files := inat-tables.c
 obj-$(CONFIG_SMP) += msr-smp.o cache-smp.o
 
 lib-y := delay.o misc.o cmdline.o cpu.o
-lib-y += usercopy_$(BITS).o usercopy.o getuser.o putuser.o
+lib-y += usercopy_$(BITS).o usercopy.o getuser.o
+lib-y += putuser_$(BITS).o
 lib-y += memcpy_$(BITS).o
 lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
 lib-$(CONFIG_INSTRUCTION_DECODER) += insn.o inat.o insn-eval.o

similarity index 100%
rename from arch/x86/lib/putuser.S
rename to arch/x86/lib/putuser_32.S
new file mode 100644

arch/x86/lib/putuser_64.S new file +103 -0

103 lines not on this page · raw message

maintainer
#1 lore raw
Quoted 1 line · Alexey Dobriyan

I'm going to rewrite 64-bit version to use normal x86_64 calling convention.

This commit message is too laconic and it needs to be in passive voice and impartial. Also, here or in your 4/4 I'm missing the justification for why you're doing all this.

Signature · 4 lines
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.