Skip to contentSkip to conversation

mfd: add support for max77650 PMIC

PATCH RESEND Superseded Bartosz Golaszewski 6 participants 27 messages Mar 18, 2019 – Apr 4, 2019

Subsystems (8)

v6 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v6 cover mfd: add support for max77650 PMIC

From: Bartosz Golaszewski <[email protected]>

This series missed the last merge window so resending rebased on top of v5.1-rc1 with no functional changes.

---

This series adds support for max77650 ultra low-power PMIC. It provides the core mfd driver and a set of five sub-drivers for the regulator, power supply, gpio, leds and input subsystems.

Patches 1-4 add the DT binding documents. Patch 5 documents mfd_add_devices(). Patches 6-10 add all drivers. Last patch adds a MAINTAINERS entry for this device.

The regulator part is already upstream.

v1 -> v2:
=========

General:
- use C++ style comments for the SPDX license identifier and the copyright header
- s/MODULE_LICENSE("GPL")/MODULE_LICENSE("GPL v2")/
- lookup the virtual interrupt numbers in the MFD driver, setup resources for child devices and use platform_get_irq_byname() in sub-drivers
- picked up review tags
- use devm_request_any_context_irq() for interrupt requests

LEDs:
- changed the max77650_leds_ prefix to max77650_led_
- drop the max77650_leds structure as the only field it held was the regmap pointer, move said pointer to struct max77650_led
- change the driver name to "max77650-led"
- drop the last return value check and return the result of regmap_write() directly
- change the labeling scheme to one consistent with other LED drivers

ONKEY:
- drop the key reporting helper and call the input functions directly from interrupt handlers
- rename the rv local variable to error
- drop parent device asignment

Regulator:
- drop the unnecessary init_data lookup from the driver code
- drop unnecessary include

Charger:
- disable the charger on driver remove
- change the power supply type to POWER_SUPPLY_TYPE_USB

GPIO:
- drop interrupt support until we have correct implementation of hierarchical irqs in gpiolib

v2 -> v3:
=========

General:
- dropped regulator patches as they're already in Mark Brown's branch

LED:
- fix the compatible string in the DT binding example
- use the max_brightness property
- use a common prefix ("MAX77650_LED") for all defines in the driver

MFD:
- add the MODULE_DEVICE_TABLE()
- add a sentinel to the of_device_id array
- constify the pointers to irq names
- use an enum instead of defines for interrupt indexes

v3 -> v4:
=========

GPIO:
- as discussed with Linus Walleij: the gpio-controller is now part of the core mfd module (we don't spawn a sub-node anymore), the binding document for GPIO has been dropped, the GPIO properties have been defined in the binding document for the mfd core, the interrupt functionality has been reintroduced with the irq directly passed from the mfd part
- due to the above changes the Reviewed-by tag from Linus was dropped

v4 -> v5:
=========

General:
- add a patch documenting mfd_add_devices()

MFD:
- pass the regmap irq_chip irq domain to mfd over mfd_add_devices so that the hw interrupts from resources can be correctly mapped to virtual irqs
- remove the enum listing cell indexes
- extend Kconfig help
- add a link to the programming manual
- use REGMAP_IRQ_REG() for regmap interrupts (except for GPI which has is composed of two hw interrupts for rising and falling edge)
- add error messages in probe
- use PLATFORM_DEVID_NONE constant in devm_mfd_add_devices()
- set irq_base to 0 in regmap_add_irq_chip() as other users to, it's only relevant if it's > 0

Charger:
- use non-maxim specific property names for minimum input voltage and current limit
- code shrink by using the enable/disable charger helpers everywhere
- use more descriptive names for constants

Onkey:
- use EV_SW event type for slide mode

LED:
- remove stray " from Kconfig help

v5 -> v6:
=========

MFD:
- remove stray spaces in the binding document
- rename the example dt node
- remove unnecessary interrupt-parent property from the bindings

LED:
- add a missing dependency on LEDS_CLASS to Kconfig

Onkey:
- use boolean for the slide button property

Charger:
- fix the property names in DT example
- make constants even more readable

Bartosz Golaszewski (11):
dt-bindings: mfd: add DT bindings for max77650
dt-bindings: power: supply: add DT bindings for max77650
dt-bindings: leds: add DT bindings for max77650
dt-bindings: input: add DT bindings for max77650
mfd: core: document mfd_add_devices()
mfd: max77650: new core mfd driver
power: supply: max77650: add support for battery charger
gpio: max77650: add GPIO support
leds: max77650: add LEDs support
input: max77650: add onkey support
MAINTAINERS: add an entry for max77650 mfd driver

 .../bindings/input/max77650-onkey.txt         |  26 ++
 .../bindings/leds/leds-max77650.txt           |  57 +++
 .../devicetree/bindings/mfd/max77650.txt      |  46 +++
 .../power/supply/max77650-charger.txt         |  27 ++
 MAINTAINERS                                   |  14 +
 drivers/gpio/Kconfig                          |   7 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-max77650.c                  | 190 +++++++++
 drivers/input/misc/Kconfig                    |   9 +
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/max77650-onkey.c           | 121 ++++++
 drivers/leds/Kconfig                          |   6 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-max77650.c                  | 147 +++++++
 drivers/mfd/Kconfig                           |  14 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/max77650.c                        | 234 +++++++++++
 drivers/mfd/mfd-core.c                        |  14 +
 drivers/power/supply/Kconfig                  |   7 +
 drivers/power/supply/Makefile                 |   1 +
 drivers/power/supply/max77650-charger.c       | 366 ++++++++++++++++++
 include/linux/mfd/max77650.h                  |  59 +++
 22 files changed, 1349 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/max77650.txt
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
 create mode 100644 drivers/gpio/gpio-max77650.c
 create mode 100644 drivers/input/misc/max77650-onkey.c
 create mode 100644 drivers/leds/leds-max77650.c
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 drivers/power/supply/max77650-charger.c
 create mode 100644 include/linux/mfd/max77650.h
Signature · 1 line
2.20.1
#1 lore raw

PATCH RESEND v6 1/11 dt-bindings: mfd: add DT bindings for max77650

From: Bartosz Golaszewski <[email protected]>

Add a DT binding document for max77650 ultra-low power PMIC. This describes the core mfd device and the GPIO module.

---
 .../devicetree/bindings/mfd/max77650.txt      | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/max77650.txt
Documentation/devicetree/bindings/mfd/max77650.txt new file +46 -0
new file mode 100644
index 000000000000..b529d8d19335
@@ -0,0 +1,46 @@
+MAX77650 ultra low-power PMIC from Maxim Integrated.
+
+Required properties:
+-------------------
+- compatible:		Must be "maxim,max77650"
+- reg:			I2C device address.
+- interrupts:		The interrupt on the parent the controller is
+			connected to.
+- interrupt-controller: Marks the device node as an interrupt controller.
+- #interrupt-cells:	Must be <2>.
+
+- gpio-controller:	Marks the device node as a gpio controller.
+- #gpio-cells:		Must be <2>. The first cell is the pin number and
+			the second cell is used to specify the gpio active
+			state.
+
+Optional properties:
+--------------------
+gpio-line-names:	Single string containing the name of the GPIO line.
+
+The GPIO-controller module is represented as part of the top-level PMIC
+node. The device exposes a single GPIO line.
+
+For device-tree bindings of other sub-modules (regulator, power supply,
+LEDs and onkey) refer to the binding documents under the respective
+sub-system directories.
+
+For more details on GPIO bindings, please refer to the generic GPIO DT
+binding document <devicetree/bindings/gpio/gpio.txt>.
+
+Example:
+--------
+
+	pmic@48 {
+		compatible = "maxim,max77650";
+		reg = <0x48>;
+
+		interrupt-controller;
+		interrupt-parent = <&gpio2>;
+		#interrupt-cells = <2>;
+		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names = "max77650-charger";
+	};
Signature · 1 line
2.20.1
#3 lore raw

PATCH RESEND v6 2/11 dt-bindings: power: supply: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +27 -0
new file mode 100644
index 000000000000..d25c95369616
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:	Minimum CHGIN regulation voltage (in microvolts). Must be
+			one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+			4500000, 4600000, 4700000.
+- curr-lim-microamp:	CHGIN input current limit (in microamps). Must be one of:
+			95000, 190000, 285000, 380000, 475000.
+
+Example:
+--------
+
+	charger {
+		compatible = "maxim,max77650-charger";
+		min-microvolt = <4200000>;
+		curr-lim-microamp = <285000>;
+	};
Signature · 1 line
2.20.1
#5 lore raw

PATCH RESEND v6 3/11 dt-bindings: leds: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the LEDs module of max77650.

---
 .../bindings/leds/leds-max77650.txt           | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.txt
Documentation/devicetree/bindings/leds/leds-max77650.txt new file +57 -0
new file mode 100644
index 000000000000..3a67115cc1da
@@ -0,0 +1,57 @@
+LED driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The LED controller is represented as a sub-node of the PMIC node on
+the device tree.
+
+This device has three current sinks.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-led"
+- #address-cells:	Must be <1>.
+- #size-cells:		Must be <0>.
+
+Each LED is represented as a sub-node of the LED-controller node. Up to
+three sub-nodes can be defined.
+
+Required properties of the sub-node:
+------------------------------------
+
+- reg:			Must be <0>, <1> or <2>.
+
+Optional properties of the sub-node:
+------------------------------------
+
+- label:		See Documentation/devicetree/bindings/leds/common.txt
+- linux,default-trigger: See Documentation/devicetree/bindings/leds/common.txt
+
+For more details, please refer to the generic GPIO DT binding document
+<devicetree/bindings/gpio/gpio.txt>.
+
+Example:
+--------
+
+	leds {
+		compatible = "maxim,max77650-led";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			label = "blue:usr0";
+		};
+
+		led@1 {
+			reg = <1>;
+			label = "red:usr1";
+			linux,default-trigger = "heartbeat";
+		};
+
+		led@2 {
+			reg = <2>;
+			label = "green:usr2";
+		};
+	};
Signature · 1 line
2.20.1
#6 lore raw

PATCH RESEND v6 4/11 dt-bindings: input: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the onkey module of max77650.

---
 .../bindings/input/max77650-onkey.txt         | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.txt
Documentation/devicetree/bindings/input/max77650-onkey.txt new file +26 -0
new file mode 100644
index 000000000000..477dc74f452a
@@ -0,0 +1,26 @@
+Onkey driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The onkey controller is represented as a sub-node of the PMIC node on
+the device tree.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-onkey".
+
+Optional properties:
+- linux,code:		The key-code to be reported when the key is pressed.
+			Defaults to KEY_POWER.
+- maxim,onkey-slide:	The system's button is a slide switch, not the default
+			push button.
+
+Example:
+--------
+
+	onkey {
+		compatible = "maxim,max77650-onkey";
+		linux,code = <KEY_END>;
+		maxim,onkey-slide;
+	};
Signature · 1 line
2.20.1
#10 lore raw

PATCH RESEND v6 5/11 mfd: core: document mfd_add_devices()

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

---
 drivers/mfd/mfd-core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/mfd/mfd-core.c +14 -0
index 94e3f32ce935..0898a8db1747 100644
@@ -269,6 +269,20 @@ static int mfd_add_device(struct device *parent, int id,
 	return ret;
 }
 
+/**
+ * mfd_add_devices - register a set of child devices
+ *
+ * @parent: Parent device for all sub-nodes.
+ * @id: Platform device id. If >= 0, each sub-device will have its cell_id
+ *      added to this number and use it as the platform device id.
+ * @cells: Array of mfd cells describing sub-devices.
+ * @n_devs: Number of sub-devices to register.
+ * @mem_base: Parent register range resource for sub-devices.
+ * @irq_base: Base of the range of virtual interrupt numbers allocated for
+ *            this MFD device. Unused if @domain is specified.
+ * @domain: Interrupt domain used to create mappings for HW interrupt numbers
+ *          specificed in sub-devices' IRQ resources.
+ */
 int mfd_add_devices(struct device *parent, int id,
 		    const struct mfd_cell *cells, int n_devs,
 		    struct resource *mem_base,
Signature · 1 line
2.20.1
#14 lore raw

PATCH RESEND v6 6/11 mfd: max77650: new core mfd driver

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +14 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644
@@ -733,6 +733,20 @@ config MFD_MAX77620
 	  provides common support for accessing the device; additional drivers
 	  must be enabled in order to use the functionality of the device.
 
+config MFD_MAX77650
+	tristate "Maxim MAX77650/77651 PMIC Support"
+	depends on I2C
+	depends on OF || COMPILE_TEST
+	select MFD_CORE
+	select REGMAP_I2C
+	help
+	  Say Y here to add support for Maxim Semiconductor MAX77650 and
+	  MAX77651 Power Management ICs. This is the core multifunction
+	  driver for interacting with the device. The module name is
+	  'max77650'. Additional drivers can be enabled in order to use
+	  the following functionalities of the device: GPIO, regulator,
+	  charger, LED, onkey.
+
 config MFD_MAX77686
 	tristate "Maxim Semiconductor MAX77686/802 PMIC Support"
 	depends on I2C
drivers/mfd/Makefile +1 -0
index b4569ed7f3f3..5727d099c16f 100644
@@ -155,6 +155,7 @@ obj-$(CONFIG_MFD_DA9150)	+= da9150-core.o
 
 obj-$(CONFIG_MFD_MAX14577)	+= max14577.o
 obj-$(CONFIG_MFD_MAX77620)	+= max77620.o
+obj-$(CONFIG_MFD_MAX77650)	+= max77650.o
 obj-$(CONFIG_MFD_MAX77686)	+= max77686.o
 obj-$(CONFIG_MFD_MAX77693)	+= max77693.o
 obj-$(CONFIG_MFD_MAX77843)	+= max77843.o
drivers/mfd/max77650.c new file +234 -0

234 lines not on this page · raw message

include/linux/mfd/max77650.h new file +59 -0

59 lines not on this page · raw message

Signature · 1 line
2.20.1
#17 lore raw

PATCH RESEND v6 7/11 power: supply: max77650: add support for battery charger

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add basic support for the battery charger for max77650 PMIC.

---
 drivers/power/supply/Kconfig            |   7 +
 drivers/power/supply/Makefile           |   1 +
 drivers/power/supply/max77650-charger.c | 366 ++++++++++++++++++++++++
 3 files changed, 374 insertions(+)
 create mode 100644 drivers/power/supply/max77650-charger.c
drivers/power/supply/Kconfig +7 -0
index e901b9879e7e..0230c96fa94d 100644
@@ -499,6 +499,13 @@ config CHARGER_DETECTOR_MAX14656
 	  Revision 1.2 and can be found e.g. in Kindle 4/5th generation
 	  readers and certain LG devices.
 
+config CHARGER_MAX77650
+	tristate "Maxim MAX77650 battery charger driver"
+	depends on MFD_MAX77650
+	help
+	  Say Y to enable support for the battery charger control of MAX77650
+	  PMICs.
+
 config CHARGER_MAX77693
 	tristate "Maxim MAX77693 battery charger driver"
 	depends on MFD_MAX77693
drivers/power/supply/Makefile +1 -0
index b731c2a9b695..b73eb8c5c1a9 100644
@@ -70,6 +70,7 @@ obj-$(CONFIG_CHARGER_MANAGER)	+= charger-manager.o
 obj-$(CONFIG_CHARGER_LTC3651)	+= ltc3651-charger.o
 obj-$(CONFIG_CHARGER_MAX14577)	+= max14577_charger.o
 obj-$(CONFIG_CHARGER_DETECTOR_MAX14656)	+= max14656_charger_detector.o
+obj-$(CONFIG_CHARGER_MAX77650)	+= max77650-charger.o
 obj-$(CONFIG_CHARGER_MAX77693)	+= max77693_charger.o
 obj-$(CONFIG_CHARGER_MAX8997)	+= max8997_charger.o
 obj-$(CONFIG_CHARGER_MAX8998)	+= max8998_charger.o
drivers/power/supply/max77650-charger.c new file +366 -0

366 lines not on this page · raw message

Signature · 1 line
2.20.1
#19 lore raw

PATCH RESEND v6 8/11 gpio: max77650: add GPIO support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add GPIO support for max77650 mfd device. This PMIC exposes a single GPIO line.

---
 drivers/gpio/Kconfig         |   7 ++
 drivers/gpio/Makefile        |   1 +
 drivers/gpio/gpio-max77650.c | 190 +++++++++++++++++++++++++++++++++++
 3 files changed, 198 insertions(+)
 create mode 100644 drivers/gpio/gpio-max77650.c
drivers/gpio/Kconfig +7 -0
index 3f50526a771f..c4f912104440 100644
@@ -1112,6 +1112,13 @@ config GPIO_MAX77620
 	  driver also provides interrupt support for each of the gpios.
 	  Say yes here to enable the max77620 to be used as gpio controller.
 
+config GPIO_MAX77650
+	tristate "Maxim MAX77650/77651 GPIO support"
+	depends on MFD_MAX77650
+	help
+	  GPIO driver for MAX77650/77651 PMIC from Maxim Semiconductor.
+	  These chips have a single pin that can be configured as GPIO.
+
 config GPIO_MSIC
 	bool "Intel MSIC mixed signal gpio support"
 	depends on (X86 || COMPILE_TEST) && MFD_INTEL_MSIC
drivers/gpio/Makefile +1 -0
index 54d55274b93a..075722d8317d 100644
@@ -80,6 +80,7 @@ obj-$(CONFIG_GPIO_MAX7300)	+= gpio-max7300.o
 obj-$(CONFIG_GPIO_MAX7301)	+= gpio-max7301.o
 obj-$(CONFIG_GPIO_MAX732X)	+= gpio-max732x.o
 obj-$(CONFIG_GPIO_MAX77620)	+= gpio-max77620.o
+obj-$(CONFIG_GPIO_MAX77650)	+= gpio-max77650.o
 obj-$(CONFIG_GPIO_MB86S7X)	+= gpio-mb86s7x.o
 obj-$(CONFIG_GPIO_MENZ127)	+= gpio-menz127.o
 obj-$(CONFIG_GPIO_MERRIFIELD)	+= gpio-merrifield.o
drivers/gpio/gpio-max77650.c new file +190 -0

190 lines not on this page · raw message

Signature · 1 line
2.20.1
#20 lore raw

PATCH RESEND v6 9/11 leds: max77650: add LEDs support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

---
 drivers/leds/Kconfig         |   6 ++
 drivers/leds/Makefile        |   1 +
 drivers/leds/leds-max77650.c | 147 +++++++++++++++++++++++++++++++++++
 3 files changed, 154 insertions(+)
 create mode 100644 drivers/leds/leds-max77650.c
drivers/leds/Kconfig +6 -0
index a72f97fca57b..d8c70cc6a714 100644
@@ -608,6 +608,12 @@ config LEDS_TLC591XX
 	  This option enables support for Texas Instruments TLC59108
 	  and TLC59116 LED controllers.
 
+config LEDS_MAX77650
+	tristate "LED support for Maxim MAX77650 PMIC"
+	depends on LEDS_CLASS && MFD_MAX77650
+	help
+	  LEDs driver for MAX77650 family of PMICs from Maxim Integrated.
+
 config LEDS_MAX77693
 	tristate "LED support for MAX77693 Flash"
 	depends on LEDS_CLASS_FLASH
drivers/leds/Makefile +1 -0
index 4c1b0054f379..f48b2404dbb7 100644
@@ -61,6 +61,7 @@ obj-$(CONFIG_LEDS_MC13783)		+= leds-mc13783.o
 obj-$(CONFIG_LEDS_NS2)			+= leds-ns2.o
 obj-$(CONFIG_LEDS_NETXBIG)		+= leds-netxbig.o
 obj-$(CONFIG_LEDS_ASIC3)		+= leds-asic3.o
+obj-$(CONFIG_LEDS_MAX77650)		+= leds-max77650.o
 obj-$(CONFIG_LEDS_MAX77693)		+= leds-max77693.o
 obj-$(CONFIG_LEDS_MAX8997)		+= leds-max8997.o
 obj-$(CONFIG_LEDS_LM355x)		+= leds-lm355x.o
drivers/leds/leds-max77650.c new file +147 -0

147 lines not on this page · raw message

Signature · 1 line
2.20.1
#24 lore raw

PATCH RESEND v6 10/11 input: max77650: add onkey support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add support for the push- and slide-button events for max77650.

---
 drivers/input/misc/Kconfig          |   9 +++
 drivers/input/misc/Makefile         |   1 +
 drivers/input/misc/max77650-onkey.c | 121 ++++++++++++++++++++++++++++
 3 files changed, 131 insertions(+)
 create mode 100644 drivers/input/misc/max77650-onkey.c
drivers/input/misc/Kconfig +9 -0
index e15ed1bb8558..85bc675eecd3 100644
@@ -190,6 +190,15 @@ config INPUT_M68K_BEEP
 	tristate "M68k Beeper support"
 	depends on M68K
 
+config INPUT_MAX77650_ONKEY
+	tristate "Maxim MAX77650 ONKEY support"
+	depends on MFD_MAX77650
+	help
+	  Support the ONKEY of the MAX77650 PMIC as an input device.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called max77650-onkey.
+
 config INPUT_MAX77693_HAPTIC
 	tristate "MAXIM MAX77693/MAX77843 haptic controller support"
 	depends on (MFD_MAX77693 || MFD_MAX77843) && PWM
drivers/input/misc/Makefile +1 -0
index b936c5b1d4ac..ffd72161c79b 100644
@@ -43,6 +43,7 @@ obj-$(CONFIG_INPUT_IXP4XX_BEEPER)	+= ixp4xx-beeper.o
 obj-$(CONFIG_INPUT_KEYSPAN_REMOTE)	+= keyspan_remote.o
 obj-$(CONFIG_INPUT_KXTJ9)		+= kxtj9.o
 obj-$(CONFIG_INPUT_M68K_BEEP)		+= m68kspkr.o
+obj-$(CONFIG_INPUT_MAX77650_ONKEY)	+= max77650-onkey.o
 obj-$(CONFIG_INPUT_MAX77693_HAPTIC)	+= max77693-haptic.o
 obj-$(CONFIG_INPUT_MAX8925_ONKEY)	+= max8925_onkey.o
 obj-$(CONFIG_INPUT_MAX8997_HAPTIC)	+= max8997_haptic.o
drivers/input/misc/max77650-onkey.c new file +121 -0

121 lines not on this page · raw message

Signature · 1 line
2.20.1
#26 lore raw

PATCH RESEND v6 11/11 MAINTAINERS: add an entry for max77650 mfd driver

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

I plan on extending this set of drivers so add myself as maintainer.

---
 MAINTAINERS | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
MAINTAINERS +14 -0
index e17ebf70b548..6f19949111d5 100644
@@ -9397,6 +9397,20 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/sound/max9860.txt
 F:	sound/soc/codecs/max9860.*
 
+MAXIM MAX77650 PMIC MFD DRIVER
+M:	Bartosz Golaszewski <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/*/*max77650.txt
+F:	Documentation/devicetree/bindings/*/max77650*.txt
+F:	include/linux/mfd/max77650.h
+F:	drivers/mfd/max77650.c
+F:	drivers/regulator/max77650-regulator.c
+F:	drivers/power/supply/max77650-charger.c
+F:	drivers/input/misc/max77650-onkey.c
+F:	drivers/leds/leds-max77650.c
+F:	drivers/gpio/gpio-max77650.c
+
 MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER
 M:	Javier Martinez Canillas <[email protected]>
 L:	[email protected]
Signature · 1 line
2.20.1
#7 lore raw

Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650

In reply to Bartosz Golaszewski

Documentation/devicetree/bindings/input/max77650-onkey.txt line 26

Quoted 12 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the onkey module of max77650.

Documentation/devicetree/bindings/input/max77650-onkey.txt new file +5 -0
+	onkey {
+		compatible = "maxim,max77650-onkey";
+		linux,code = <KEY_END>;
+		maxim,onkey-slide;
+	};

This is certainly wrong.

"End" key is normal key on a keyboard, certainly not some kind of slider.

And this controller is likely to be used for power key, not end key, right?

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Acked-by on v6 5/11
#11 lore raw

Re: [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices()

In reply to Bartosz Golaszewski
Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#15 lore raw

Re: [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver

In reply to Bartosz Golaszewski
Quoted 20 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +0 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644

drivers/mfd/Kconfig config MFD_MAX77620 · line 739

Quoted 7 lines
drivers/mfd/Kconfig +4 -0
@@ -733,6 +733,20 @@ config MFD_MAX77620
 	  provides common support for accessing the device; additional drivers
 	  must be enabled in order to use the functionality of the device.
 
+config MFD_MAX77650
+	tristate "Maxim MAX77650/77651 PMIC Support"
+	depends on I2C
+	depends on OF || COMPILE_TEST

This says it will compile ok in !OF case. Will it?

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Acked-by on v6 10/11
#25 lore raw

Re: [RESEND PATCH v6 10/11] input: max77650: add onkey support

In reply to Bartosz Golaszewski
Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add support for the push- and slide-button events for max77650.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Acked-by on v6 9/11
#21 lore raw

Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

In reply to Bartosz Golaszewski
Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

drivers/leds/leds-max77650.c line 114

Quoted 9 lines
drivers/leds/leds-max77650.c new file +9 -0
+		label = of_get_property(child, "label", NULL);
+		if (!label) {
+			led->cdev.name = "max77650::";
+		} else {
+			led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
+							"max77650:%s", label);
+			if (!led->cdev.name)
+				return -ENOMEM;
+		}

I'd rather not have the "max77650:" prefix in the LED name (as it is useless).

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#22 lore raw

Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

pt., 22 mar 2019 o 10:21 Pavel Machek <[email protected]> napisał(a):

Quoted 22 lines · Bartosz Golaszewski
Quoted 7 lines

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

drivers/leds/leds-max77650.c line 114

Quoted 9 lines
drivers/leds/leds-max77650.c new file +9 -0
+             label = of_get_property(child, "label", NULL);
+             if (!label) {
+                     led->cdev.name = "max77650::";
+             } else {
+                     led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
+                                                     "max77650:%s", label);
+                     if (!led->cdev.name)
+                             return -ENOMEM;
+             }
Quoted 3 lines

I'd rather not have the "max77650:" prefix in the LED name (as it is useless).

I was instructed to do so by the LED subsystem maintainer.

Bart

Quoted 5 lines

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

#8 lore raw

Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650

In reply to Pavel Machek

pt., 22 mar 2019 o 10:09 Pavel Machek <[email protected]> napisał(a):

Quoted 15 lines · Bartosz Golaszewski

Documentation/devicetree/bindings/input/max77650-onkey.txt line 26

Quoted 12 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the onkey module of max77650.

Documentation/devicetree/bindings/input/max77650-onkey.txt new file +5 -0
+     onkey {
+             compatible = "maxim,max77650-onkey";
+             linux,code = <KEY_END>;
+             maxim,onkey-slide;
+     };
Quoted 7 lines

This is certainly wrong.

"End" key is normal key on a keyboard, certainly not some kind of slider.

And this controller is likely to be used for power key, not end key, right?

But this is just an example of available properties, not a real use-case.

Bart

Quoted 5 lines

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

#9 lore raw

Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650

Quoted 18 lines · Bartosz Golaszewski

pt., 22 mar 2019 o 10:09 Pavel Machek <[email protected]> napisał(a):

Quoted 17 lines · Bartosz Golaszewski

Documentation/devicetree/bindings/input/max77650-onkey.txt line 26

Quoted 12 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the onkey module of max77650.

Documentation/devicetree/bindings/input/max77650-onkey.txt new file +5 -0
+     onkey {
+             compatible = "maxim,max77650-onkey";
+             linux,code = <KEY_END>;
+             maxim,onkey-slide;
+     };

This is certainly wrong.

Quoted 7 lines
Quoted 5 lines

"End" key is normal key on a keyboard, certainly not some kind of slider.

And this controller is likely to be used for power key, not end key, right?

But this is just an example of available properties, not a real use-case.

We can have example that makes sense, right?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#23 lore raw

Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

In reply to Bartosz Golaszewski
Quoted 23 lines · Bartosz Golaszewski

pt., 22 mar 2019 o 10:21 Pavel Machek <[email protected]> napisał(a):

Quoted 22 lines · Bartosz Golaszewski
Quoted 7 lines

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

Quoted 9 lines
drivers/leds/leds-max77650.c new file +9 -0
+             label = of_get_property(child, "label", NULL);
+             if (!label) {
+                     led->cdev.name = "max77650::";
+             } else {
+                     led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
+                                                     "max77650:%s", label);
+                     if (!led->cdev.name)
+                             return -ENOMEM;
+             }
Quoted 5 lines
Quoted 3 lines

I'd rather not have the "max77650:" prefix in the LED name (as it is useless).

I was instructed to do so by the LED subsystem maintainer.

Yes, let's keep things consistent, we will convert it to use generic support for LED naming once that support is merged.

Signature · 2 lines
Best regards,
Jacek Anaszewski
maintainer
#4 lore raw

Re: [RESEND PATCH v6 02/11] dt-bindings: power: supply: add DT bindings for max77650

In reply to Bartosz Golaszewski
Quoted 24 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +8 -0
new file mode 100644
index 000000000000..d25c95369616
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +10 -0
+--------------------
+- compatible:		Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:	Minimum CHGIN regulation voltage (in microvolts). Must be
+			one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+			4500000, 4600000, 4700000.
+- curr-lim-microamp:	CHGIN input current limit (in microamps). Must be one of:
+			95000, 190000, 285000, 380000, 475000.

These should be common charger properties IMO.

Rob

#16 lore raw

Re: [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver

In reply to Pavel Machek

pt., 22 mar 2019 o 10:12 Pavel Machek <[email protected]> napisał(a):

Quoted 25 lines · Bartosz Golaszewski
Quoted 23 lines

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +0 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644
@@ -733,6 +733,20 @@ config MFD_MAX77620
        provides common support for accessing the device; additional drivers
        must be enabled in order to use the functionality of the device.
 
Quoted 7 lines

drivers/mfd/Kconfig config MFD_MAX77620 · line 739

Quoted 4 lines
drivers/mfd/Kconfig +4 -0
+config MFD_MAX77650
+     tristate "Maxim MAX77650/77651 PMIC Support"
+     depends on I2C
+     depends on OF || COMPILE_TEST

This says it will compile ok in !OF case. Will it?

It will compile because the stubs for OF functions will be provided - it just won't work, because they won't be implemented.

Bart

Quoted 3 lines

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

#2 lore raw

Re: [RESEND PATCH v6 01/11] dt-bindings: mfd: add DT bindings for max77650

In reply to Bartosz Golaszewski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a DT binding document for max77650 ultra-low power PMIC. This describes the core mfd device and the GPIO module.

---
 .../devicetree/bindings/mfd/max77650.txt      | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/max77650.txt

For my own reference:

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#12 lore raw

Re: [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices()

In reply to Bartosz Golaszewski
Quoted 14 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

---
 drivers/mfd/mfd-core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/mfd/mfd-core.c +0 -0
index 94e3f32ce935..0898a8db1747 100644

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 273

Quoted 5 lines
drivers/mfd/mfd-core.c +2 -0
@@ -269,6 +269,20 @@ static int mfd_add_device(struct device *parent, int id,
 	return ret;
 }
 
+/**
+ * mfd_add_devices - register a set of child devices

"register child devices"

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 284

Quoted 11 lines
drivers/mfd/mfd-core.c +11 -0
+ *
+ * @parent: Parent device for all sub-nodes.
+ * @id: Platform device id. If >= 0, each sub-device will have its cell_id
+ *      added to this number and use it as the platform device id.
+ * @cells: Array of mfd cells describing sub-devices.
+ * @n_devs: Number of sub-devices to register.
+ * @mem_base: Parent register range resource for sub-devices.
+ * @irq_base: Base of the range of virtual interrupt numbers allocated for
+ *            this MFD device. Unused if @domain is specified.
+ * @domain: Interrupt domain used to create mappings for HW interrupt numbers
+ *          specificed in sub-devices' IRQ resources.

Spelling.

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 288

Quoted 4 lines
drivers/mfd/mfd-core.c +1 -0
+ */
 int mfd_add_devices(struct device *parent, int id,
 		    const struct mfd_cell *cells, int n_devs,
 		    struct resource *mem_base,

How about this:

/**
* mfd_add_devices - register child devices
*
* @parent: Pointer to parent device.
* @id: Can be PLATFORM_DEVID_AUTO to let the Platform API take care
* of device numbering, or will be added to a device's cell_id.
* @cells: Array of (struct mfd_cell)s describing child devices.
* @n_devs: Number of child devices to register.
* @mem_base: Parent register range resource for child devices.
* @irq_base: Base of the range of virtual interrupt numbers allocated for
* this MFD device. Unused if @domain is specified.
* @domain: Interrupt domain to create mappings for hardware interrupts.
*/

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#13 lore raw

Re: [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices()

wt., 2 kwi 2019 o 09:41 Lee Jones <[email protected]> napisał(a):

Quoted 58 lines · Bartosz Golaszewski
Quoted 15 lines

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

---
 drivers/mfd/mfd-core.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/mfd/mfd-core.c +0 -0
index 94e3f32ce935..0898a8db1747 100644

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 273

Quoted 5 lines
drivers/mfd/mfd-core.c +2 -0
@@ -269,6 +269,20 @@ static int mfd_add_device(struct device *parent, int id,
      return ret;
 }
 
+/**
+ * mfd_add_devices - register a set of child devices

"register child devices"

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 284

Quoted 11 lines
drivers/mfd/mfd-core.c +11 -0
+ *
+ * @parent: Parent device for all sub-nodes.
+ * @id: Platform device id. If >= 0, each sub-device will have its cell_id
+ *      added to this number and use it as the platform device id.
+ * @cells: Array of mfd cells describing sub-devices.
+ * @n_devs: Number of sub-devices to register.
+ * @mem_base: Parent register range resource for sub-devices.
+ * @irq_base: Base of the range of virtual interrupt numbers allocated for
+ *            this MFD device. Unused if @domain is specified.
+ * @domain: Interrupt domain used to create mappings for HW interrupt numbers
+ *          specificed in sub-devices' IRQ resources.

Spelling.

drivers/mfd/mfd-core.c static int mfd_add_device(struct device *parent, int id, · line 288

Quoted 4 lines
drivers/mfd/mfd-core.c +1 -0
+ */
 int mfd_add_devices(struct device *parent, int id,
                  const struct mfd_cell *cells, int n_devs,
                  struct resource *mem_base,

How about this:

/**
* mfd_add_devices - register child devices
*

 * @parent:     Pointer to parent device.
 * @id:         Can be PLATFORM_DEVID_AUTO to let the Platform API take care
 *              of device numbering, or will be added to a device's cell_id.
 * @cells:      Array of (struct mfd_cell)s describing child devices.
 * @n_devs:     Number of child devices to register.
 * @mem_base:   Parent register range resource for child devices.
 * @irq_base:   Base of the range of virtual interrupt numbers allocated for
 *              this MFD device. Unused if @domain is specified.
 * @domain:     Interrupt domain to create mappings for hardware interrupts.
Quoted 2 lines

*/

Sure, looks good to me.

FYI the latest version of this series is v7, but the mfd driver didn't change since v6.

Bart