regmap: debugfs: Replace code by already existing function
Subsystems (2)
PATCH 1/2 regmap: debugfs: Replace code by already existing function
Signed-off-by Lucas Tanure <[email protected]>
--- drivers/base/regmap/regmap-debugfs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/base/regmap/regmap-debugfs.c +1 -4
@@ -214,10 +214,7 @@ static ssize_t regmap_read_debugfs(struct regmap *map, unsigned int from, start_reg =regmap_debugfs_get_dump_start (map, from, *ppos, &p);for (i = start_reg; i <= to; i += map->reg_stride) { -if (!regmap_readable (map, i) && !regmap_cached (map, i)) -continue ; - -if (regmap_precious (map, i)) +if (!regmap_printable (map, i))continue ;/* If we're in the region the user is trying to read */
Signature · 1 line
2.21.0
PATCH 2/2 regmap: debugfs: Jump to the next readable register
Improve the speed of the loop jumping to the next
available register
Signed-off-by Lucas Tanure <[email protected]>
--- drivers/base/regmap/regmap-debugfs.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-)
drivers/base/regmap/regmap-debugfs.c +24 -3
@@ -190,6 +190,28 @@ static inline void regmap_calc_tot_len(struct regmap *map, } } +static int regmap_next_readable_reg (struct regmap *map,int reg) +{ +struct regmap_debugfs_off_cache *c; +int ret = -EINVAL ; + +if (regmap_printable (map, reg + map->reg_stride)) { + ret = reg + map->reg_stride; + }else { +mutex_lock (&map->cache_lock); +list_for_each_entry (c, &map->debugfs_off_cache, list) { +if (reg > c->max_reg) +continue ; +if (reg < c->base_reg) { + ret = c->base_reg; +break ; + } + } +mutex_unlock (&map->cache_lock); + } +return ret; +} +static ssize_t regmap_read_debugfs (struct regmap *map,unsigned int from,unsigned int to,char __user *user_buf,size_t count,loff_t *ppos)
@@ -213,9 +235,8 @@ static ssize_t regmap_read_debugfs(struct regmap *map, unsigned int from,/* Work out which register we're starting at */ start_reg =regmap_debugfs_get_dump_start (map, from, *ppos, &p); -for (i = start_reg; i <= to; i += map->reg_stride) { -if (!regmap_printable (map, i)) -continue ; +for (i = start_reg; i >=0 && i <= to; + i =regmap_next_readable_reg (map, i)) {/* If we're in the region the user is trying to read */ if (p >= *ppos) {
Signature · 1 line
2.21.0
Re: [PATCH 2/2] regmap: debugfs: Jump to the next readable register
Quoted 5 lines · Lucas Tanure
Improve the speed of the loop jumping to the next
available registerSigned-off-by Lucas Tanure <[email protected]>---
Reviewed-by Charles Keepax <[email protected]>
Tested-by Charles Keepax <[email protected]>
A very brief look shows a pretty reasonable speed up on the massive wm5110 register map.
First regmap cat on wm5110:
pre-patch:
real 2m40.865s
sys 2m21.104s
post-patch:
real 2m16.550s
sys 2m5.799s
Repeat cat on wm5110:
pre-patch:
real 2m5.635s
sys 2m0.030s
post-patch:
real 1m45.539s
sys 1m44.552s
Thanks,
Charles