Skip to contentSkip to conversation

Eliminate camel case

PATCH Superseded vatsalanarang 3 participants 3 messages Mar 19, 2019

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Eliminate camel case

From: Vatsala Narang <[email protected]>

Issue reported by checkpatch.pl tool

---

drivers/staging/sm750fb/ddk750_display.c | 8 ++++----
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/ddk750_power.h   | 2 +-
drivers/staging/sm750fb/sm750_hw.c       | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
drivers/staging/sm750fb/ddk750_display.c +4 -4
index f38051eedb6c..44a605584d17 100644
@@ -85,7 +85,7 @@ static void primary_wait_vertical_sync(int delay)
 	}
 }
 
-static void swPanelPowerSequence(int disp, int delay)
+static void sw_panel_power_sequence(int disp, int delay)
 {
 	unsigned int reg;
 
@@ -111,7 +111,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	primary_wait_vertical_sync(delay);
 }
 
-void ddk750_setLogicalDispOut(enum disp_output output)
+void ddk750_set_logical_disp_out(enum disp_output output)
 {
 	unsigned int reg;
 
@@ -147,12 +147,12 @@ void ddk750_setLogicalDispOut(enum disp_output output)
 
 	if (output & PNL_SEQ_USAGE) {
 		/* set  panel sequence */
-		swPanelPowerSequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
+		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
 				     4);
 	}
 
 	if (output & DAC_USAGE)
-		setDAC((output & DAC_MASK) >> DAC_OFFSET);
+		set_DAC((output & DAC_MASK) >> DAC_OFFSET);
 
 	if (output & DPMS_USAGE)
 		ddk750_set_dpms((output & DPMS_MASK) >> DPMS_OFFSET);
drivers/staging/sm750fb/ddk750_display.h +1 -1
index 7fd101d98199..7f713906dc16 100644
@@ -102,6 +102,6 @@ enum disp_output {
 	do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
 };
 
-void ddk750_setLogicalDispOut(enum disp_output output);
+void ddk750_set_logical_disp_out(enum disp_output output);
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index e48c74ecbbd1..7002567a47d2 100644
@@ -9,7 +9,7 @@ enum dpms {
 	crtDPMS_OFF = 0x3,
 };
 
-#define setDAC(off) {							\
+#define set_DAC(off) {							\
 	poke32(MISC_CTRL,						\
 	       (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
drivers/staging/sm750fb/sm750_hw.c +1 -1
index edeae9d06883..ea1d3d4efbc2 100644
@@ -207,7 +207,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output,
 			if (output->paths & sm750_crt)
 				disp_set |= do_CRT_SEC;
 		}
-		ddk750_setLogicalDispOut(disp_set);
+		ddk750_set_logical_disp_out(disp_set);
 	} else {
 		/* just open DISPLAY_CONTROL_750LE register bit 3:0 */
 		u32 reg;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · vatsalanarang

From: Vatsala Narang <[email protected]>

Can you fix your git config file to make this unnecessary?

I think you have submitted this patch before, so it would be a v2. You need to put PATCH v2 in the subject line and describe what changed under the ---

Quoted 33 lines

Issue reported by checkpatch.pl tool

---

drivers/staging/sm750fb/ddk750_display.c | 8 ++++----
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/ddk750_power.h   | 2 +-
drivers/staging/sm750fb/sm750_hw.c       | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
drivers/staging/sm750fb/ddk750_display.c +2 -2
index f38051eedb6c..44a605584d17 100644
@@ -85,7 +85,7 @@ static void primary_wait_vertical_sync(int delay)
 	}
 }
 
-static void swPanelPowerSequence(int disp, int delay)
+static void sw_panel_power_sequence(int disp, int delay)
 {
 	unsigned int reg;
 
@@ -111,7 +111,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	primary_wait_vertical_sync(delay);
 }
 
-void ddk750_setLogicalDispOut(enum disp_output output)
+void ddk750_set_logical_disp_out(enum disp_output output)
 {
 	unsigned int reg;
 

drivers/staging/sm750fb/ddk750_display.c void ddk750_setLogicalDispOut(enum disp_output output) · line 151

Quoted 6 lines
drivers/staging/sm750fb/ddk750_display.c +1 -1
@@ -147,12 +147,12 @@ void ddk750_setLogicalDispOut(enum disp_output output)
 
 	if (output & PNL_SEQ_USAGE) {
 		/* set  panel sequence */
-		swPanelPowerSequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
+		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
 				     4);

The 4 needs to be lined up with the (, which you have moved a bit to the right.

julia

Quoted 56 lines
drivers/staging/sm750fb/ddk750_display.c +1 -1
 	}
 
 	if (output & DAC_USAGE)
-		setDAC((output & DAC_MASK) >> DAC_OFFSET);
+		set_DAC((output & DAC_MASK) >> DAC_OFFSET);
 
 	if (output & DPMS_USAGE)
 		ddk750_set_dpms((output & DPMS_MASK) >> DPMS_OFFSET);
drivers/staging/sm750fb/ddk750_display.h +1 -1
index 7fd101d98199..7f713906dc16 100644
@@ -102,6 +102,6 @@ enum disp_output {
 	do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
 };
 
-void ddk750_setLogicalDispOut(enum disp_output output);
+void ddk750_set_logical_disp_out(enum disp_output output);
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index e48c74ecbbd1..7002567a47d2 100644
@@ -9,7 +9,7 @@ enum dpms {
 	crtDPMS_OFF = 0x3,
 };
 
-#define setDAC(off) {							\
+#define set_DAC(off) {							\
 	poke32(MISC_CTRL,						\
 	       (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
drivers/staging/sm750fb/sm750_hw.c +1 -2
index edeae9d06883..ea1d3d4efbc2 100644
@@ -207,7 +207,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output,
 			if (output->paths & sm750_crt)
 				disp_set |= do_CRT_SEC;
 		}
-		ddk750_setLogicalDispOut(disp_set);
+		ddk750_set_logical_disp_out(disp_set);
 	} else {
 		/* just open DISPLAY_CONTROL_750LE register bit 3:0 */
 		u32 reg;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190319094449.11640-1-vatsalanarang%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#2 lore raw
In reply to vatsalanarang
Quoted 3 lines · vatsalanarang

From: Vatsala Narang <[email protected]>

Issue reported by checkpatch.pl tool

What "issue"?

Be specific please.

Also, you need the kernel subsystem (staging), and driver name (sm750fb) in the subject line for this to work properly. Look at all of the other patches on this list, or just look at the commits that have already been accepted for this driver with a simple:
git log drivers/staging/sm750fb/
to get an idea of how to format everything.

thanks,

greg k-h