u-boot: install dumpimage and fit_check_sign in u-boot-tools
PATCH 1/1 u-boot: install dumpimage and fit_check_sign in u-boot-tools
From: Luca Boccassi <[email protected]>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from a FIT file, verify them and kexec for a faster reboot.
--- meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++ 1 file changed, 8 insertions(+)
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +8 -0
@@ -45,6 +45,14 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1"
Signature · 1 line
2.20.1
Quoted 6 lines · On Tue, Mar 19, 2019 at 06:15:44PM +0000, [email protected] wrote:
From: Luca Boccassi <[email protected]>
Dumpimage and
fit_check_signcan be used to extract kernel and ramdisk from a FIT file, verify them and kexec for a faster reboot.Signed-off-by Luca Boccassi <[email protected]>
Signature · 1 line
Tom
Quoted 28 lines · On Tue, 2019-03-19 at 18:15 +0000, [email protected] wrote:
From: Luca Boccassi <[email protected]>
Dumpimage and
fit_check_signcan be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.Signed-off-by Luca Boccassi <[email protected]>--- meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++ 1 file changed, 8 insertions(+)meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +7
-0@@ -45,6 +45,14 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
fit_check_sign
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb do_install () { · line 58
Quoted 4 lines
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +1
-0+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1"
Fails on musl:
https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/420
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/421
no-x11:
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/419
qemux86-world:
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/412
so basically it looks like any world build fails with this.
Cheers,
Richard
Quoted 42 lines · Richard Purdie
Quoted 28 lines · On Tue, 2019-03-19 at 18:15 +0000, [email protected] wrote:
From: Luca Boccassi <[email protected]>
Dumpimage and
fit_check_signcan be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.Signed-off-by Luca Boccassi <[email protected]>--- meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++ 1 file changed, 8 insertions(+)meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +7
-0@@ -45,6 +45,14 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
fit_check_signmeta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb do_install () { · line 58
Quoted 4 lines
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +1
-0+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1"Fails on musl:
https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/420
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/421
no-x11:
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/419
qemux86-world:
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/412
Quoted 5 lines
so basically it looks like any world build fails with this.
Cheers,
Richard
Hi,
Sorry about that, this recipe has changed a bit since sumo - it seems the files need to be also listed individually in FILES_${PN}:
ERROR: u-boot-tools-1_2019.01-r0 do_package: QA Issue: u-boot-tools:
Files/directories were installed but not shipped in any package:
/usr/bin/uboot-dumpimage
/usr/bin/fit_check_sign
/usr/bin/dumpimage
/usr/bin/uboot-fit_check_sign
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
eg:
-FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
+FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage {bindir}/uboot-dumpimage ${bindir}/dumpimage {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
Is this the right solution? Or should it be a new package?
Signature · 2 lines
Kind regards, Luca Boccassi
PATCH v2 1/1 u-boot: install dumpimage and fit_check_sign in u-boot-tools
In reply to [email protected]From: Luca Boccassi <[email protected]>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from a FIT file, verify them and kexec for a faster reboot.
---
v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package, please advise if the other is better.
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +9 -1
@@ -45,11 +45,19 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1" FILES_${PN} = "" -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage" +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage {bindir}/uboot-dumpimage ${bindir}/dumpimage {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign" FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage" RDEPENDS_${PN}-mkimage += "dtc"
Signature · 1 line
2.20.1
Quoted 38 lines · On Thu, Mar 21, 2019 at 6:36 PM <[email protected]> wrote:
From: Luca Boccassi <[email protected]>
Dumpimage and
fit_check_signcan be used to extract kernel and ramdisk from a FIT file, verify them and kexec for a faster reboot.Signed-off-by Luca Boccassi <[email protected]>Signed-off-by Richard Purdie <[email protected]>---
v2: add dumpimage andfit_check_signto FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package, please advise if the other is better.meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +9
-1@@ -45,11 +45,19 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1" FILES_${PN} = "" -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage" +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage
Quoted 1 line
{bindir}/uboot-dumpimage ${bindir}/dumpimage
There's no $ here
Quoted 1 line
{bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
or here
Quoted 3 lines
FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage"
RDEPENDS_${PN}-mkimage += "dtc"
Signature · 1 line
Alex Kiernan
PATCH v3 1/1 u-boot: install dumpimage and fit_check_sign in u-boot-tools
In reply to [email protected]From: Luca Boccassi <[email protected]>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from a FIT file, verify them and kexec for a faster reboot.
---
v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package, please advise if the other is better.
v3: fix copypasta
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +9 -1
@@ -45,11 +45,19 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage + + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1" FILES_${PN} = "" -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage" +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage ${bindir}/uboot-dumpimage ${bindir}/dumpimage ${bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign" FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage" RDEPENDS_${PN}-mkimage += "dtc"
Signature · 1 line
2.20.1
Quoted 49 lines · Alex Kiernan
Quoted 44 lines · On Thu, Mar 21, 2019 at 6:36 PM <[email protected]> wrote:
From: Luca Boccassi <[email protected]>
Dumpimage and
fit_check_signcan be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.Signed-off-by Luca Boccassi <[email protected]>Signed-off-by Richard Purdie <[email protected]>---
v2: add dumpimage andfit_check_signto FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package,
please
advise if the other is better.meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +0
-0@@ -45,11 +45,19 @@ do_install () { # mkenvimage install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimagemeta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +3
-0+ + # dumpimage + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +4
-0+ ln -sf uboot-dumpimage ${D}${bindir}/dumpimage + + # fit_check_sign + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
fit_check_signmeta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb +2
-1+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign } ALLOW_EMPTY_${PN} = "1" FILES_${PN} = "" -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage" +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimageQuoted 1 line
{bindir}/uboot-dumpimage ${bindir}/dumpimage
There's no $ here
Quoted 8 lines
Quoted 1 line
{bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
or here
Quoted 4 lines
FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage
${bindir}/mkenvimage"RDEPENDS_${PN}-mkimage += "dtc"
D'oh, copypasta! Thanks, fixed in v3
Signature · 2 lines
Kind regards, Luca Boccassi