Skip to contentSkip to conversation

ext4: remove incorrect comment for NEXT_ORPHAN()

PATCH Applied Eric Biggers 3 participants 3 messages Mar 19, 2019 – Apr 7, 2019 ext4 file system

lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 ext4: remove incorrect comment for NEXT_ORPHAN()

From: Eric Biggers <[email protected]>

The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(), which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's crypto engine") but the comment was accidentally left in place. Since ext4_encrypted_inode() has now been removed, just remove the comment.

Signed-off-by Eric Biggers <[email protected]>
---
 fs/ext4/ext4.h | 3 ---
 1 file changed, 3 deletions(-)
fs/ext4/ext4.h +0 -3
index 82ffdacdc7fac..2a2e6ed9aab4f 100644
@@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
 #define EXT4_SB(sb)	(sb)
 #endif
 
-/*
- * Returns true if the inode is inode is encrypted
- */
 #define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
 
 /*
Signature · 1 line
2.21.0.225.g810b269d1ac-goog
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Eric Biggers

From: Eric Biggers <[email protected]>

The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(), which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's crypto engine") but the comment was accidentally left in place. Since ext4_encrypted_inode() has now been removed, just remove the comment.

Signed-off-by Eric Biggers <[email protected]>

Looks good. You can add:

Reviewed-by Jan Kara <[email protected]>

Honza

Quoted 21 lines
---
 fs/ext4/ext4.h | 3 ---
 1 file changed, 3 deletions(-)
fs/ext4/ext4.h +0 -3
index 82ffdacdc7fac..2a2e6ed9aab4f 100644
@@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
 #define EXT4_SB(sb)	(sb)
 #endif
 
-/*
- * Returns true if the inode is inode is encrypted
- */
 #define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
 
 /*
Signature · 1 line
2.21.0.225.g810b269d1ac-goog
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
maintainer Applied
#2 lore raw
In reply to Eric Biggers
Quoted 8 lines · Eric Biggers

From: Eric Biggers <[email protected]>

The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(), which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's crypto engine") but the comment was accidentally left in place. Since ext4_encrypted_inode() has now been removed, just remove the comment.

Signed-off-by Eric Biggers <[email protected]>

Thanks, applied.

- Ted