Skip to contentSkip to conversation

arm64: dts: imx8mq: Move the opp table out of bus node

PATCH Applied Fabio Estevam 3 participants 3 messages Mar 20, 2019 – Mar 25, 2019

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: imx8mq: Move the opp table out of bus node

Move opp-table node from soc node to root node.

opp-table node does not have any register properties and thus shouldn't be placed inside the bus.

This fixes the following build warnings with W=1:

arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property

Fixes 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 37 +++++++++++------------
 1 file changed, 18 insertions(+), 19 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq.dtsi +18 -19
index 32a02027df92..e02ef059bba0 100644
@@ -132,6 +132,24 @@
 		};
 	};
 
+	a53_opp_table: opp-table {
+		compatible = "operating-points-v2";
+		opp-shared;
+
+		opp-800000000 {
+			opp-hz = /bits/ 64 <800000000>;
+			opp-microvolt = <900000>;
+			clock-latency-ns = <150000>;
+		};
+
+		opp-1000000000 {
+			opp-hz = /bits/ 64 <1000000000>;
+			opp-microvolt = <1000000>;
+			clock-latency-ns = <150000>;
+			opp-suspend;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a53-pmu";
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -683,25 +701,6 @@
 			status = "disabled";
 		};
 
-
-		a53_opp_table: opp-table {
-			compatible = "operating-points-v2";
-			opp-shared;
-
-			opp-800000000 {
-				opp-hz = /bits/ 64 <800000000>;
-				opp-microvolt = <900000>;
-				clock-latency-ns = <150000>;
-			};
-
-			opp-1000000000 {
-				opp-hz = /bits/ 64 <1000000000>;
-				opp-microvolt = <1000000>;
-				clock-latency-ns = <150000>;
-				opp-suspend;
-			};
-		};
-
 		gic: interrupt-controller@38800000 {
 			compatible = "arm,gic-v3";
 			reg = <0x38800000 0x10000>,	/* GIC Dist */
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#1 lore raw
Quoted 11 lines · Fabio Estevam

Move opp-table node from soc node to root node.

opp-table node does not have any register properties and thus shouldn't be placed inside the bus.

This fixes the following build warnings with W=1:

arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property

Fixes 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Tested-by on v1 1/1
#2 lore raw
In reply to Fabio Estevam

Hi,

Quoted 60 lines · Fabio Estevam

Move opp-table node from soc node to root node.

opp-table node does not have any register properties and thus shouldn't be placed inside the bus.

This fixes the following build warnings with W=1:

arch/arm64/boot/dts/freescale/imx8mq.dtsi:687.28-703.5: Warning (simple_bus_reg): /soc@0/opp-table: missing or empty reg/ranges property

Fixes 64d26f8c1dde ("arm64: dts: imx8mq: Add the opp table and cores opp properties")
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 37 +++++++++++------------
 1 file changed, 18 insertions(+), 19 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq.dtsi +18 -12
index 32a02027df92..e02ef059bba0 100644
@@ -132,6 +132,24 @@
 		};
 	};
 
+	a53_opp_table: opp-table {
+		compatible = "operating-points-v2";
+		opp-shared;
+
+		opp-800000000 {
+			opp-hz = /bits/ 64 <800000000>;
+			opp-microvolt = <900000>;
+			clock-latency-ns = <150000>;
+		};
+
+		opp-1000000000 {
+			opp-hz = /bits/ 64 <1000000000>;
+			opp-microvolt = <1000000>;
+			clock-latency-ns = <150000>;
+			opp-suspend;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a53-pmu";
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -683,25 +701,6 @@
 			status = "disabled";
 		};
 
-
-		a53_opp_table: opp-table {
-			compatible = "operating-points-v2";
-			opp-shared;
-
-			opp-800000000 {
-				opp-hz = /bits/ 64 <800000000>;
-				opp-microvolt = <900000>;
-				clock-latency-ns = <150000>;
-			};
-
-			opp-1000000000 {

arch/arm64/boot/dts/freescale/imx8mq.dtsi line 706

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mq.dtsi +0 -7
-				opp-hz = /bits/ 64 <1000000000>;
-				opp-microvolt = <1000000>;
-				clock-latency-ns = <150000>;
-				opp-suspend;
-			};
-		};
-
 		gic: interrupt-controller@38800000 {
 			compatible = "arm,gic-v3";
 			reg = <0x38800000 0x10000>,	/* GIC Dist */

Just noticed the very same, in case that still matters:

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel