Skip to contentSkip to conversation

habanalabs fixes for 5.1 rc2/3

GIT PULL Oded Gabbay 2 participants 3 messages Mar 21, 2019 – Mar 26, 2019

lore
Share & tools
lore
#0 lore raw

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Thanks,
Oded

The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:

Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)

are available in the Git repository at:

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-03-21

for you to fetch changes up to 2198b040b98cfbed62716692a34eb971e0383f93:

habanalabs: cast to expected type (2019-03-03 10:23:29 +0200)

----------------------------------------------------------------
Oded Gabbay (3):
habanalabs: perform accounting for active CS
habanalabs: prevent host crash during suspend/resume
habanalabs: cast to expected type

Omer Shpigelman (4):
habanalabs: fix MMU number of pages calculation
habanalabs: fix bug when mapping very large memory area
habanalabs: complete user context cleanup before hard reset
habanalabs: fix mapping with page size bigger than 4KB

 drivers/misc/habanalabs/command_submission.c |  6 +++
 drivers/misc/habanalabs/debugfs.c            |  7 +--
 drivers/misc/habanalabs/device.c             | 71 ++++++++++++++++++++++++++--
 drivers/misc/habanalabs/goya/goya.c          | 65 +------------------------
 drivers/misc/habanalabs/habanalabs.h         | 21 ++++----
 drivers/misc/habanalabs/hw_queue.c           |  5 +-
 drivers/misc/habanalabs/memory.c             | 38 ++++++++-------
 drivers/misc/habanalabs/mmu.c                |  6 ++-
 8 files changed, 117 insertions(+), 102 deletions(-)
#1 lore raw
Quoted 19 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Thanks,
Oded

The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:

Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)

are available in the Git repository at:

Quoted 7 lines

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-03-21

for you to fetch changes up to 2198b040b98cfbed62716692a34eb971e0383f93:

habanalabs: cast to expected type (2019-03-03 10:23:29 +0200)

----------------------------------------------------------------

There is no text at all in your tag :(

You need to put something there, like "here are the fixes that do..." or some sort of explaination for why this set of patches need to be pulled in. That way it shows up in the merge commit properly.

Can you fix this up and resend?

thanks,

greg k-h

#2 lore raw
Quoted 35 lines · Greg KH
Quoted 19 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Thanks,
Oded

The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:

Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)

are available in the Git repository at:

Quoted 7 lines

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-03-21

for you to fetch changes up to 2198b040b98cfbed62716692a34eb971e0383f93:

habanalabs: cast to expected type (2019-03-03 10:23:29 +0200)

----------------------------------------------------------------

There is no text at all in your tag :(

You need to put something there, like "here are the fixes that do..." or some sort of explaination for why this set of patches need to be pulled in. That way it shows up in the merge commit properly.

Quoted 5 lines

Can you fix this up and resend?

thanks,

greg k-h

Ok, didn't know that. I'll get to it right away.

Oded