usb: dwc3: Softdep for GBit Ethernet on Odroid XU4

PATCH In review Jochen Sprickerhof 3 participants 4 messages Mar 21, 2019 – Mar 23, 2019

Subsystems (2)

USB DesignWare USB3 DRD IP driver

lore

Share & tools

lore

Jochen Sprickerhof

author

2019-03-21 20:23 UTC #0 lore raw

PATCH 1/1 usb: dwc3: Softdep for GBit Ethernet on Odroid XU4

This adds a soft dependency to the dwc3 module to load it after xhci-plat as proposed in:

https://marc.info/?l=linux-usb&m=155230272022603&w=2

Old behaviour:

$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
/:  Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
   |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M

New behaviour:

$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
   |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M

Tested on Debian unstable using Linux 4.19.29.

Note, this needs a hard reset when coming from an unpatched kernel.

Signed-off-by Jochen Sprickerhof <[email protected]>

---
 drivers/usb/dwc3/core.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/dwc3/core.c +1 -0

index 103807587dc6..9017e4ed9d99 100644
@@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
 MODULE_AUTHOR("Felipe Balbi <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
+MODULE_SOFTDEP("pre: xhci_plat_hcd");

Greg Kroah-Hartman

maintainer

2019-03-22 05:37 UTC #1 lore raw

Quoted 32 lines · Jochen Sprickerhof

This adds a soft dependency to the dwc3 module to load it after xhci-plat as proposed in:
https://marc.info/?l=linux-usb&m=155230272022603&w=2
Old behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
/:  Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
New behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
Tested on Debian unstable using Linux 4.19.29.
Note, this needs a hard reset when coming from an unpatched kernel.
Signed-off-by Jochen Sprickerhof <[email protected]>
---
drivers/usb/dwc3/core.c | 1 +
1 file changed, 1 insertion(+)
drivers/usb/dwc3/core.c +0 -0
index 103807587dc6..9017e4ed9d99 100644

drivers/usb/dwc3/core.c MODULE_ALIAS("platform:dwc3"); · line 1749

Quoted 4 lines

drivers/usb/dwc3/core.c +1 -0

@@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
 MODULE_AUTHOR("Felipe Balbi <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
+MODULE_SOFTDEP("pre: xhci_plat_hcd");

Your patch is corrupted and can not be applied :(

Jochen Sprickerhof

2019-03-22 20:41 UTC #2 lore raw

Hi Greg,

Quoted 28 lines · Greg Kroah-Hartman

Quoted 27 lines · Jochen Sprickerhof
This adds a soft dependency to the dwc3 module to load it after xhci-plat as proposed in:
https://marc.info/?l=linux-usb&m=155230272022603&w=2
Old behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
/:  Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
New behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
Tested on Debian unstable using Linux 4.19.29.
Note, this needs a hard reset when coming from an unpatched kernel.
Signed-off-by Jochen Sprickerhof <[email protected]>
---
drivers/usb/dwc3/core.c | 1 +
1 file changed, 1 insertion(+)

Quoted 12 lines

drivers/usb/dwc3/core.c MODULE_ALIAS("platform:dwc3"); · line 1749
Quoted 9 lines
drivers/usb/dwc3/core.c +1 -0
index 103807587dc6..9017e4ed9d99 100644
@@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
 MODULE_AUTHOR("Felipe Balbi <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
+MODULE_SOFTDEP("pre: xhci_plat_hcd");
Your patch is corrupted and can not be applied :(

I'm sorry to hear that. For me this works:

git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
cd linux
curl "https://lore.kernel.org/lkml/20190321202303.GA1399@vis/raw" | git am -

But I found some archives that seems to have fiddled with the Content-Type of my signed mail, making it fail. Can you send more information about the corruption?

Thanks

Jochen

Greg Kroah-Hartman

maintainer

2019-03-23 06:05 UTC #3 lore raw

Quoted 47 lines · Jochen Sprickerhof

Hi Greg,
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Jochen Sprickerhof
This adds a soft dependency to the dwc3 module to load it after xhci-plat as proposed in:
https://marc.info/?l=linux-usb&m=155230272022603&w=2
Old behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
/:  Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
New behaviour:
$ lsusb -t
/:  Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
  |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
Tested on Debian unstable using Linux 4.19.29.
Note, this needs a hard reset when coming from an unpatched kernel.
Signed-off-by Jochen Sprickerhof <[email protected]>
---
drivers/usb/dwc3/core.c | 1 +
1 file changed, 1 insertion(+)
Quoted 12 lines
drivers/usb/dwc3/core.c MODULE_ALIAS("platform:dwc3"); · line 1749
Quoted 9 lines
drivers/usb/dwc3/core.c +1 -0
index 103807587dc6..9017e4ed9d99 100644
@@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
 MODULE_AUTHOR("Felipe Balbi <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
+MODULE_SOFTDEP("pre: xhci_plat_hcd");
Your patch is corrupted and can not be applied :(
I'm sorry to hear that. For me this works:

Quoted 7 lines

git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
cd linux
curl "https://lore.kernel.org/lkml/20190321202303.GA1399@vis/raw" | git am -
But I found some archives that seems to have fiddled with the Content-Type of my signed mail, making it fail. Can you send more information about the corruption?

Maybe it works if I look at the raw email, but just from the above text, your leading ' ' characters are dropped, so that's why I emailed you this.

Let me go look at the message I received...

Ah, yeah, the raw message is correct, it just has a gpg signature which messed with my email client's display somehow and dropped those leading spaces.

Sorry for the noise, all is good.

greg k-h