Skip to contentSkip to conversation

staging: olpc_dcon: Add Tabs to define-Macros

PATCH In review Emanuel Bennici 2 participants 2 messages Mar 22, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: olpc_dcon: Add Tabs to define-Macros

Improve Code Readability by adding Tabs after #define-Macro definition.

---
 drivers/staging/olpc_dcon/olpc_dcon.h        | 24 ++++++++++----------
 drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c |  8 +++----
 2 files changed, 16 insertions(+), 16 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.h +12 -12
index c987aaf894e7..277b19967315 100644
@@ -10,18 +10,18 @@
 #define DCON_REG_ID		 0
 #define DCON_REG_MODE		 1
 
-#define MODE_PASSTHRU	BIT(0)
-#define MODE_SLEEP	BIT(1)
-#define MODE_SLEEP_AUTO	BIT(2)
-#define MODE_BL_ENABLE	BIT(3)
-#define MODE_BLANK	BIT(4)
-#define MODE_CSWIZZLE	BIT(5)
-#define MODE_COL_AA	BIT(6)
-#define MODE_MONO_LUMA	BIT(7)
-#define MODE_SCAN_INT	BIT(8)
-#define MODE_CLOCKDIV	BIT(9)
-#define MODE_DEBUG	BIT(14)
-#define MODE_SELFTEST	BIT(15)
+#define MODE_PASSTHRU		BIT(0)
+#define MODE_SLEEP		BIT(1)
+#define MODE_SLEEP_AUTO		BIT(2)
+#define MODE_BL_ENABLE		BIT(3)
+#define MODE_BLANK		BIT(4)
+#define MODE_CSWIZZLE		BIT(5)
+#define MODE_COL_AA		BIT(6)
+#define MODE_MONO_LUMA		BIT(7)
+#define MODE_SCAN_INT		BIT(8)
+#define MODE_CLOCKDIV		BIT(9)
+#define MODE_DEBUG		BIT(14)
+#define MODE_SELFTEST		BIT(15)
 
 #define DCON_REG_HRES		0x2
 #define DCON_REG_HTOTAL		0x3
drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c +4 -4
index 838daa2be3ef..7972b591d1b8 100644
@@ -31,10 +31,10 @@
  *	DCONSMBCLK connects to VX855 graphics CRTSPCLK
  */
 
-#define VX855_GENL_PURPOSE_OUTPUT 0x44c /* PMIO_Rx4c-4f */
-#define VX855_GPI_STATUS_CHG 0x450  /* PMIO_Rx50 */
-#define VX855_GPI_SCI_SMI 0x452  /* PMIO_Rx52 */
-#define BIT_GPIO12 0x40
+#define VX855_GENL_PURPOSE_OUTPUT	0x44c /* PMIO_Rx4c-4f */
+#define VX855_GPI_STATUS_CHG		0x450  /* PMIO_Rx50 */
+#define VX855_GPI_SCI_SMI		0x452  /* PMIO_Rx52 */
+#define BIT_GPIO12			0x40
 
 #define PREFIX "OLPC DCON:"
 
Signature · 1 line
2.19.1
#1 lore raw
Quoted 31 lines · Emanuel Bennici

Improve Code Readability by adding Tabs after #define-Macro definition.

---
 drivers/staging/olpc_dcon/olpc_dcon.h        | 24 ++++++++++----------
 drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c |  8 +++----
 2 files changed, 16 insertions(+), 16 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.h +2 -12
index c987aaf894e7..277b19967315 100644
@@ -10,18 +10,18 @@
 #define DCON_REG_ID		 0
 #define DCON_REG_MODE		 1
 
-#define MODE_PASSTHRU	BIT(0)
-#define MODE_SLEEP	BIT(1)
-#define MODE_SLEEP_AUTO	BIT(2)
-#define MODE_BL_ENABLE	BIT(3)
-#define MODE_BLANK	BIT(4)
-#define MODE_CSWIZZLE	BIT(5)
-#define MODE_COL_AA	BIT(6)
-#define MODE_MONO_LUMA	BIT(7)
-#define MODE_SCAN_INT	BIT(8)
-#define MODE_CLOCKDIV	BIT(9)
-#define MODE_DEBUG	BIT(14)
-#define MODE_SELFTEST	BIT(15)
+#define MODE_PASSTHRU		BIT(0)
+#define MODE_SLEEP		BIT(1)

drivers/staging/olpc_dcon/olpc_dcon.h line 24

Quoted 10 lines
drivers/staging/olpc_dcon/olpc_dcon.h +10 -0
+#define MODE_SLEEP_AUTO		BIT(2)
+#define MODE_BL_ENABLE		BIT(3)
+#define MODE_BLANK		BIT(4)
+#define MODE_CSWIZZLE		BIT(5)
+#define MODE_COL_AA		BIT(6)
+#define MODE_MONO_LUMA		BIT(7)
+#define MODE_SCAN_INT		BIT(8)
+#define MODE_CLOCKDIV		BIT(9)
+#define MODE_DEBUG		BIT(14)
+#define MODE_SELFTEST		BIT(15)

These really did not have to be changed, did they?

Quoted 9 lines
drivers/staging/olpc_dcon/olpc_dcon.h +0 -0
 #define DCON_REG_HRES		0x2
 #define DCON_REG_HTOTAL		0x3
drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c +0 -0
index 838daa2be3ef..7972b591d1b8 100644
@@ -31,10 +31,10 @@
  *	DCONSMBCLK connects to VX855 graphics CRTSPCLK

drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c line 37

Quoted 10 lines
drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c +4 -4
  */
 
-#define VX855_GENL_PURPOSE_OUTPUT 0x44c /* PMIO_Rx4c-4f */
-#define VX855_GPI_STATUS_CHG 0x450  /* PMIO_Rx50 */
-#define VX855_GPI_SCI_SMI 0x452  /* PMIO_Rx52 */
-#define BIT_GPIO12 0x40
+#define VX855_GENL_PURPOSE_OUTPUT	0x44c /* PMIO_Rx4c-4f */
+#define VX855_GPI_STATUS_CHG		0x450  /* PMIO_Rx50 */
+#define VX855_GPI_SCI_SMI		0x452  /* PMIO_Rx52 */
+#define BIT_GPIO12			0x40

Also use a tab before the comment on these lines.

thanks,

greg k-h