msr: Add missing prototypes.
PATCH 1/1 msr: Add missing prototypes.
Add the missing prototypes to rdmsr.h and wrmsr.h. Rearrange return values in the function declaration.
Signed-off-by Jesús Diéguez Fernández <[email protected]>
--- include/grub/i386/rdmsr.h | 5 ++++- include/grub/i386/wrmsr.h | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
include/grub/i386/rdmsr.h +4 -1
@@ -19,12 +19,15 @@#ifndef GRUB_RDMSR_H #define GRUB_RDMSR_H 1 +inline grub_uint64_t grub_msr_read (grub_uint32_t msr_id); +/* * TODO: Add a general protection exception handler. * Accessing a reserved or unimplemented MSR address results in a GP#. */ -extern inline grub_uint64_t grub_msr_read (grub_uint32_t msr_id) +inline grub_uint64_t +grub_msr_read (grub_uint32_t msr_id) {grub_uint32_t low, high;
include/grub/i386/wrmsr.h +4 -1
@@ -19,12 +19,15 @@#ifndef GRUB_WRMSR_H #define GRUB_WRMSR_H 1 +inline void grub_msr_write (grub_uint32_t msr_id,grub_uint64_t msr_value); +/* * TODO: Add a general protection exception handler. * Accessing a reserved or unimplemented MSR address results in a GP#. */ -extern inline void grub_msr_write (grub_uint32_t msr_id,grub_uint64_t msr_value) +inline void +grub_msr_write (grub_uint32_t msr_id,grub_uint64_t msr_value) {grub_uint32_t low = msr_value, high = msr_value >>32 ;
Signature · 1 line
2.17.1
Quoted 1 line · Jesús Diéguez Fernández
Add the missing prototypes to
rdmsr.handwrmsr.h.
This does not make sense. Please drop them.
Quoted 1 line
Rearrange return values in the function declaration.
I am OK with that. Please repost the patch.
Daniel