Skip to contentSkip to conversation

ARM: dts: i.MX6Q: fix avoid_unnecessary_addr_size warnings

PATCH Superseded Marcel Ziswiler 3 participants 3 messages Mar 25, 2019 – Apr 9, 2019

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: i.MX6Q: fix avoid_unnecessary_addr_size warnings

From: Marcel Ziswiler <[email protected]>

This fixes the following warnings:

w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 2/endpoint at 0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 2/endpoint at 1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 2/endpoint at 2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 2/endpoint at 3:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 2/endpoint at 4:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 3/endpoint at 1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 3/endpoint at 2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 3/endpoint at 3:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (reg_format): /soc/ipu at 2800000/
port at 3/endpoint at 4:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 0: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 0: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 1: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 1: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 2: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 2: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 3: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 3: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 4: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 2/endpoint at 4: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 1: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 1: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 2: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 2: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 3: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 3: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 4: Relying on default #address-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_default_addr_size):
/soc/ipu at 2800000/port at 3/endpoint at 4: Relying on default #size-cells value
w+arch/arm/dts/imx6-apalis.dtb: Warning (avoid_unnecessary_addr_size):
Failed prerequisite 'avoid_default_addr_size'

---

 arch/arm/dts/imx6q.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/imx6q.dtsi +4 -0
index ab1716b6b0..8381d24eff 100644
@@ -234,6 +234,8 @@
 			};
 
 			ipu2_di0: port at 2 {
+				#address-cells = <1>;
+				#size-cells = <0>;
 				reg = <2>;
 
 				ipu2_di0_disp0: endpoint at 0 {
@@ -262,6 +264,8 @@
 			};
 
 			ipu2_di1: port at 3 {
+				#address-cells = <1>;
+				#size-cells = <0>;
 				reg = <3>;
 
 				ipu2_di1_hdmi: endpoint at 1 {
Signature · 1 line
2.20.1
reviewer
#1 lore raw

PATCH 1/1 ARM: dts: i.MX6Q: fix avoid_unnecessary_addr_size warnings

Hi Marcel,

arch/arm/dts/imx6q.dtsi line 238

Quoted 10 lines · Marcel Ziswiler
arch/arm/dts/imx6q.dtsi +2 -0
index ab1716b6b0..8381d24eff 100644
@@ -234,6 +234,8 @@
                        };
 
                        ipu2_di0: port at 2 {
+                               #address-cells = <1>;
+                               #size-cells = <0>;

This change is already in the upstream imx6q.dtsi file in Linux.

What about syncing the U-Boot i.mx6 dts with the kernel?

#2 lore raw

PATCH 1/1 ARM: dts: i.MX6Q: fix avoid_unnecessary_addr_size warnings

Quoted 12 lines · Fabio Estevam

Hi Marcel,

Quoted 7 lines · Marcel Ziswiler
arch/arm/dts/imx6q.dtsi +0 -0
index ab1716b6b0..8381d24eff 100644
@@ -234,6 +234,8 @@
                        };
 
Quoted 7 lines

arch/arm/dts/imx6q.dtsi line 238

Quoted 3 lines
arch/arm/dts/imx6q.dtsi +2 -0
                        ipu2_di0: port at 2 {
+                               #address-cells = <1>;
+                               #size-cells = <0>;

This change is already in the upstream imx6q.dtsi file in Linux.

What about syncing the U-Boot i.mx6 dts with the kernel?

Yeah, I agree. As a matter of fact I see only one single line of further difference in the two. Let me add that as well in a v2 and clearly state that it is a complete re-sync.