Skip to contentSkip to conversation

habanalabs fixes for 5.1-rc3

GIT PULL Oded Gabbay 2 participants 5 messages Mar 26, 2019 – Mar 28, 2019

lore
Share & tools
lore
#0 lore raw

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Thanks,
Oded

The following changes since commit 8c2ffd9174779014c3fe1f96d9dc3641d9175f00:

Linux 5.1-rc2 (2019-03-24 14:02:26 -0700)

are available in the Git repository at:

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-03-26

for you to fetch changes up to 7c22278edd0a931c565a8511dfc1bc57ffbb9166:

habanalabs: cast to expected type (2019-03-03 10:23:29 +0200)

----------------------------------------------------------------
The following bug fixes are included in this tag:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

----------------------------------------------------------------
Oded Gabbay (3):
habanalabs: perform accounting for active CS
habanalabs: prevent host crash during suspend/resume
habanalabs: cast to expected type

Omer Shpigelman (4):
habanalabs: fix MMU number of pages calculation
habanalabs: fix bug when mapping very large memory area
habanalabs: complete user context cleanup before hard reset
habanalabs: fix mapping with page size bigger than 4KB

 drivers/misc/habanalabs/command_submission.c |  6 +++
 drivers/misc/habanalabs/debugfs.c            |  7 +--
 drivers/misc/habanalabs/device.c             | 71 ++++++++++++++++++++++++++--
 drivers/misc/habanalabs/goya/goya.c          | 65 +------------------------
 drivers/misc/habanalabs/habanalabs.h         | 21 ++++----
 drivers/misc/habanalabs/hw_queue.c           |  5 +-
 drivers/misc/habanalabs/memory.c             | 38 ++++++++-------
 drivers/misc/habanalabs/mmu.c                |  6 ++-
 8 files changed, 117 insertions(+), 102 deletions(-)
#1 lore raw
Quoted 9 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Much better, thanks, now pulled and pushed out.

greg k-h

#2 lore raw
Quoted 12 lines · Greg KH
Quoted 9 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Quoted 3 lines

Much better, thanks, now pulled and pushed out.

greg k-h

Hi Greg,
In which branch do I see that ? I tried to find it in your char-misc repo but couldn't find it.

Thanks,
Oded

#3 lore raw
Quoted 13 lines · Oded Gabbay
Quoted 12 lines · Greg KH
Quoted 9 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Quoted 7 lines
Quoted 3 lines

Much better, thanks, now pulled and pushed out.

greg k-h

Hi Greg,
In which branch do I see that ? I tried to find it in your char-misc repo but couldn't find it.

It should be in the char-misc-linus branch of the char-misc.git repo on git.kernel.org. Note, I was in the air for a long time yesterday, so the emails probably went out 8 hours before I was able to push out the git repo, but it should all be synced up now. Sorry for any confusion there.

greg k-h

#4 lore raw
Quoted 23 lines · Greg KH
Quoted 13 lines · Oded Gabbay
Quoted 12 lines · Greg KH
Quoted 9 lines · Oded Gabbay

Hi Greg,

A couple of important fixes for habanalabs driver:

- Fix host crash upon resume after suspend
- Fix MMU related bugs which result in user's jobs getting stuck
- Fix race between user context cleanup and hard-reset which results in host crash
- Fix sparse warning

Quoted 7 lines
Quoted 3 lines

Much better, thanks, now pulled and pushed out.

greg k-h

Hi Greg,
In which branch do I see that ? I tried to find it in your char-misc repo but couldn't find it.

Quoted 7 lines

It should be in the char-misc-linus branch of the char-misc.git repo on git.kernel.org. Note, I was in the air for a long time yesterday, so the emails probably went out 8 hours before I was able to push out the git repo, but it should all be synced up now. Sorry for any confusion there.

greg k-h

ah, ok. no problem, just wanted to make sure I'm looking at the right location.

Oded