Skip to contentSkip to conversation

gtk+3: add librsvg to DEPENDS

PATCH In review Andreas Müller 3 participants 11 messages Mar 26, 2019 – Mar 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gtk+3: add librsvg to DEPENDS

adwaita-icon-themes failes to create symbolic icons. In log.do_install when calling gtk-encode-symbolic-svg there many complaints

| Can't load file: Unrecognized image file format

We fail her now due to:

commit 7f6c57635ff4e1edf7a46c49af34846ad0a4bf73

Author: Alexander Kanavin <[email protected]>
Date:   Wed Jan 30 11:59:25 2019 +0100

gtk+3: remove the gtk-icon-utils-native recipe

gtk-icon-utils-native had librsvg in its DEPENDS. We do not add librsvg-native because same issue would occure for gtk-encode-symbolic-svg on target.

---
 meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/gtk+/gtk+3.inc +1 -1
index 77b6c31536..b58641a470 100644
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.gtk.org"
 BUGTRACKER = "https://bugzilla.gnome.org/"
 SECTION = "libs"
 
-DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf \
+DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf librsvg \
            gdk-pixbuf-native"
 
 LICENSE = "LGPLv2 & LGPLv2+ & LGPLv2.1+"
Signature · 1 line
2.20.1
#1 lore raw

But GTK+ doesn't depend on librsvg at all, and this is a failure in adwaita-icon-theme. Why doesn't the dependency belong on adwaita-icon-theme?

Ross

Quoted 43 lines · Andreas Müller

adwaita-icon-themes failes to create symbolic icons. In log.do_install when calling gtk-encode-symbolic-svg there many complaints

| Can't load file: Unrecognized image file format

We fail her now due to:

commit 7f6c57635ff4e1edf7a46c49af34846ad0a4bf73

Author: Alexander Kanavin <[email protected]>
Date:   Wed Jan 30 11:59:25 2019 +0100

gtk+3: remove the gtk-icon-utils-native recipe

gtk-icon-utils-native had librsvg in its DEPENDS. We do not add librsvg-native because same issue would occure for gtk-encode-symbolic-svg on target.

---
 meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/gtk+/gtk+3.inc +1 -2
index 77b6c31536..b58641a470 100644
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.gtk.org"
 BUGTRACKER = "https://bugzilla.gnome.org/"
 SECTION = "libs"
 
-DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf \
+DEPENDS = "glib-2.0 cairo pango atk jpeg libpng gdk-pixbuf librsvg \
            gdk-pixbuf-native"
 
 LICENSE = "LGPLv2 & LGPLv2+ & LGPLv2.1+"
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 4 lines · Ross

But GTK+ doesn't depend on librsvg at all, and this is a failure in adwaita-icon-theme. Why doesn't the dependency belong on adwaita-icon-theme?

I believe adwaita runs some utility that gtk provides?

Alex

#3 lore raw
Quoted 8 lines · Alexander Kanavin
Quoted 4 lines · Ross

But GTK+ doesn't depend on librsvg at all, and this is a failure in adwaita-icon-theme. Why doesn't the dependency belong on adwaita-icon-theme?

I believe adwaita runs some utility that gtk provides?

Sure, but gtk+ doesn't link to librsvg, so a DEPENDS isn't the correct fix.

Patch incoming.

Ross

#4 lore raw
Quoted 9 lines · Ross
Quoted 7 lines · Alexander Kanavin
Quoted 4 lines · Ross

But GTK+ doesn't depend on librsvg at all, and this is a failure in adwaita-icon-theme. Why doesn't the dependency belong on adwaita-icon-theme?

Quoted 6 lines
Quoted 1 line

I believe adwaita runs some utility that gtk provides?

Sure, but gtk+ doesn't link to librsvg, so a DEPENDS isn't the correct fix.

Patch incoming.

Thought same. Are you sure that does not link - or can you explain how DEPENDs fixed adwaita: If it does not link: How comes that librsvg makes it into adwaita's native sysroot?

Andreas

#5 lore raw
Quoted 3 lines · Andreas Müller

Thought same. Are you sure that does not link - or can you explain how DEPENDs fixed adwaita: If it does not link: How comes that librsvg makes it into adwaita's native sysroot?

I suspect historical about how the sysroot is populated for native things, as until very recently RDEPENDS wasn't considered.

(oe-core c62520b63284927e177831c351fafa4d2768cb1f)

Ross

#6 lore raw
Quoted 11 lines · Ross
Quoted 3 lines · Andreas Müller

Thought same. Are you sure that does not link - or can you explain how DEPENDs fixed adwaita: If it does not link: How comes that librsvg makes it into adwaita's native sysroot?

I suspect historical about how the sysroot is populated for native things, as until very recently RDEPENDS wasn't considered.

(oe-core c62520b63284927e177831c351fafa4d2768cb1f)

* Think I had this patch in my builds - whatever
* The patch you just sent: Doesn't adwaita-icon-theme need a rdepend on librsvg then? If so it is another allarch rdepending on arch recipe...

Andreas

#7 lore raw
Quoted 3 lines · Andreas Müller

* The patch you just sent: Doesn't adwaita-icon-theme need a rdepend on librsvg then? If so it is another allarch rdepending on arch recipe...

RDEPEND? No. The theme just contains PNGs and SVGs.

Ross

#8 lore raw
Quoted 9 lines · Ross
Quoted 3 lines · Andreas Müller

* The patch you just sent: Doesn't adwaita-icon-theme need a rdepend on librsvg then? If so it is another allarch rdepending on arch recipe...

RDEPEND? No. The theme just contains PNGs and SVGs.

Ross

Ehm but .. no let's not continue this.

Hope adwaita-icon packs remain complete / have librsvg from elsewhere in my images.

Andreas

#9 lore raw
Quoted 2 lines · Andreas Müller

Hope adwaita-icon packs remain complete / have librsvg from elsewhere in my images.

The theme itself doesn't mean pulling in librsvg. Whatever is using the icons is responsible for that, so if you're using something GNOMEy then that's gdk-pixbuf + librsvg.

Ross

#10 lore raw
In reply to Burton, Ross
Quoted 10 lines · Ross
Quoted 3 lines · Andreas Müller

Thought same. Are you sure that does not link - or can you explain how DEPENDs fixed adwaita: If it does not link: How comes that librsvg makes it into adwaita's native sysroot?

I suspect historical about how the sysroot is populated for native things, as until very recently RDEPENDS wasn't considered.

(oe-core c62520b63284927e177831c351fafa4d2768cb1f)

There is something I struggle to understand about enabling RDEPENDS for native.

RDEPENDS is listing package names, not recipe names. Yet for native recipes, the package list is empty, as set by the native.bbclass. How is this supposed to work then?

A reproducer:

add
RDEPENDS_${PN} = 'libicuio' to libyaml recipe. (libicuio is a package from icu recipe)

Then libyaml builds, but libyaml-native fails:

ERROR: Nothing RPROVIDES 'libicuio-native' (but virtual:native:/home/alexander/development/poky/meta/recipes-support/libyaml/libyaml_0.2.2.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'libicuio-native' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['libicuio-native']
ERROR: Required build target 'libyaml-native' has no buildable providers. Missing or unbuildable dependency chain was: ['libyaml-native', 'libicuio-native']

Should I file a bug?

Alex