Skip to contentSkip to conversation

misc: fastrpc: add checked value for dma_set_mask

PATCH New Bo YU 1 participant 1 message Mar 28, 2019

Subsystems (2)
lore
Share & tools
lore

Bo YU

author
#0 lore raw

PATCH v2 1/1 misc: fastrpc: add checked value for dma_set_mask

There be should check return value from dma_set_mask to throw some info if fail to set dma mask.

Detected by CoverityScan, CID# 1443983: Error handling issues (CHECKED_RETURN)

Fixes f6f9279f2bf0 (misc: fastrpc: Add Qualcomm fastrpc basic driver model)

---
V2: rebase misc tree

---
 drivers/misc/fastrpc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/misc/fastrpc.c +6 -1
index 39f832d27288..36d0d5c9cfba 100644
@@ -1184,6 +1184,7 @@ static int fastrpc_cb_probe(struct platform_device *pdev)
 	struct fastrpc_session_ctx *sess;
 	struct device *dev = &pdev->dev;
 	int i, sessions = 0;
+	int rc;
 
 	cctx = dev_get_drvdata(dev->parent);
 	if (!cctx)
@@ -1213,7 +1214,11 @@ static int fastrpc_cb_probe(struct platform_device *pdev)
 	}
 	cctx->sesscount++;
 	spin_unlock(&cctx->lock);
-	dma_set_mask(dev, DMA_BIT_MASK(32));
+	rc = dma_set_mask(dev, DMA_BIT_MASK(32));
+	if (rc) {
+		dev_err(dev, "32-bit DMA enable failed\n");
+		return rc;
+	}
 
 	return 0;
 }

--
2.11.0