drm: etnaviv: fix strncpy sizeof argument
Subsystems (2)
PATCH v2 1/1 drm: etnaviv: fix strncpy sizeof argument
Calling strncpy with a maximum size argument of 64 bytes on destination array "domain->name" of size 64 bytes might leave the destination string unterminated.
Detected by CoverityScan, CID# 1443992: Memory - illegal accesses (BUFFER_SIZE_WARNING)
Fixes 9e2c2e2730126 (drm/etnaviv: add infrastructure to query perf counter)
Signed-off-by Bo YU <[email protected]>
---
v2: accroding to Russell's suggestion, replace strncpy with strlcpy
--- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c +1 -1
@@ -414,7 +414,7 @@ int etnaviv_pm_query_dom(struct etnaviv_gpu *gpu, domain->id = domain->iter; domain->nr_signals = dom->nr_signals; -strncpy (domain->name, dom->name,sizeof (domain->name)); +strlcpy (domain->name, dom->name,sizeof (domain->name)); domain->iter++;if (domain->iter == meta->nr_domains)
Signature · 1 line
2.11.0
Quoted 29 lines · Bo YU
Calling strncpy with a maximum size argument of 64 bytes on destination array "
domain->name" of size 64 bytes might leave the destination string unterminated.Detected by CoverityScan, CID# 1443992: Memory - illegal accesses (
BUFFER_SIZE_WARNING)Fixes 9e2c2e2730126 (drm/etnaviv: add infrastructure to query perf counter)Signed-off-by Bo YU <[email protected]>---
v2: accroding to Russell's suggestion, replace strncpy with strlcpy--- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/etnaviv/etnaviv_perfmon.c +1
-2@@ -414,7 +414,7 @@ int etnaviv_pm_query_dom(struct etnaviv_gpu *gpu, domain->id = domain->iter; domain->nr_signals = dom->nr_signals; -strncpy (domain->name, dom->name,sizeof (domain->name)); +strlcpy (domain->name, dom->name,sizeof (domain->name)); domain->iter++;if (domain->iter == meta->nr_domains) --
Quoted 2 lines
2.11.0
Ping?