Skip to contentSkip to conversation

configs: am57xx_evm: Remove ENV_IS_IN_FAT

PATCH New Faiz Abbas 4 participants 8 messages Mar 28, 2019 – Apr 3, 2019

lore
Share & tools
lore

Faiz Abbas

author
#0 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/am57xx_evm_defconfig +1 -0
index 3d71020225..e4f0458d72 100644
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y
configs/am57xx_hs_evm_defconfig +1 -0
index 9b71afa312..157ae1ea1c 100644
@@ -38,6 +38,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am57xx-beagle-x15"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Quoted 14 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/am57xx_evm_defconfig +0 -0
index 3d71020225..e4f0458d72 100644

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 7 lines
configs/am57xx_evm_defconfig +1 -0
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190328/4ec61b5f/attachment.sig>
author
#2 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Tom,

Quoted 11 lines · Tom Rini
Quoted 9 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
Quoted 15 lines

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 12 lines
configs/am57xx_evm_defconfig +1 -0
index 3d71020225..e4f0458d72 100644
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

There is an eMMC on beagle X15 which is being used to support android boot. Do you have any other concerns?

Thanks,
Faiz

#3 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Quoted 29 lines · Faiz Abbas

Tom,

Quoted 11 lines · Tom Rini
Quoted 9 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
Quoted 14 lines

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 12 lines
configs/am57xx_evm_defconfig +1 -0
index 3d71020225..e4f0458d72 100644
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

Quoted 2 lines

There is an eMMC on beagle X15 which is being used to support android boot. Do you have any other concerns?

Yes, I know there's eMMC, but usually in "maker" type devices we have specifically moved from eMMC to FAT. Lokesh, are you OK with this change?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190329/3b8012e3/attachment.sig>
#4 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

+ Praneeth

Quoted 30 lines · Tom Rini
Quoted 29 lines · Faiz Abbas

Tom,

Quoted 25 lines · Tom Rini
Quoted 14 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/am57xx_evm_defconfig +0 -0
index 3d71020225..e4f0458d72 100644

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 7 lines
configs/am57xx_evm_defconfig +1 -0
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

Quoted 6 lines
Quoted 2 lines

There is an eMMC on beagle X15 which is being used to support android boot. Do you have any other concerns?

Yes, I know there's eMMC, but usually in "maker" type devices we have specifically moved from eMMC to FAT. Lokesh, are you OK with this change?

This is more of an android requirement who requested for having eMMC as env partition. am57xx x15 is one of the board tested along with asop project. I guess it is fine to have this change.

Thanks and regards,
Lokesh

#5 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Hi Faiz,

Quoted 13 lines · Lokesh Vutla

+ Praneeth

Quoted 9 lines · Tom Rini
Quoted 8 lines · Faiz Abbas

Tom,

Quoted 5 lines · Tom Rini
Quoted 3 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

Can you please describe in more details, which exactly problem you are trying to fix in this patch? As I understand, we support SD boot in Linux SDK [1], so saving env in FAT can be useful in this case. Could this issue be fixed in some other way, rather than dropping multi-environment feature?

Thanks!

[1] http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components_U-Boot.html#sd-emmc-or-usb-storage

Quoted 38 lines
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
Quoted 11 lines
---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/am57xx_evm_defconfig +0 -0
index 3d71020225..e4f0458d72 100644

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 7 lines
configs/am57xx_evm_defconfig +1 -0
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

Quoted 6 lines
Quoted 2 lines

There is an eMMC on beagle X15 which is being used to support android boot. Do you have any other concerns?

Yes, I know there's eMMC, but usually in "maker" type devices we have specifically moved from eMMC to FAT. Lokesh, are you OK with this change?

This is more of an android requirement who requested for having eMMC as env partition. am57xx x15 is one of the board tested along with asop project. I guess it is fine to have this change.

Thanks and regards,
Lokesh
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

author
#6 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Hi Sam,

Quoted 17 lines · Sam Protsenko

Hi Faiz,

Quoted 13 lines · Lokesh Vutla

+ Praneeth

Quoted 9 lines · Tom Rini
Quoted 8 lines · Faiz Abbas

Tom,

Quoted 5 lines · Tom Rini
Quoted 3 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

Quoted 7 lines

Can you please describe in more details, which exactly problem you are trying to fix in this patch? As I understand, we support SD boot in Linux SDK [1], so saving env in FAT can be useful in this case. Could this issue be fixed in some other way, rather than dropping multi-environment feature?

Thanks!

Today U-boot comes up and always looks for environment first in SD Fat partition and then in the eMMC. We should not allow U-boot to look for environment in every single boot media that is enabled. We have had a policy of saving environment in eMMC since a long time (before the multi-environment feature was added) even when booting from SD card. I know that most people would prefer it to be in SD card but because of android requirements, we chose it to be in eMMC.

Furthermore, the error message when it looks for environment in SD card and fails is an invitation for trouble from users (even more so when there is a confusion regarding where the environment should be and how to change it).

Thanks,
Faiz

Quoted 41 lines

[1] http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components_U-Boot.html#sd-emmc-or-usb-storage

Quoted 38 lines
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
Quoted 11 lines
---
 configs/am57xx_evm_defconfig    | 1 +
 configs/am57xx_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/am57xx_evm_defconfig +0 -0
index 3d71020225..e4f0458d72 100644

configs/am57xx_evm_defconfig CONFIG_OF_CONTROL=y · line 41

Quoted 7 lines
configs/am57xx_evm_defconfig +1 -0
@@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
 CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
+# CONFIG_ENV_IS_IN_FAT is not set
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM=y

Is this really a good idea for the config we use for Beagle X15?

Quoted 6 lines
Quoted 2 lines

There is an eMMC on beagle X15 which is being used to support android boot. Do you have any other concerns?

Yes, I know there's eMMC, but usually in "maker" type devices we have specifically moved from eMMC to FAT. Lokesh, are you OK with this change?

This is more of an android requirement who requested for having eMMC as env partition. am57xx x15 is one of the board tested along with asop project. I guess it is fine to have this change.

Thanks and regards,
Lokesh
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#7 lore raw

PATCH 1/1 configs: am57xx_evm: Remove ENV_IS_IN_FAT

Quoted 36 lines · Faiz Abbas

Hi Sam,

Quoted 17 lines · Sam Protsenko

Hi Faiz,

Quoted 13 lines · Lokesh Vutla

+ Praneeth

Quoted 9 lines · Tom Rini
Quoted 8 lines · Faiz Abbas

Tom,

Quoted 5 lines · Tom Rini
Quoted 3 lines · Faiz Abbas

With U-boot supporting environment in multiple places, enable only ENV_IS_IN_EMMC.

Quoted 7 lines

Can you please describe in more details, which exactly problem you are trying to fix in this patch? As I understand, we support SD boot in Linux SDK [1], so saving env in FAT can be useful in this case. Could this issue be fixed in some other way, rather than dropping multi-environment feature?

Thanks!

Today U-boot comes up and always looks for environment first in SD Fat partition and then in the eMMC. We should not allow U-boot to look for environment in every single boot media that is enabled. We have had a policy of saving environment in eMMC since a long time (before the multi-environment feature was added) even when booting from SD card. I know that most people would prefer it to be in SD card but because of android requirements, we chose it to be in eMMC.

Quoted 4 lines

Furthermore, the error message when it looks for environment in SD card and fails is an invitation for trouble from users (even more so when there is a confusion regarding where the environment should be and how to change it).

Maybe this is motivation to implement some of the ideas (or propose a new one) for "make env not found on X trying Y" less scary and/or something other than link order for order we look for environment in.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/9104d66c/attachment.sig>