scsi: aic79xx: NULL check before some freeing functions is not needed.
Subsystems (3)
PATCH 1/1 scsi: aic79xx: NULL check before some freeing functions is not needed.
Fix the following coccinelle warning by removing NULL check before calling kfree:
NULL check before some freeing functions is not needed.
Signed-off-by Quentin Deslandes <[email protected]>
--- drivers/scsi/aic7xxx/aic79xx_core.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-)
drivers/scsi/aic7xxx/aic79xx_core.c +5 -13
@@ -3664,8 +3664,6 @@ ahd_alloc_tstate(struct ahd_softc *ahd, u_int scsi_id, char channel)static void ahd_free_tstate (struct ahd_softc *ahd,u_int scsi_id,char channel,int force) { -struct ahd_tmode_tstate *tstate; -/* * Don't clean up our "master" tstate. * It has our default user settings.
@@ -3674,9 +3672,7 @@ ahd_free_tstate(struct ahd_softc *ahd, u_int scsi_id, char channel, int force) && force == FALSE)return ; - tstate = ahd->enabled_targets[scsi_id]; -if (tstate !=NULL ) -kfree (tstate); +kfree (ahd->enabled_targets[scsi_id]); ahd->enabled_targets[scsi_id] = NULL; }#endif
@@ -6138,8 +6134,7 @@ ahd_set_unit(struct ahd_softc *ahd, int unit)void ahd_set_name (struct ahd_softc *ahd,char *name) { -if (ahd->name !=NULL ) -kfree (ahd->name); +kfree (ahd->name); ahd->name = name; }
@@ -6200,12 +6195,9 @@ ahd_free(struct ahd_softc *ahd) kfree(ahd->black_hole); }#endif -if (ahd->name !=NULL ) -kfree (ahd->name); -if (ahd->seep_config !=NULL ) -kfree (ahd->seep_config); -if (ahd->saved_stack !=NULL ) -kfree (ahd->saved_stack); +kfree (ahd->name); +kfree (ahd->seep_config); +kfree (ahd->saved_stack);#ifndef __FreeBSD__kfree (ahd);#endif
Signature · 1 line
2.17.1