Skip to contentSkip to conversation

phy: tegra: xusb: testing the wrong variable in probe()

PATCH New Dan Carpenter 1 participant 1 message Mar 28, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: tegra: xusb: testing the wrong variable in probe()

The "usb2->clk" pointer is not an error pointer. We meant to test "priv->usb2_trk_clk" instead.

Fixes b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
---
 drivers/phy/tegra/xusb-tegra186.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/tegra/xusb-tegra186.c +2 -2
index 11ad6e4e4711..a627fe0b8e54 100644
@@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
 	}
 
 	priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
-	if (IS_ERR(usb2->clk)) {
-		err = PTR_ERR(usb2->clk);
+	if (IS_ERR(priv->usb2_trk_clk)) {
+		err = PTR_ERR(priv->usb2_trk_clk);
 		dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
 		goto unregister;
 	}
Signature · 1 line
2.17.1