Skip to contentSkip to conversation

parport: ieee1284: mark expected switch fall-through

PATCH New Sudip Mukherjee 1 participant 1 message Mar 29, 2019 Parallel port

lore
Share & tools
lore

Sudip Mukherjee

author maintainer
#0 lore raw

PATCH 1/1 parport: ieee1284: mark expected switch fall-through

From: "Gustavo A. R. Silva" <[email protected]>

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/parport/ieee1284.c: In function ‘parport_read’:
drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

   if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
      ^

drivers/parport/ieee1284.c:726:2: note: here
case IEEE1284_MODE_NIBBLE:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/parport/ieee1284.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/parport/ieee1284.c +1 -1
index f12b9da69255..90fb73575495 100644
@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
 		if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
 			return -EIO;
 		}
-		/* fall through to NIBBLE */
+		/* fall through - to NIBBLE */
 	case IEEE1284_MODE_NIBBLE:
 		DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
 		fn = port->ops->nibble_read_data;
Signature · 1 line
2.11.0