Skip to contentSkip to conversation

Btrfs-progs: receive, add debug information to write and clone commands

PATCH In review [email protected] 2 participants 2 messages Mar 29, 2019 – May 15, 2019 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Btrfs-progs: receive, add debug information to write and clone commands

From: Filipe Manana <[email protected]>

Currently, when operating in a more verbose mode (-vv), the receive command does not mention any write or clone commands, unlike other commands.

This change adds debug messages for the write and clone operations, that do not include data but only offsets and lengths, as this is actually very useful to debug a send stream and I use it frequently.

---
 cmds-receive.c | 9 +++++++++
 1 file changed, 9 insertions(+)
cmds-receive.c +9 -0
index 3888149a..5d06f286 100644
@@ -704,6 +704,10 @@ static int process_write(const char *path, const void *data, u64 offset,
 	if (ret < 0)
 		goto out;
 
+	if (g_verbose >= 2)
+		fprintf(stderr, "write %s - offset=%llu length=%llu\n",
+			path, offset, len);
+
 	while (pos < len) {
 		w = pwrite(rctx->write_fd, (char*)data + pos, len - pos,
 				offset + pos);
@@ -808,6 +812,11 @@ static int process_clone(const char *path, u64 offset, u64 len,
 		goto out;
 	}
 
+	if (g_verbose >= 2)
+		fprintf(stderr,
+			"clone %s - source=%s source offset=%llu offset=%llu length=%llu\n",
+			path, clone_path, clone_offset, offset, len);
+
 	clone_args.src_fd = clone_fd;
 	clone_args.src_offset = clone_offset;
 	clone_args.src_length = len;
Signature · 1 line
2.11.0
#1 lore raw
Quoted 10 lines · On Fri, Mar 29, 2019 at 07:35:26PM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

Currently, when operating in a more verbose mode (-vv), the receive command does not mention any write or clone commands, unlike other commands.

This change adds debug messages for the write and clone operations, that do not include data but only offsets and lengths, as this is actually very useful to debug a send stream and I use it frequently.

Added to devel, sorry for the delay.