Skip to contentSkip to conversation

ublox: Correct the USBCONF reply prefix

PATCH Applied [email protected] 2 participants 2 messages Mar 31, 2019 – Apr 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ublox: Correct the USBCONF reply prefix

From: Richard Röjfors <[email protected]>

According to the u-blox AT Commands Manual and my tests the response prefix of AT+UUSBCONF is "+UUSBCONF:", including a colon. The colon was missing in the code, causing next step to parse a number to fail, since a colon is not a number.

---
 plugins/ublox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
plugins/ublox.c +1 -1
index dc001765..142a5af7 100644
@@ -164,7 +164,7 @@ static void query_usbconf_cb(gboolean ok,
 	g_at_result_iter_init(&iter, result);
 
 retry:
-	if (!g_at_result_iter_next(&iter, "+UUSBCONF")) {
+	if (!g_at_result_iter_next(&iter, "+UUSBCONF:")) {
 		ofono_error("Unable to query USB configuration");
 		goto error;
 	}
Signature · 1 line
2.19.1
#1 lore raw

Hi Richard,

Quoted 10 lines · richard.rojfors(a)gmail.com

From: Richard Röjfors <[email protected]>

According to the u-blox AT Commands Manual and my tests the response prefix of AT+UUSBCONF is "+UUSBCONF:", including a colon. The colon was missing in the code, causing next step to parse a number to fail, since a colon is not a number.

---
  plugins/ublox.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis