Skip to contentSkip to conversation

Categorize devices: DIMM

PATCH In review Ernest Esene 2 participants 2 messages Apr 1, 2019 – Apr 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 Categorize devices: DIMM

Set category and describe DIMM devices

---
v3:
* add MEMORY device category
* set category to MEMORY
v2:
* split into separate patches

---
 hw/mem/nvdimm.c        | 1 +
 hw/mem/pc-dimm.c       | 1 +
 include/hw/qdev-core.h | 1 +
 qdev-monitor.c         | 1 +
 4 files changed, 4 insertions(+)
hw/mem/nvdimm.c +1 -0
index bf2adf5e16..a334dbe1f5 100644
@@ -200,6 +200,7 @@ static void nvdimm_class_init(ObjectClass *oc, void *data)
     ddc->realize = nvdimm_realize;
     mdc->get_memory_region = nvdimm_md_get_memory_region;
     dc->props = nvdimm_properties;
+    dc->desc = "NVDIMM memory module";
 
     nvc->read_label_data = nvdimm_read_label_data;
     nvc->write_label_data = nvdimm_write_label_data;
hw/mem/pc-dimm.c +1 -0
index 152400b1fc..3ace8077b5 100644
@@ -259,6 +259,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
     dc->unrealize = pc_dimm_unrealize;
     dc->props = pc_dimm_properties;
     dc->desc = "DIMM memory module";
+    set_bit(DEVICE_CATEGORY_MEMORY, dc->categories);
 
     ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
 
include/hw/qdev-core.h +1 -0
index 33ed3b8dde..a7d9ea1fbe 100644
@@ -26,6 +26,7 @@ typedef enum DeviceCategory {
     DEVICE_CATEGORY_SOUND,
     DEVICE_CATEGORY_MISC,
     DEVICE_CATEGORY_CPU,
+    DEVICE_CATEGORY_MEMORY,
     DEVICE_CATEGORY_MAX
 } DeviceCategory;
 
qdev-monitor.c +1 -0
index d4320986a2..5318df205b 100644
@@ -143,6 +143,7 @@ static void qdev_print_devinfos(bool show_no_user)
         [DEVICE_CATEGORY_SOUND]   = "Sound",
         [DEVICE_CATEGORY_MISC]    = "Misc",
         [DEVICE_CATEGORY_CPU]     = "CPU",
+        [DEVICE_CATEGORY_MEMORY]  = "Memory",
         [DEVICE_CATEGORY_MAX]     = "Uncategorized",
     };
     GSList *list, *elt;
Signature · 1 line
2.14.2
Reviewed-by on v3 1/3
#1 lore raw
Quoted 3 lines · On Mon, 1 Apr 2019 19:11:50 +0100 Ernest Esene <[email protected]> wrote:

Set category and describe DIMM devices

Quoted 62 lines

---
v3:
* add MEMORY device category
* set category to MEMORY
v2:
* split into separate patches

---
 hw/mem/nvdimm.c        | 1 +
 hw/mem/pc-dimm.c       | 1 +
 include/hw/qdev-core.h | 1 +
 qdev-monitor.c         | 1 +
 4 files changed, 4 insertions(+)
hw/mem/nvdimm.c +1 -0
index bf2adf5e16..a334dbe1f5 100644
@@ -200,6 +200,7 @@ static void nvdimm_class_init(ObjectClass *oc, void *data)
     ddc->realize = nvdimm_realize;
     mdc->get_memory_region = nvdimm_md_get_memory_region;
     dc->props = nvdimm_properties;
+    dc->desc = "NVDIMM memory module";
 
     nvc->read_label_data = nvdimm_read_label_data;
     nvc->write_label_data = nvdimm_write_label_data;
hw/mem/pc-dimm.c +1 -0
index 152400b1fc..3ace8077b5 100644
@@ -259,6 +259,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
     dc->unrealize = pc_dimm_unrealize;
     dc->props = pc_dimm_properties;
     dc->desc = "DIMM memory module";
+    set_bit(DEVICE_CATEGORY_MEMORY, dc->categories);
 
     ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
 
include/hw/qdev-core.h +1 -0
index 33ed3b8dde..a7d9ea1fbe 100644
@@ -26,6 +26,7 @@ typedef enum DeviceCategory {
     DEVICE_CATEGORY_SOUND,
     DEVICE_CATEGORY_MISC,
     DEVICE_CATEGORY_CPU,
+    DEVICE_CATEGORY_MEMORY,
     DEVICE_CATEGORY_MAX
 } DeviceCategory;
 
qdev-monitor.c +1 -0
index d4320986a2..5318df205b 100644
@@ -143,6 +143,7 @@ static void qdev_print_devinfos(bool show_no_user)
         [DEVICE_CATEGORY_SOUND]   = "Sound",
         [DEVICE_CATEGORY_MISC]    = "Misc",
         [DEVICE_CATEGORY_CPU]     = "CPU",
+        [DEVICE_CATEGORY_MEMORY]  = "Memory",
         [DEVICE_CATEGORY_MAX]     = "Uncategorized",
     };
     GSList *list, *elt;