Skip to contentSkip to conversation

Categorize devices: iommu

PATCH In review Ernest Esene 2 participants 2 messages Apr 1, 2019 – Apr 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 3/3 Categorize devices: iommu

Set category and description for iommu devices.

---
v3:
* set category and describe smmuv3 as suggested by Eric
v2:
* split into separate patches

---
 hw/arm/smmuv3.c       | 2 ++
 hw/i386/amd_iommu.c   | 2 ++
 hw/i386/intel_iommu.c | 2 ++
 3 files changed, 6 insertions(+)
hw/arm/smmuv3.c +2 -0
index 8c4e99fecc..d5a3df047d 100644
@@ -1463,6 +1463,8 @@ static void smmuv3_class_init(ObjectClass *klass, void *data)
     device_class_set_parent_reset(dc, smmu_reset, &c->parent_reset);
     c->parent_realize = dc->realize;
     dc->realize = smmu_realize;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "ARM IOMMU (SMMUv3) DMA Remapping device"
 }
 
 static void smmuv3_notify_flag_changed(IOMMUMemoryRegion *iommu,
hw/i386/amd_iommu.c +2 -0
index 6eabdf9917..4a4e2c7fd4 100644
@@ -1601,6 +1601,8 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
     dc_class->int_remap = amdvi_int_remap;
     /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "AMD IOMMU (AMD-Vi) DMA Remapping device";
 }
 
 static const TypeInfo amdvi = {
hw/i386/intel_iommu.c +2 -0
index 055a1e865d..f9781a5d20 100644
@@ -3727,6 +3727,8 @@ static void vtd_class_init(ObjectClass *klass, void *data)
     x86_class->int_remap = vtd_int_remap;
     /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "Intel IOMMU (VT-d) DMA Remapping device";
 }
 
 static const TypeInfo vtd_info = {
Signature · 1 line
2.14.2
Reviewed-by on v3 3/3
#1 lore raw

Hi Ernest,

Quoted 3 lines · Ernest Esene

Set category and description for iommu devices.

Thanks

Eric

Quoted 52 lines

---
v3:
* set category and describe smmuv3 as suggested by Eric
v2:
* split into separate patches

---
 hw/arm/smmuv3.c       | 2 ++
 hw/i386/amd_iommu.c   | 2 ++
 hw/i386/intel_iommu.c | 2 ++
 3 files changed, 6 insertions(+)
hw/arm/smmuv3.c +2 -0
index 8c4e99fecc..d5a3df047d 100644
@@ -1463,6 +1463,8 @@ static void smmuv3_class_init(ObjectClass *klass, void *data)
     device_class_set_parent_reset(dc, smmu_reset, &c->parent_reset);
     c->parent_realize = dc->realize;
     dc->realize = smmu_realize;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "ARM IOMMU (SMMUv3) DMA Remapping device"
 }
 
 static void smmuv3_notify_flag_changed(IOMMUMemoryRegion *iommu,
hw/i386/amd_iommu.c +2 -0
index 6eabdf9917..4a4e2c7fd4 100644
@@ -1601,6 +1601,8 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
     dc_class->int_remap = amdvi_int_remap;
     /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "AMD IOMMU (AMD-Vi) DMA Remapping device";
 }
 
 static const TypeInfo amdvi = {
hw/i386/intel_iommu.c +2 -0
index 055a1e865d..f9781a5d20 100644
@@ -3727,6 +3727,8 @@ static void vtd_class_init(ObjectClass *klass, void *data)
     x86_class->int_remap = vtd_int_remap;
     /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    dc->desc = "Intel IOMMU (VT-d) DMA Remapping device";
 }
 
 static const TypeInfo vtd_info = {