rxrpc: Mark expected switch fall-through
Subsystems (3)
PATCH 1/1 rxrpc: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ret < 0) {
^net/rxrpc/local_object.c:184:2: note: here
case AF_INET:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Currently, GCC is expecting to find the fall-through annotations at the very bottom of the case and on its own line. That's why I had to add the annotation, although the intentional fall-through is already mentioned in a few lines above.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- net/rxrpc/local_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/rxrpc/local_object.c +1 -1
@@ -180,7 +180,7 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)/* Fall through and set IPv4 options too otherwise we don't get * errors from IPv4 packets sent through the IPv6 socket. */ - +/* Fall through */ case AF_INET :/* we want to receive ICMP errors */ opt =1 ;
Signature · 1 line
2.21.0
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 1 Apr 2019 14:39:31 -0500
Quoted 20 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (ret < 0) { ^
net/rxrpc/local_object.c:184:2: note: here
caseAF_INET:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Currently, GCC is expecting to find the fall-through annotations at the very bottom of the case and on its own line. That's why I had to add the annotation, although the intentional fall-through is already mentioned in a few lines above.
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.
Quoted 23 lines · David Miller
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 1 Apr 2019 14:39:31 -0500Quoted 20 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (ret < 0) { ^
net/rxrpc/local_object.c:184:2: note: here
caseAF_INET:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Currently, GCC is expecting to find the fall-through annotations at the very bottom of the case and on its own line. That's why I had to add the annotation, although the intentional fall-through is already mentioned in a few lines above.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied.
Thanks, Dave.
--
Gustavo
David Howells
maintainernet/rxrpc/local_object.c static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net) · line 183
Quoted 5 lines · Gustavo A. R. Silva
net/rxrpc/local_object.c +1
-1/* Fall through and set IPv4 options too otherwise we don't get * errors from IPv4 packets sent through the IPv6 socket. */ - +/* Fall through */
Er, no. Please (a) don't remove the blank line that's providing visual separation and (b) observe that the previous comment already says "Fall through" right at the beginning, so NAK.
If the compiler doesn't recognise this, then fix the compiler please.
David