Skip to contentSkip to conversation

aio: Fix an error code in __io_submit_one()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 3, 2019

Subsystems (3)
VFS Kernel janitors Aio
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 aio: Fix an error code in __io_submit_one()

This accidentally returns the wrong variable. The "req->ki_eventfd" pointer is NULL so this return success.

Fixes 7316b49c2a11 ("aio: move sanity checks and request allocation to io_submit_one()")
Signed-off-by Dan Carpenter <[email protected]>
---
 fs/aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/aio.c +1 -1
index a4cc2a1cccb7..7ccecaab487a 100644
@@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb,
 		 */
 		eventfd = eventfd_ctx_fdget(iocb->aio_resfd);
 		if (IS_ERR(eventfd))
-			return PTR_ERR(req->ki_eventfd);
+			return PTR_ERR(eventfd);
 
 		req->ki_eventfd = eventfd;
 	}
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 2 lines · Dan Carpenter

This accidentally returns the wrong variable. The "req->ki_eventfd" pointer is NULL so this return success.

Applied.