USB: serial: pl2303: fix tranceiver suspend mode

Quoted 16 lines · Johan Hovold

Quoted 14 lines · Johan Hovold

Add helper function to update register bits instead of overwriting the entire control register when updating the flow-control settings.

This specifically avoids having the tranceiver suspend mode (bit 0) depend on the flow control setting.

The tranceiver is currently configured at probe to be disabled during suspend, but this was overridden when disabling flow control or enabling xon/xoff.

Fixes 715f9527c1c1 ("USB: flow control fix for pl2303")

Fixes 7041d9c3f01b ("USB: serial: pl2303: add support for tx xon/xoff flow control")

Signed-off-by Johan Hovold <[email protected]>

---

Quoted 9 lines

Review static const struct pl2303_type_data pl2303_type_data[TYPE_COUNT] = { · line 181

Quoted 6 lines

(quoted diff) +1 -1

@@ -176,7 +178,7 @@ static const struct pl2303_type_data pl2303_type_data[TYPE_COUNT] = {
 	[TYPE_01] = {
 		.max_baud_rate		= 1228800,
 		.quirks			= PL2303_QUIRK_LEGACY,
-		.no_autoxonxoff		= 1,
+		.no_autoxonxoff		= true,

This chunk was supposed to go in the first patch. I'll fix that up before applying (or resending).

With that fixup:

Reviewed-by Greg Kroah-Hartman <[email protected]>