Skip to contentSkip to conversation

core-image-sato-sdk-ptest: Fix free space issues causing test failures

PATCH In review Richard Purdie 2 participants 2 messages Apr 3, 2019 – Apr 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 core-image-sato-sdk-ptest: Fix free space issues causing test failures

Some tests such as strace-ptest require more than the current 500MB of free space. Increase the amount available, staying under the 4GB limit. We have more flexibility now since we shrank kernel-devsrc and the comments are out of date due to that.

This should improve the strace-ptest results and the util-linux ones since those sort after strace and also hit the space issues as strace-ptest didn't clean up after itself when failing.

---
 meta/recipes-sato/images/core-image-sato-sdk-ptest.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
meta/recipes-sato/images/core-image-sato-sdk-ptest.bb +4 -3
index 7e3152b4a11..1027ec03be0 100644
@@ -4,11 +4,12 @@ DESCRIPTION += "Also includes ptest packages."
 
 IMAGE_FEATURES += "ptest-pkgs"
 
-# This image is sufficiently large (~3GB) that it can't actually fit in a live
+# This image is sufficiently large (~1.8GB) that we need to be careful that it fits in a live
 # image (which has a 4GB limit), so nullify the overhead factor (1.3x out of the
-# box) and explicitly add just 500MB.
+# box) and explicitly add just 1500MB.
+# strace-ptest in particular needs more than 500MB
 IMAGE_OVERHEAD_FACTOR = "1.0"
-IMAGE_ROOTFS_EXTRA_SPACE = "524288"
+IMAGE_ROOTFS_EXTRA_SPACE = "1524288"
 
 # ptests need more memory than standard to avoid the OOM killer
 QB_MEM = "-m 1024"
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Richard Purdie

Some tests such as strace-ptest require more than the current 500MB of free space. Increase the amount available, staying under the 4GB limit. We have more flexibility now since we shrank kernel-devsrc and the comments are out of date due to that.

Won't this be more of a common issue for any image that pulls in the same stuff is is not named sato?

- armin

Quoted 29 lines

This should improve the strace-ptest results and the util-linux ones since those sort after strace and also hit the space issues as strace-ptest didn't clean up after itself when failing.

---
 meta/recipes-sato/images/core-image-sato-sdk-ptest.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
meta/recipes-sato/images/core-image-sato-sdk-ptest.bb +4 -3
index 7e3152b4a11..1027ec03be0 100644
@@ -4,11 +4,12 @@ DESCRIPTION += "Also includes ptest packages."
 
 IMAGE_FEATURES += "ptest-pkgs"
 
-# This image is sufficiently large (~3GB) that it can't actually fit in a live
+# This image is sufficiently large (~1.8GB) that we need to be careful that it fits in a live
 # image (which has a 4GB limit), so nullify the overhead factor (1.3x out of the
-# box) and explicitly add just 500MB.
+# box) and explicitly add just 1500MB.
+# strace-ptest in particular needs more than 500MB
 IMAGE_OVERHEAD_FACTOR = "1.0"
-IMAGE_ROOTFS_EXTRA_SPACE = "524288"
+IMAGE_ROOTFS_EXTRA_SPACE = "1524288"
 
 # ptests need more memory than standard to avoid the OOM killer
 QB_MEM = "-m 1024"