ath10k: coredump: use struct_size() helper
Subsystems (3)
PATCH 1/1 ath10k: coredump: use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used.
So, replace code of the following form:
sizeof(*ce_hdr) + CE_COUNT * sizeof(ce_hdr->entries[0])
with:
struct_size(ce_hdr, entries, CE_COUNT)
This code was detected with the help of Coccinelle.
--- drivers/net/wireless/ath/ath10k/coredump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/coredump.c +2 -2
@@ -1192,8 +1192,8 @@ static struct ath10k_dump_file_data *ath10k_coredump_build(struct ath10k *ar)if (test_bit (ATH10K_FW_CRASH_DUMP_CE_DATA , &ath10k_coredump_mask)) { dump_tlv = (struct ath10k_tlv_dump_data *)(buf + sofar); dump_tlv->type =cpu_to_le32 (ATH10K_FW_CRASH_DUMP_CE_DATA ); - dump_tlv->tlv_len =cpu_to_le32 (sizeof (*ce_hdr) + -CE_COUNT *sizeof (ce_hdr->entries[0 ])); + dump_tlv->tlv_len =cpu_to_le32 (struct_size (ce_hdr, entries, +CE_COUNT )); ce_hdr = (struct ath10k_ce_crash_hdr *)(dump_tlv->tlv_data); ce_hdr->ce_count =cpu_to_le32 (CE_COUNT );memset (ce_hdr->reserved,0 ,sizeof (ce_hdr->reserved));
Signature · 7 lines
2.21.0 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 8 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used.So, replace code of the following form:
sizeof(*ce_hdr)+CE_COUNT*sizeof(ce_hdr->entries[0])
Quoted 8 lines
with:
struct_size(ce_hdr, entries, CE_COUNT)This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
4f735cd73650 ath10k: coredump: use struct_size() helper
Signature · 3 lines
https://patchwork.kernel.org/patch/10884377/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 8 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used.So, replace code of the following form:
sizeof(*ce_hdr)+CE_COUNT*sizeof(ce_hdr->entries[0])
Quoted 8 lines
with:
struct_size(ce_hdr, entries, CE_COUNT)This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
4f735cd73650 ath10k: coredump: use struct_size() helper
Signature · 9 lines
https://patchwork.kernel.org/patch/10884377/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k