driver core: platform: Propagate error from insert_resource()
PATCH v2 1/1 driver core: platform: Propagate error from insert_resource()
Since insert_resource() might return an error we don't need to shadow its error code and would safely propagate to the user.
Signed-off-by Andy Shevchenko <[email protected]>
---
- move an assignment to the separate line inside first branch (Rafael)
drivers/base/platform.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/base/platform.c +6 -4
@@ -438,10 +438,12 @@ int platform_device_add(struct platform_device *pdev) p = &ioport_resource; } -if (p &&insert_resource (p, r)) { -dev_err (&pdev->dev,"failed to claim resource %d: %pR\n" , i, r); - ret = -EBUSY ; - goto failed; +if (p) { + ret =insert_resource (p, r); +if (ret) { +dev_err (&pdev->dev,"failed to claim resource %d: %pR\n" , i, r); + goto failed; + } } }
Signature · 1 line
2.20.1
Quoted 5 lines · Andy Shevchenko
Since
insert_resource()might return an error we don't need to shadow its error code and would safely propagate to the user.Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Rafael J. Wysocki <[email protected]>
Quoted 30 lines
---
- move an assignment to the separate line inside first branch (Rafael)drivers/base/platform.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/base/platform.c +6
-5@@ -438,10 +438,12 @@ int platform_device_add(struct platform_device *pdev) p = &ioport_resource; } -if (p &&insert_resource (p, r)) { -dev_err (&pdev->dev,"failed to claim resource %d: %pR\n" , i, r); - ret = -EBUSY ; - goto failed; +if (p) { + ret =insert_resource (p, r); +if (ret) { +dev_err (&pdev->dev,"failed to claim resource %d: %pR\n" , i, r); + goto failed; + } } } --2.20.1