configure: fix pam test warning
PATCH 1/1 configure: fix pam test warning
From: "Dr. David Alan Gilbert" <[email protected]>
The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz.
--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
configure +2 -2
@@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF
Signature · 1 line
2.20.1
CC trivial
Quoted 11 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the
pam_conversationpointer topam_startmust be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz.Signed-off-by Dr. David Alan Gilbert <[email protected]>--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 7 lines
configure +0
-0@@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then int main(void) {
configure if test "$auth_pam" != "no"; then · line 2954
Quoted 10 lines
configure +2
-2const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 8 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the
pam_conversationpointer topam_startmust be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz.Signed-off-by Dr. David Alan Gilbert <[email protected]>
Quoted 21 lines
--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)configure +2
-2@@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF
Laurent Vivier
AppliedQuoted 29 lines · Daniel P. Berrangé
CC trivial
Quoted 11 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the
pam_conversationpointer topam_startmust be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz.Signed-off-by Dr. David Alan Gilbert <[email protected]>--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Quoted 12 lines
configure +1
-1@@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL;
Quoted 9 lines
configure if test "$auth_pam" != "no"; then · line 2954
Quoted 5 lines
configure +1
-1- pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOFRegards,
Daniel
Applied to my trivial-patches branch.
Thanks,
Laurent