Skip to contentSkip to conversation

ALSA: xen-front: Do not use stream buffer size before it is set

PATCH In review Oleksandr Andrushchenko 3 participants 7 messages Apr 4, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: xen-front: Do not use stream buffer size before it is set

From: Oleksandr Andrushchenko <[email protected]>

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
---
 sound/xen/xen_snd_front_alsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/xen/xen_snd_front_alsa.c +1 -1
index a7f413cb704d..b14ab512c2ce 100644
@@ -441,7 +441,7 @@ static int shbuf_setup_backstore(struct xen_snd_front_pcm_stream_info *stream,
 {
 	int i;
 
-	stream->buffer = alloc_pages_exact(stream->buffer_sz, GFP_KERNEL);
+	stream->buffer = alloc_pages_exact(buffer_sz, GFP_KERNEL);
 	if (!stream->buffer)
 		return -ENOMEM;
 
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#6 lore raw
In reply to Oleksandr Andrushchenko
Quoted 8 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
In reply to Juergen Gross
Quoted 4 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Quoted 8 lines
Quoted 6 lines

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")

Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.

Takashi

#5 lore raw
In reply to Juergen Gross
Quoted 4 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Quoted 8 lines
Quoted 6 lines

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")

Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.

Takashi

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
In reply to Takashi Iwai
Quoted 10 lines · Takashi Iwai
Quoted 8 lines · Juergen Gross
Quoted 7 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Quoted 7 lines
Quoted 2 lines
Quoted 1 line

Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.

Takashi

Thank you,
Oleksandr

#4 lore raw
In reply to Takashi Iwai
Quoted 10 lines · Takashi Iwai
Quoted 8 lines · Juergen Gross
Quoted 7 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

This fixes the regression introduced while moving to Xen shared buffer implementation.

Fixes 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Quoted 7 lines
Quoted 2 lines
Quoted 1 line

Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.

Takashi

Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel