samples/bpf: fix build with new clang
Subsystems (3)
Alexei Starovoitov
maintainerPATCH 1/1 samples/bpf: fix build with new clang
clang started to error on invalid asm clobber usage in x86 headers and many bpf program samples failed to build with the message:
CLANG-bpf /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.o
In file included from /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.c:14:
In file included from ../include/linux/in.h:23:
In file included from ../include/uapi/linux/in.h:24:
In file included from ../include/linux/socket.h:8:
In file included from ../include/linux/uio.h:14:
In file included from ../include/crypto/hash.h:16:
In file included from ../include/linux/crypto.h:26:
In file included from ../include/linux/uaccess.h:5:
In file included from ../include/linux/sched.h:15:
In file included from ../include/linux/sem.h:5:
In file included from ../include/uapi/linux/sem.h:5:
In file included from ../include/linux/ipc.h:9:
In file included from ../include/linux/refcount.h:72:../arch/x86/include/asm/refcount.h:72:36: error: asm-specifier for input or output variable conflicts with asm clobber list
r->refs.counter, e, "er", i, "cx");
^
../arch/x86/include/asm/refcount.h:86:27: error: asm-specifier for input or output variable conflicts with asm clobber list
r->refs.counter, e, "cx");
^2 errors generated.
Override volatile() to workaround the problem.
--- samples/bpf/asm_goto_workaround.h | 1 + 1 file changed, 1 insertion(+)
samples/bpf/asm_goto_workaround.h +1 -0
@@ -13,4 +13,5 @@ #define asm_volatile_goto(x...) asm volatile("invalid use of asm_volatile_goto")#endif +#define volatile(x...) volatile("")#endif
Signature · 1 line
2.20.0
Quoted 23 lines · Alexei Starovoitov
clang started to error on invalid asm clobber usage in x86 headers and many bpf program samples failed to build with the message:
CLANG-bpf /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.o
In file included from /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.c:14:
In file included from../include/linux/in.h:23:
In file included from../include/uapi/linux/in.h:24:
In file included from../include/linux/socket.h:8:
In file included from../include/linux/uio.h:14:
In file included from../include/crypto/hash.h:16:
In file included from../include/linux/crypto.h:26:
In file included from../include/linux/uaccess.h:5:
In file included from../include/linux/sched.h:15:
In file included from../include/linux/sem.h:5:
In file included from../include/uapi/linux/sem.h:5:
In file included from../include/linux/ipc.h:9:
In file included from../include/linux/refcount.h:72:../arch/x86/include/asm/refcount.h:72:36: error: asm-specifier for input or output variable conflicts with asm clobber listr->refs.counter, e, "er", i, "cx"); ^ ../arch/x86/include/asm/refcount.h:86:27: error: asm-specifier for input or output variable conflicts with asm clobber list r->refs.counter, e, "cx"); ^
Quoted 5 lines
2 errors generated.
Override
volatile()to workaround the problem.Signed-off-by Alexei Starovoitov <[email protected]>
Applied, thanks!