cpufreq: Add sunxi nvmem based CPU scaling driver
Subsystems (4)
cover cpufreq: Add sunxi nvmem based CPU scaling driver
Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo.
Yangtao Li (2):
cpufreq: Add sunxi nvmem based CPU scaling driver
dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
.../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 +++++++++++++++++ MAINTAINERS | 7 + drivers/cpufreq/Kconfig.arm | 10 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/cpufreq-dt-platdev.c | 2 + drivers/cpufreq/sunxi-cpufreq-nvmem.c | 236 ++++++++++++++++++ 6 files changed, 491 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt create mode 100644 drivers/cpufreq/sunxi-cpufreq-nvmem.c
Signature · 1 line
2.17.0
PATCH 1/2 cpufreq: Add sunxi nvmem based CPU scaling driver
For some SoCs, the CPU frequency subset and voltage value of each OPP varies based on the silicon variant in use. Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
--- MAINTAINERS | 7 + drivers/cpufreq/Kconfig.arm | 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/cpufreq-dt-platdev.c | 2 + drivers/cpufreq/sunxi-cpufreq-nvmem.c | 236 ++++++++++++++++++++++++++ 5 files changed, 256 insertions(+) create mode 100644 drivers/cpufreq/sunxi-cpufreq-nvmem.c
MAINTAINERS +7 -0
@@ -667,6 +667,13 @@ S: Maintained F: Documentation/i2c/busses/i2c-ali1563 F: drivers/i2c/busses/i2c-ali1563.c +ALLWINNER CPUFREQ DRIVER +M: Yangtao Li <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt +F: drivers/cpufreq/sunxi-cpufreq-nvmem.c + ALLWINNER SECURITY SYSTEM M: Corentin Labbe <[email protected]> L: [email protected]
drivers/cpufreq/Kconfig.arm +10 -0
@@ -18,6 +18,16 @@ config ACPI_CPPC_CPUFREQ If in doubt, say N. +config ARM_ALLWINNER_CPUFREQ_NVMEM + tristate "Allwinner nvmem based CPUFreq" + depends on ARCH_SUNXI + depends on NVMEM_SUNXI_SID + select PM_OPP + help + This adds the CPUFreq driver for Allwinner nvmem based SoC. + + If in doubt, say N. + config ARM_ARMADA_37XX_CPUFREQ tristate "Armada 37xx CPUFreq support" depends on ARCH_MVEBU && CPUFREQ_DT
drivers/cpufreq/Makefile +1 -0
@@ -78,6 +78,7 @@ obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o obj-$(CONFIG_ARM_SCPI_CPUFREQ) += scpi-cpufreq.o obj-$(CONFIG_ARM_SPEAR_CPUFREQ) += spear-cpufreq.o obj-$(CONFIG_ARM_STI_CPUFREQ) += sti-cpufreq.o +obj-$(CONFIG_ARM_ALLWINNER_CPUFREQ_NVMEM) += sunxi-cpufreq-nvmem.o obj-$(CONFIG_ARM_TANGO_CPUFREQ) += tango-cpufreq.o obj-$(CONFIG_ARM_TEGRA20_CPUFREQ) += tegra20-cpufreq.o obj-$(CONFIG_ARM_TEGRA124_CPUFREQ) += tegra124-cpufreq.o
drivers/cpufreq/cpufreq-dt-platdev.c +2 -0
@@ -105,6 +105,8 @@ static const struct of_device_id whitelist[] __initconst = {* platforms using "operating-points-v2" property. */ static const struct of_device_id blacklist[]__initconst = { + { .compatible ="allwinner,sun50i-h6" , }, + { .compatible ="calxeda,highbank" , }, { .compatible ="calxeda,ecx-2000" , },
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +236 -0
236 lines not on this page · raw message
Signature · 1 line
2.17.0
PATCH 2/2 dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Yangtao LiAllwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.
This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:
0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unused
--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +235 -0
@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cells + bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unused + +Example 1: +--------- + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <0>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu1: cpu@1 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <1>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu2: cpu@2 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <2>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu3: cpu@3 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <3>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + }; + + cpu_opp_table: opp_table { + compatible = "operating-points-v2-sunxi-cpu"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp-480000000-0 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-0 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-0 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-0 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-0 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <1060000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-0 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-0 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-1 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-1 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-1 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-1 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-1 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-1 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-1 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1000000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-2 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-2 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-2 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-2 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-2 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <840000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-2 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <900000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-2 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <960000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + }; + +.... +soc { +.... + sid: sid@3006000 { + compatible = "allwinner,sun50i-h6-sid"; + reg = <0x03006000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + .... + speedbin_efuse: speed@1c { + reg = <0x1c 4>; + }; + }; +};
Signature · 1 line
2.17.0
Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Hi,
Quoted 53 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unusedSigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +23
-0@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cells
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 33
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unused
I'm wondering if that's the right approach.
I guess we could also have three different OPP tables, and pass them all three through a phandle array, and have the kernel code select which one is relevant based on the SID content
Another option would be to use the OF_DYNAMIC code to fill operating-points-v2 at kernel boot, before (or when) cpufreq kicks in.
ATF could also do that work.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Samuel Holland
maintainerRe: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 69 lines · Maxime Ripard
Hi,
Quoted 53 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unusedSigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +23
-0@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cellsDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 33
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unusedI'm wondering if that's the right approach.
Quoted 8 lines
I guess we could also have three different OPP tables, and pass them all three through a phandle array, and have the kernel code select which one is relevant based on the SID content
Another option would be to use the
OF_DYNAMICcode to fill operating-points-v2 at kernel boot, before (or when) cpufreq kicks in.ATF could also do that work.
While ATF has code to read and parse the DTB (which it uses to set up the PMIC), it's not really in a position to modify the DTB. For one thing, it only has access to the DTB appended to u-boot, not any DTB loaded from disk. And for two, that would add a significant amount of code, when ATF is already reaching its size limits.
Cheers,
Samuel
Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Maxime RipardQuoted 70 lines · Maxime Ripard
Hi,
Quoted 53 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unusedSigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +23
-0@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cellsDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 33
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unusedI'm wondering if that's the right approach.
Quoted 3 lines
I guess we could also have three different OPP tables, and pass them all three through a phandle array, and have the kernel code select which one is relevant based on the SID content
It's ok. But why not use the way we already have?
Is it necessary to introduce new helper?
Quoted 3 lines
Another option would be to use the
OF_DYNAMICcode to fill operating-points-v2 at kernel boot, before (or when) cpufreq kicks in.
My thought is to keep the same with others. And this situation may make thingis complex though it works.
Hi vireshk,
I want to hear from you.
Yours,
Yangtao
Quoted 9 lines
ATF could also do that work.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 71 lines · Frank Lee
Quoted 70 lines · Maxime Ripard
Hi,
Quoted 53 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unusedSigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +23
-0@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cellsDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 33
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unusedI'm wondering if that's the right approach.
Quoted 6 lines
Quoted 3 lines
I guess we could also have three different OPP tables, and pass them all three through a phandle array, and have the kernel code select which one is relevant based on the SID content
It's ok. But why not use the way we already have?
Is it necessary to introduce new helper?
My main concern is that it becomes quite difficult to differentiate the various OPPs, and to which bin a particular OPP is belonging to, while the more traditional OPPv2 makes it much more obvious.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Viresh Kumar
maintainerRe: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Yangtao LiQuoted 174 lines · Yangtao Li
+++
b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +173
-0+ cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <0>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu1: cpu@1 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <1>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu2: cpu@2 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <2>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu3: cpu@3 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <3>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + }; + + cpu_opp_table: opp_table { + compatible = "operating-points-v2-sunxi-cpu"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp-480000000-0 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-0 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-0 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-0 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-0 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <1060000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-0 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-0 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-1 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-1 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-1 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-1 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-1 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-1 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-1 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1000000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-2 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-2 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-2 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-2 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-2 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <840000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-2 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <900000>;
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 220
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-2 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <960000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + };
Well, this is pure duplication of all the OPPs which isn't great. If I have understood things correctly from the above example, then all you want is a different microvolt value for each OPP, right ?
Then you are using the wrong feature of OPP core I am afraid. What you should rather look for is opp-microvolt-<name> property, look in opp.txt bindings.
And these are the helper you need to use:
dev_pm_opp_set_prop_name()/dev_pm_opp_put_prop_name().
Signature · 1 line
viresh
Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 182 lines · Viresh Kumar
Quoted 180 lines · Yangtao Li
+++
b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +179
-0+ cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <0>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu1: cpu@1 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <1>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu2: cpu@2 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <2>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu3: cpu@3 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <3>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + }; + + cpu_opp_table: opp_table { + compatible = "operating-points-v2-sunxi-cpu"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp-480000000-0 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-0 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-0 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-0 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-0 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <1060000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-0 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-0 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1160000>; + opp-supported-hw = <0x1>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-1 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-1 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-1 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-1 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <820000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-1 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <880000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-1 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <940000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-1 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <1000000>; + opp-supported-hw = <0x2>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + + opp-480000000-2 { + opp-hz = /bits/ 64 <480000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-720000000-2 { + opp-hz = /bits/ 64 <720000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-816000000-2 { + opp-hz = /bits/ 64 <816000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-888000000-2 { + opp-hz = /bits/ 64 <888000000>; + opp-microvolt = <800000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1080000000-2 { + opp-hz = /bits/ 64 <1080000000>; + opp-microvolt = <840000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1320000000-2 { + opp-hz = /bits/ 64 <1320000000>; + opp-microvolt = <900000>; + opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + opp-1488000000-2 { + opp-hz = /bits/ 64 <1488000000>; + opp-microvolt = <960000>;
Quoted 8 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 189
Quoted 4 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +4
-0+ opp-supported-hw = <0x4>; + clock-latency-ns = <244144>; /* 8 32k periods */ + }; + };Well, this is pure duplication of all the OPPs which isn't great. If I have understood things correctly from the above example, then all you want is a different microvolt value for each OPP, right ?
Not exactly like this. But this is working for the current situation.
Quoted 3 lines
Then you are using the wrong feature of OPP core I am afraid. What you should rather look for is opp-microvolt-<name> property, look in opp.txt bindings.
Yeah. This is more appropriate.
Quoted 3 lines
And these are the helper you need to use:
dev_pm_opp_set_prop_name()/dev_pm_opp_put_prop_name().
Thanks,
Yangtao
Quoted 3 lines
--
viresh
Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Maxime RipardQuoted 77 lines · Maxime Ripard
Quoted 75 lines · Frank Lee
Quoted 73 lines · Maxime Ripard
Hi,
Quoted 53 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.This change adds documentation for the DT bindings.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW:0: speedbin 0 1: speedbin 1 2: speedbin 2 3-31: unusedSigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 235 ++++++++++++++++++ 1 file changed, 235 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +23
-0@@ -0,0 +1,235 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cellsDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 33
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-supported-hw: A single 32 bit bitmap value, representing compatible HW. + Bitmap: + 0: speedbin 0 + 1: speedbin 1 + 2: speedbin 2 + 3-31: unusedI'm wondering if that's the right approach.
I guess we could also have three different OPP tables, and pass them all three through a phandle array, and have the kernel code select which one is relevant based on the SID content
Quoted 6 lines
Quoted 2 lines
It's ok. But why not use the way we already have?
Is it necessary to introduce new helper?My main concern is that it becomes quite difficult to differentiate the various OPPs, and to which bin a particular OPP is belonging to, while the more traditional OPPv2 makes it much more obvious.
Hi Maxime,
How about the newer patch ?
I think it is clearer. Just add a printk and people will know the opp information used.
Yangtao
Quoted 7 lines
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com