Skip to contentSkip to conversation

generic/504: fix hard coded fd number

PATCH New Murphy Zhou 1 participant 1 message Apr 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/504: fix hard coded fd number

Bash supports file discriptor assignment in this way. So remove the hard coded numbers. Also close this opened fd in cleanup.

---
 tests/generic/504 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/generic/504 +3 -2
index 21d86051..19c6a0e7 100755
@@ -21,6 +21,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _cleanup()
 {
+	exec {test_fd}<&-
 	cd /
 	rm -f $tmp.*
 }
@@ -45,9 +46,9 @@ tf_inode=$(stat -c %i $testfile)
 echo inode $tf_inode >> $seqres.full
 
 # Create new fd by exec
-exec 9> $testfile
+exec {test_fd}> $testfile
 # flock locks the fd then exits, we should see the lock info even the owner is dead
-flock -x 9
+flock -x $test_fd
 cat /proc/locks >> $seqres.full
 
 # Checking
Signature · 1 line
2.21.0