Skip to contentSkip to conversation

Makefile: Remove IDcheck.sh

PATCH New Cyril Hrubis 3 participants 4 messages Apr 8, 2019 – Apr 12, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: Remove IDcheck.sh

There is no point in running the IDcheck on 'make install' as it's completely pointless to print ignored errors on installation which is only confusing users.

Also the same script is even executed as a part of runltp script which is more appropriate place for it.

---
 Makefile | 19 -------------------
 1 file changed, 19 deletions(-)
Makefile +0 -19
index 170c2da20..c46d050ce 100644
@@ -21,11 +21,6 @@
 # Ngie Cooper, July 2009
 #
 
-# Force IDcheck.sh to fix any issues found with $(DESTDIR)/etc/group and
-# $(DESTDIR)/etc/passwd automatically when after running the top-level
-# install target.
-CREATE_ENTRIES		?= 0
-
 top_srcdir		?= $(CURDIR)
 
 include $(top_srcdir)/include/mk/env_pre.mk
@@ -42,9 +37,6 @@ vpath %.in		$(top_srcdir)/include
 vpath %.m4		$(top_srcdir)/m4
 vpath %.mk		$(top_srcdir)/mk:$(top_srcdir)/mk/include
 
-# Skip running IDcheck.sh at the end of install?
-SKIP_IDCHECK		?= 0
-
 # User wants uclinux binaries?
 UCLINUX			?= 0
 export UCLINUX
@@ -202,17 +194,6 @@ $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir)
 
 ## Install
 install: $(INSTALL_TARGETS)
-ifeq ($(SKIP_IDCHECK),0)
-	-@CREATE_ENTRIES=$(CREATE_ENTRIES) \
-	 DESTDIR="$(DESTDIR)" \
-	 "$(top_srcdir)/IDcheck.sh"
-else
-	@echo "*******************************************************"
-	@echo "** Will not run IDcheck.sh (SKIP_IDCHECK set to 1).  **"
-	@echo "*******************************************************"
-endif
-
-## Misc targets.
 
 ## Help
 .PHONY: help
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 Makefile: Remove IDcheck.sh

Quoted 9 lines · Cyril Hrubis

There is no point in running the IDcheck on 'make install' as it's completely pointless to print ignored errors on installation which is only confusing users.

Also the same script is even executed as a part of runltp script which is more appropriate place for it.

LGTM!

Quoted 55 lines

---
Makefile | 19 -------------------

1 file changed, 19 deletions(-)
Makefile +0 -5
index 170c2da20..c46d050ce 100644
@@ -21,11 +21,6 @@
 # Ngie Cooper, July 2009
 #
 
-# Force IDcheck.sh to fix any issues found with $(DESTDIR)/etc/group and
-# $(DESTDIR)/etc/passwd automatically when after running the top-level
-# install target.
-CREATE_ENTRIES        ?= 0
-
 top_srcdir        ?= $(CURDIR)
 

include $(top_srcdir)/include/mk/env_pre.mk

Makefile +0 -0
@@ -42,9 +37,6 @@ vpath %.in        $(top_srcdir)/include

vpath %.m4 $(top_srcdir)/m4
vpath %.mk $(top_srcdir)/mk:$(top_srcdir)/mk/include

Makefile +0 -3
-# Skip running IDcheck.sh at the end of install?
-SKIP_IDCHECK        ?= 0
-

# User wants uclinux binaries?
UCLINUX ?= 0
export UCLINUX

Makefile +0 -11
@@ -202,17 +194,6 @@ $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir)
 
 ## Install
 install: $(INSTALL_TARGETS)
-ifeq ($(SKIP_IDCHECK),0)
-    -@CREATE_ENTRIES=$(CREATE_ENTRIES) \
-     DESTDIR="$(DESTDIR)" \
-     "$(top_srcdir)/IDcheck.sh"
-else
-    @echo "*******************************************************"
-    @echo "** Will not run IDcheck.sh (SKIP_IDCHECK set to 1).  **"
-    @echo "*******************************************************"
-endif
-
-## Misc targets.
 
 ## Help

.PHONY: help

Signature · 5 lines
2.19.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

PATCH 1/1 Makefile: Remove IDcheck.sh

In reply to Cyril Hrubis

Hi Cyril,

Quoted 3 lines

There is no point in running the IDcheck on 'make install' as it's completely pointless to print ignored errors on installation which is only confusing users.

+1

Quoted 2 lines

Also the same script is even executed as a part of runltp script which is more appropriate place for it.

+1

I hope to implement one day tst_user() and tst_group() [1]. Than IDcheck.sh could be removed :).

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/issues/468