Skip to contentSkip to conversation

fastboot: Replace literal 32 with PART_NAME_LEN

PATCH New Alex Kiernan 2 participants 2 messages Apr 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fastboot: Replace literal 32 with PART_NAME_LEN

Where we have to compute partition names, rather than using a hardcoded 32 for the partition name length, replace with PART_NAME_LEN.

---

 drivers/fastboot/fb_mmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/fastboot/fb_mmc.c +3 -3
index 4c1c7fd2cd8d..3cebedcd5a92 100644
@@ -31,13 +31,13 @@ static int part_get_info_by_name_or_alias(struct blk_desc *dev_desc,
 
 	ret = part_get_info_by_name(dev_desc, name, info);
 	if (ret < 0) {
-		/* strlen("fastboot_partition_alias_") + 32(part_name) + 1 */
-		char env_alias_name[25 + 32 + 1];
+		/* strlen("fastboot_partition_alias_") + PART_NAME_LEN + 1 */
+		char env_alias_name[25 + PART_NAME_LEN + 1];
 		char *aliased_part_name;
 
 		/* check for alias */
 		strcpy(env_alias_name, "fastboot_partition_alias_");
-		strncat(env_alias_name, name, 32);
+		strncat(env_alias_name, name, PART_NAME_LEN);
 		aliased_part_name = env_get(env_alias_name);
 		if (aliased_part_name != NULL)
 			ret = part_get_info_by_name(dev_desc,
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 fastboot: Replace literal 32 with PART_NAME_LEN

Running md5sum drivers/fastboot/fb_mmc.o before and after the change returns the same result, so this is expectedly a non-functional change.

In addition, git grep -w 32 -- drivers/fastboot/ reveals no other occurrences of the magic number, except in below line where it stands for something unrelated to partition name length:
drivers/fastboot/fb_command.c: char cmdbuf[32];