Skip to contentSkip to conversation

fs/aio.c: fix wrong return value regression in __io_submit_one

PATCH In review Murphy Zhou 2 participants 3 messages Apr 9, 2019 – Apr 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/aio.c: fix wrong return value regression in __io_submit_one

Now it returns 0 when actually error happened, causing kernel hang easily.

Fixes 7316b49 "aio: move sanity checks and request allocation to io_submit_one()"
---
 fs/aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/aio.c +1 -1
index a4cc2a1cccb7..7ccecaab487a 100644
@@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb,
 		 */
 		eventfd = eventfd_ctx_fdget(iocb->aio_resfd);
 		if (IS_ERR(eventfd))
-			return PTR_ERR(req->ki_eventfd);
+			return PTR_ERR(eventfd);
 
 		req->ki_eventfd = eventfd;
 	}
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 4 lines · Murphy Zhou

Now it returns 0 when actually error happened, causing kernel hang easily.

Fixes 7316b49 "aio: move sanity checks and request allocation to io_submit_one()"

See 18bfb9c6a8a5 (aio: Fix an error code in __io_submit_one()) in vfs.git#fixes...

#2 lore raw
Quoted 9 lines · Al Viro
Quoted 4 lines · Murphy Zhou

Now it returns 0 when actually error happened, causing kernel hang easily.

Fixes 7316b49 "aio: move sanity checks and request allocation to io_submit_one()"

See 18bfb9c6a8a5 (aio: Fix an error code in __io_submit_one()) in vfs.git#fixes...

Got it, Thanks!