Skip to contentSkip to conversation

colibri_vf: fix ethernet by adding explicit phy node

PATCH New Marcel Ziswiler 1 participant 1 message Apr 9, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 colibri_vf: fix ethernet by adding explicit phy node

From: Marcel Ziswiler <[email protected]>

The implicit fallback mechanism for searching the whole MDIO bus for at least one PHY has been gone with the following commit b882005a18de ("drivers/net/fec: phy_init: remove redundant logic"). This lead to the Ethernet driver erroring out as follows:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

This commit adds an explicit PHY node which makes it work again.

---

Changes in v2:
- Added Hannes and Igor's reviewed-by.

 arch/arm/dts/vf-colibri.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/arm/dts/vf-colibri.dtsi +13 -0
index 5ce17076e9..91ca4e4ddd 100644
@@ -60,11 +60,24 @@
 	status = "okay";
 };
 
+/* Ethernet */
 &fec1 {
 	phy-mode = "rmii";
+	phy-handle = <&ethphy1>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy1: ethernet-phy at 1 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			max-speed = <100>;
+			reg = <1>;
+		};
+	};
 };
 
 &i2c0 {
Signature · 1 line
2.20.1