drm/ttm: fix dma_fence refcount imbalance on error path
Subsystems (3)
PATCH 1/1 drm/ttm: fix dma_fence refcount imbalance on error path
the ttm_bo_add_move_fence takes a reference to the struct dma_fence, but failed to release it on the error path, leading to a memory leak. add dma_fence_put before return when error occur.
Signed-off-by Lin Yi <[email protected]>
--- drivers/gpu/drm/ttm/ttm_bo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +3 -1
@@ -876,8 +876,10 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,reservation_object_add_shared_fence (bo->resv, fence); ret =reservation_object_reserve_shared (bo->resv,1 ); -if (unlikely (ret)) +if (unlikely (ret)) { +dma_fence_put (fence);return ret; + }dma_fence_put (bo->moving); bo->moving = fence;
Signature · 7 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel